From patchwork Mon Jul 16 11:28:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 944324 X-Patchwork-Delegate: jagannadh.teki@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="ONId+iF/"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 41ThGV1mdcz9ryt for ; Mon, 16 Jul 2018 21:37:22 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id CB606C22104; Mon, 16 Jul 2018 11:35:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 92EDEC22138; Mon, 16 Jul 2018 11:30:01 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id A59AAC21F27; Mon, 16 Jul 2018 11:29:49 +0000 (UTC) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by lists.denx.de (Postfix) with ESMTPS id A225EC22073 for ; Mon, 16 Jul 2018 11:29:45 +0000 (UTC) Received: by mail-pg1-f193.google.com with SMTP id r5-v6so7337974pgv.0 for ; Mon, 16 Jul 2018 04:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PKXSgaa0DiwbeuvV/xAupnNA3tAb/MBwx/xhsjXlk9U=; b=ONId+iF/rZT2Rx+pQozG5pk70HwdOIEzmDNjrqov4woSYnkn12sS5DIViyTo2/9Cng lzzPVYF+sgWpPXyaVnoA9lm32FEwQZMGRSnerPHJVLGKQsi/vJK52hZNZoQdrjCcLf40 VC8pTMsONZPctH/Wxzi72/c200ql7ocifpsEk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PKXSgaa0DiwbeuvV/xAupnNA3tAb/MBwx/xhsjXlk9U=; b=ky1wF1b7PmqlvcuDIfX+U265N2O5mdO8LmRcAYl9mnGUxIXWaKIDL1B5JuTC4YtS3E AHbyxoOWiLFlQG6SU7X0Q58zrm83U5kR8MNtMc/sTiT1yGFUjZBkw4v7FMRxPTpZ756s azBc/z9SM/TYpdHLl3ZitSJ6N3RMEsDU37NgGQv2A0leuSf44NsRqMp2+/8iuxsFjUhO zzifg7PmiLmh3V5fW7ie3mXxU1nTQk2qJM9ap2SHk65BWTyxsH5zxyhaoZgbcnYCD6J4 V4beqA7EL1sHiZp5JUZrvsxpoALuuzG/F6ajz2AWe9MohfvXkSp088Lf+QWXjCp5j98v AuQA== X-Gm-Message-State: AOUpUlG/pC2iE6g6YrRmansyM65nmpwPyySaDV3FmGSr6adgG5de5O7r Lz9U42EWle9004RX0mgon064qg== X-Google-Smtp-Source: AAOMgpfhaXQFju/BpD1Rk9vz+3k9pclwDlJtpDcoJEj9/4t75wSX4sCHHzzVteS5YqlNQ8oGwNU+WQ== X-Received: by 2002:a62:d24a:: with SMTP id c71-v6mr17648333pfg.242.1531740584305; Mon, 16 Jul 2018 04:29:44 -0700 (PDT) Received: from localhost.localdomain ([49.206.203.161]) by smtp.gmail.com with ESMTPSA id u9-v6sm20817464pfi.4.2018.07.16.04.29.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Jul 2018 04:29:43 -0700 (PDT) From: Jagan Teki To: Maxime Ripard , Andre Przywara Date: Mon, 16 Jul 2018 16:58:30 +0530 Message-Id: <20180716112850.3961-16-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180716112850.3961-1-jagan@amarulasolutions.com> References: <20180716112850.3961-1-jagan@amarulasolutions.com> Cc: Tom Rini , u-boot@lists.denx.de Subject: [U-Boot] [RFC 15/35] reset: Add default request ops X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Missing request ops from respective uclass driver generating "synchronous abort" in Allwinner platform, may be in arm. So add default request ops and give a chance to uclass driver to think whether they really need request or not. Signed-off-by: Jagan Teki --- drivers/reset/reset-uclass.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/reset/reset-uclass.c b/drivers/reset/reset-uclass.c index 3899537635..99881b8b99 100644 --- a/drivers/reset/reset-uclass.c +++ b/drivers/reset/reset-uclass.c @@ -14,6 +14,11 @@ static inline struct reset_ops *reset_dev_ops(struct udevice *dev) return (struct reset_ops *)dev->driver->ops; } +static int reset_request_default(struct reset_ctl *reset_ctl) +{ + return 0; +} + static int reset_of_xlate_default(struct reset_ctl *reset_ctl, struct ofnode_phandle_args *args) { @@ -69,7 +74,10 @@ int reset_get_by_index(struct udevice *dev, int index, return ret; } - ret = ops->request(reset_ctl); + if (ops->request) + ret = ops->request(reset_ctl); + else + ret = reset_request_default(reset_ctl); if (ret) { debug("ops->request() failed: %d\n", ret); return ret;