From patchwork Mon Jun 4 11:45:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Seung-Woo Kim X-Patchwork-Id: 924967 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="PesPka2b"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 40ztS36kzDz9s0W for ; Mon, 4 Jun 2018 21:46:11 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 91B3CC21F48; Mon, 4 Jun 2018 11:46:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 68310C21EBA; Mon, 4 Jun 2018 11:46:06 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 70C50C21EBA; Mon, 4 Jun 2018 11:46:05 +0000 (UTC) Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by lists.denx.de (Postfix) with ESMTPS id 1C95BC21E89 for ; Mon, 4 Jun 2018 11:46:04 +0000 (UTC) Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20180604114600epoutp024d485e4639fd082730a0501c5014cb67~08nWNBirq3067630676epoutp02D for ; Mon, 4 Jun 2018 11:46:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20180604114600epoutp024d485e4639fd082730a0501c5014cb67~08nWNBirq3067630676epoutp02D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1528112760; bh=2909vo25EHZuyJzx3ESpPzT8eSP2c9hhW+3SerJ22lc=; h=From:To:Cc:Subject:Date:References:From; b=PesPka2bkCK77tMDs2Q3s3sSL8c4/CGmR+2/ONVNuEAnAPmZpo+wGa1awIyPWhvGG U8qk9lr2MZ7HaVJIvYkCfkB0O/7iEYPg/Q3vkQTb2r3ibsEj9l44sld0HWsNN3s5r7 54diKbfgE4O1gRQZ3vZpvL5KYWrVW/tC7vvh9na4= Received: from epsmges1p5.samsung.com (unknown [182.195.40.152]) by epcas1p4.samsung.com (KnoxPortal) with ESMTP id 20180604114557epcas1p40ae4a1254f6f224419c7bcda22f59d5b~08nTWay3F3156431564epcas1p4z; Mon, 4 Jun 2018 11:45:57 +0000 (GMT) Received: from epcas1p3.samsung.com ( [182.195.41.47]) by epsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id CD.96.04203.576251B5; Mon, 4 Jun 2018 20:45:57 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p3.samsung.com (KnoxPortal) with ESMTPA id 20180604114556epcas1p373ba4abe43a2441abc99c8c17a757aec~08nSs2JOq1074810748epcas1p32; Mon, 4 Jun 2018 11:45:56 +0000 (GMT) Received: from epsmgms1p2new.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20180604114556epsmtrp13b65f06504f5c96a638b81c9476d0fe5~08nSpMl5Q1051010510epsmtrp1d; Mon, 4 Jun 2018 11:45:56 +0000 (GMT) X-AuditID: b6c32a39-235ff7000000106b-3f-5b152675c086 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p2new.samsung.com (Symantec Messaging Gateway) with SMTP id F0.38.03631.476251B5; Mon, 4 Jun 2018 20:45:56 +0900 (KST) Received: from localhost.localdomain (unknown [10.113.63.231]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20180604114556epsmtip2864a89c76aca55723f6f949db8c09572~08nSdfCbR1745217452epsmtip2I; Mon, 4 Jun 2018 11:45:56 +0000 (GMT) From: Seung-Woo Kim To: u-boot@lists.denx.de Date: Mon, 4 Jun 2018 20:45:54 +0900 X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNKsWRmVeSWpSXmKPExsWy7bCmvm6pmmi0waYONosbv9pYLZ6/u8xk 8XzhD2aLb1u2MVrMmPySzaJr0Somi7d7O9kd2D1mN1xk8Zg36wSLx85Zd9k9zt7ZwejRt2UV o8eKle+ZAtiiUm0yUhNTUosUUvOS81My89JtlbyD453jTc0MDHUNLS3MlRTyEnNTbZVcfAJ0 3TJzgI5RUihLzCkFCgUkFhcr6dvZFOWXlqQqZOQXl9gqRRsaGukZGpjrGRkBaeNYKyNToJKE 1Iymu3EF99gr2n51sDQwbmLrYuTkkBAwkbi5fBNrFyMXh5DADkaJCzPaoZxPjBJf5k+Fcr4x Stz/f4IJpuXPnq+MEIm9jBJXni0DmyUk8JlR4lMLK4jNJqAjsX/JbzBbREBC4lf/VUYQm1mg VqJz01H2LkYODmGBEIm571lAwiwCqhJ/zs4GC0sIKEjMmWQDMl5CoINN4sGJr2B7eQXKJI5f 2wRV4yLx/WgRxDnCEq+Ob2GHsKUkXva3QdntjBIHZ9ZBzJnCKHHt7yeohLHEs4VdTCBzmAU0 Jdbv0oe4jE/i3dceVojxvBIdbUIQ1SoSO49OYoMIS0nM2hAMEfaQ+LZ7GiNIWEggVuJZP/cE RplZCCMXMDKuYhRLLSjOTU8tNiww1StOzC0uzUvXS87P3cQITkhaljsYj53zOcQowMGoxMO7 wlgkWog1say4MvcQowQHs5IIL/tJoBBvSmJlVWpRfnxRaU5q8SFGU2BoTWSWEk3OBybLvJJ4 Q1MjY2NjCxNDM1NDQyVx3oqbAtFCAumJJanZqakFqUUwfUwcnFINjPu5nz48dW2VziGfZe7v HzCtf3Ip/a5q9Nqdn7feFIxMuO3OPeljov3luarK5eHJPjuD08385cRWpPWsmG1r+Wzdb+fa m38+vLRKdUsKsqq+HtCx49nvJ7ozu6xij1/xTLo4a9n/6QJPrRh5xU0ubNmyLCKr2oJdKyR+ Wsjeoun8GXecVinfVFRiKc5INNRiLipOBAC4OpscXgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprALMWRmVeSWpSXmKPExsWy7bCSvG6Jmmi0wbdDohY3frWxWjx/d5nJ 4vnCH8wW37ZsY7SYMfklm0XXolVMFm/3drI7sHvMbrjI4jFv1gkWj52z7rJ7nL2zg9Gjb8sq Ro8VK98zBbBFcdmkpOZklqUW6dslcGU03Y0ruMde0farg6WBcRNbFyMnh4SAicSfPV8Zuxi5 OIQEdjNKbFy+iQUiISUx99t2oAQHkC0scfhwMUTNR0aJp19OgDWzCehI7F/ymxXEFhGQkPjV fxVsELNAK6PEmp4nYIOEBYIkLnY+ACtiEVCV+HN2NjuIzSvgKjHp3jmoBQoScybZTGDkWcDI sIpRMrWgODc9t9iwwCgvtVyvODG3uDQvXS85P3cTIzictLR2MJ44EX+IUYCDUYmHd4WxSLQQ a2JZcWXuIUYJDmYlEV72k0Ah3pTEyqrUovz4otKc1OJDjNIcLErivPL5xyKFBNITS1KzU1ML UotgskwcnFINjGE1pdsnNk+9vC5wpiT3++USj217xL9nGG8LvyXAtlBT4ZJ8UMBdb7E1W1X6 JuUvcXfaKzz9P39xQX3eU8VZ4WJXhffVGL1d+ktNb8vNoryqNgfBhWeW2ZmlTnK+tmXFPRWx uXmSj33ldn9/1fiZ55nnihmXG4Nm7prsmhkdeTtQK6LTskbYTYmlOCPRUIu5qDgRAM7NF9sj AgAA Message-Id: <20180604114556epcas1p373ba4abe43a2441abc99c8c17a757aec~08nSs2JOq1074810748epcas1p32@epcas1p3.samsung.com> X-CMS-MailID: 20180604114556epcas1p373ba4abe43a2441abc99c8c17a757aec X-Msg-Generator: CA CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20180604114556epcas1p373ba4abe43a2441abc99c8c17a757aec References: Subject: [U-Boot] [PATCH] fs: fat: fix wrong casting to unsigned value of sect_to_cluster() X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" After the commit 265edc03d5a1 ("fs/fat: Clean up open-coded sector <-> cluster conversions"), it is hung up writing new file to FAT16 disk with more than 19 files in armv7. It is because result value of sect_to_cluster() is not proper by casting from signed value to unsigned value. Fix the wrong casting of sect_to_cluster(). Reported-by: Jaehoon Chung Signed-off-by: Seung-Woo Kim Reviewed-by: Lukasz Majewski --- include/fat.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/fat.h b/include/fat.h index 7dada41..09e1423 100644 --- a/include/fat.h +++ b/include/fat.h @@ -180,7 +180,7 @@ static inline u32 clust_to_sect(fsdata *fsdata, u32 clust) return fsdata->data_begin + clust * fsdata->clust_size; } -static inline u32 sect_to_clust(fsdata *fsdata, u32 sect) +static inline u32 sect_to_clust(fsdata *fsdata, int sect) { return (sect - fsdata->data_begin) / fsdata->clust_size; }