From patchwork Wed May 16 09:13:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramon Fried X-Patchwork-Id: 914281 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="vZpJcPFu"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 40m80c5R2pz9s2L for ; Wed, 16 May 2018 19:15:12 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 73ABFC21E35; Wed, 16 May 2018 09:15:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id D581CC21D83; Wed, 16 May 2018 09:14:14 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 198B0C21C29; Wed, 16 May 2018 09:14:13 +0000 (UTC) Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by lists.denx.de (Postfix) with ESMTPS id 87C4EC21BE5 for ; Wed, 16 May 2018 09:14:12 +0000 (UTC) Received: by mail-wr0-f196.google.com with SMTP id p18-v6so93069wrm.1 for ; Wed, 16 May 2018 02:14:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hvl44VS/MUi0rWVnCL+yNxcrgcFPp1lPNPl4HUB8xg0=; b=vZpJcPFudteln+FEYxVd6/LmvPkt25+AYfm6NlOwzRejW1kI2r65o0VeL7HNgPK5N/ s7qFjyvQzvASccosFjZ96NG0GMJ4Jz9dWnjHdqxxIRAkg8Q/tdcMhsA3JD1xTUR9ORYk NSQRntrz4PbdvlG7COBZbVJeRHf37tGhs7coAj/TiCbltEh6kC2TJgOdB7DSTwX1X4my JhJV4deRMXKjRHWLqADv4CEsceW24harY1WbovTMeGeprMiTkmta+m2OHJH75DNxNcYM onmt5N+Naa6G+jQJcf00ItMzy15CF9jAaXMjkat7vqOExqfuGUphdh8XNHK7V9N78Pl2 Zoog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hvl44VS/MUi0rWVnCL+yNxcrgcFPp1lPNPl4HUB8xg0=; b=KielK9yk3TjskZkg2Rzow3B0KXmY0XnmBAHTa5ll3GYIywK9Wo/PctqPGi1jVZByGQ fvHvIpZjuGYRT1xygbh6mf57Edm2D9+buz4BACaFwwkxrqrou81hDB/uTG80MJ7P4ydz vrxO33pS85K0fCNXi1Hp07BwWq2YJD4NeDu/ZWISRIBcG9g7z/oDcrh+2BHBAG3Yb58A y1/Mr30kgzUF9pPZ4GCY7gWi4mpcuuFmO2unBi6UravSHfk6O4q+gOOfuN0mqLZQAht/ kcG3LqvTv2/3XS+qQCzO93tyID4wNWwPQXmw8To0zWwMEboT8r6+JMAYFJ243lDkuWJa xahQ== X-Gm-Message-State: ALKqPwfv+8sBaYcvCBIJH43hVZYT99g/pxE4iuvkqOlgVWQlqfPzmvJv LTqEdjnhBffjygZqLR4gQ/tTrtLkUdA= X-Google-Smtp-Source: AB8JxZriqeUj7VtdR+zWx4lW+BvrKsSZBnHQT1KMfHPG1zF12dxsEI24ZX3eyapExJlgGX0oLKsy9w== X-Received: by 2002:adf:a98f:: with SMTP id b15-v6mr79426wrd.48.1526462052219; Wed, 16 May 2018 02:14:12 -0700 (PDT) Received: from localhost.localdomain ([141.226.166.38]) by smtp.gmail.com with ESMTPSA id h12-v6sm1920655wmc.7.2018.05.16.02.14.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 May 2018 02:14:11 -0700 (PDT) From: Ramon Fried To: albert.u.boot@aribaud.net, mateusz.kulikowski@gmail.com, jramirez@baylibre.com, robdclark@gmail.com, sjg@chromium.org Date: Wed, 16 May 2018 12:13:37 +0300 Message-Id: <20180516091342.7509-2-ramon.fried@gmail.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180516091342.7509-1-ramon.fried@gmail.com> References: <20180516091342.7509-1-ramon.fried@gmail.com> Cc: u-boot@lists.denx.de Subject: [U-Boot] [PATCH v2 2/7] serial: serial_msm: fail probe if settings clocks fails X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Failure to set the clocks will causes data abort exception when trying to write to AHB uart registers. This patch ensures that we don't touch these registers if clock setting failed. Signed-off-by: Ramon Fried Reviewed-by: Simon Glass --- v2: on failure, return actual return code from msm_uart_clk_init drivers/serial/serial_msm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/serial/serial_msm.c b/drivers/serial/serial_msm.c index 119e6b9846..8b585deeeb 100644 --- a/drivers/serial/serial_msm.c +++ b/drivers/serial/serial_msm.c @@ -181,10 +181,12 @@ static int msm_uart_clk_init(struct udevice *dev) static int msm_serial_probe(struct udevice *dev) { + int ret; struct msm_serial_data *priv = dev_get_priv(dev); - msm_uart_clk_init(dev); /* Ignore return value and hope clock was - properly initialized by earlier loaders */ + ret = msm_uart_clk_init(dev); + if (ret) + return ret; if (readl(priv->base + UARTDM_SR) & UARTDM_SR_UART_OVERRUN) writel(UARTDM_CR_CMD_RESET_ERR, priv->base + UARTDM_CR);