From patchwork Mon May 7 07:33:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 909562 X-Patchwork-Delegate: jagannadh.teki@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="e+qG16X2"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 40fZHv4Zh5z9ryk for ; Mon, 7 May 2018 17:39:07 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 1E991C220C2; Mon, 7 May 2018 07:36:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=RCVD_IN_MSPIKE_H2, RCVD_IN_SORBS_WEB, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 3528DC22088; Mon, 7 May 2018 07:34:50 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 0BFBAC22037; Mon, 7 May 2018 07:34:15 +0000 (UTC) Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com [209.85.192.195]) by lists.denx.de (Postfix) with ESMTPS id 6A6E4C22067 for ; Mon, 7 May 2018 07:34:11 +0000 (UTC) Received: by mail-pf0-f195.google.com with SMTP id a22so8072671pfn.6 for ; Mon, 07 May 2018 00:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7ZP6JRvA01HZBDIsHl/4JIZLhQHsBLsbY5ekCL7DBj0=; b=e+qG16X2ZDSbCBhKX321n8/UXWSYRzY3L9v2VzhgqZ2FIahtGK+xVhUHFJi4YV1BOJ BlFm4yFuMKz9y2zo6mEc/jwRpxx2HPHbH9NAiGrcJ11Yf4uHv97DHQmKppJav3jVglPX FDkoEUuDl4gs2POF2QuULG1Tkhacshv87BZYY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7ZP6JRvA01HZBDIsHl/4JIZLhQHsBLsbY5ekCL7DBj0=; b=QZwriMo08ChsbiqSEBE/99keeDsnh7rzxdDrJNyLsc9iKfC8JuNN3yfFnRMmHxx0S7 L22ZmdYLSxNGe4qj6Xg7eX6LmR0+9uUkhSyglTH3SDCWv1B5UuMfwnHR/h72o9C9xJEa lNS04QEnp6DR5EhAxrqSN6J674MT1KVsZMD9yu7q7vxcgbrur2/wBuiRgDN3Bbf/fpip HiNa5tKYiORHdvfMmR/cRT9XsOS89bJKLK8b1FzSPpjnpcapznH/9nsYzvg2B6/vrGUV RrBhD1lUvdLRPusXeY2MpNmypP6Zd3UuuFWL35J4R1LwW+cvIrelx/Slv47J65mzuyt+ XZ/w== X-Gm-Message-State: ALQs6tBAVRzb7MOgVVmbAGCxA5tmh2S20S8W/NPs1qhixtKSRvqnOGYB J3ywItE87unWvJc2QD2+lqkPH6THLEg= X-Google-Smtp-Source: AB8JxZqoT+slyy9kJHNAvlsMHwS86+yDvRxva5gpKeozonckFwYWDmtt4hKIWbDh2UHv4osAzzjRZw== X-Received: by 10.98.204.220 with SMTP id j89mr36383841pfk.182.1525678449599; Mon, 07 May 2018 00:34:09 -0700 (PDT) Received: from localhost.localdomain ([183.82.228.172]) by smtp.gmail.com with ESMTPSA id 76sm59400891pfm.178.2018.05.07.00.34.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 May 2018 00:34:09 -0700 (PDT) From: Jagan Teki To: u-boot@lists.denx.de Date: Mon, 7 May 2018 13:03:19 +0530 Message-Id: <20180507073351.30582-4-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180507073351.30582-1-jagan@amarulasolutions.com> References: <20180507073351.30582-1-jagan@amarulasolutions.com> Cc: Maxime Ripard , Marek Vasut , linux-sunxi@googlegroups.com Subject: [U-Boot] [PATCH v7 03/35] musb: sunxi: Use simple way to fill musb_hdrc pdata X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Filling musb_hdrc pdata using structure will unnecessary add extra ifdefs, so fill them inside probe call for better code understanding and get rid ifdefs using devicetree compatible. Signed-off-by: Jagan Teki --- drivers/usb/musb-new/sunxi.c | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/drivers/usb/musb-new/sunxi.c b/drivers/usb/musb-new/sunxi.c index 3f3b89886a..637e8b9b52 100644 --- a/drivers/usb/musb-new/sunxi.c +++ b/drivers/usb/musb-new/sunxi.c @@ -308,22 +308,12 @@ static struct musb_hdrc_config musb_config = { .ram_bits = SUNXI_MUSB_RAM_BITS, }; -static struct musb_hdrc_platform_data musb_plat = { -#if defined(CONFIG_USB_MUSB_HOST) - .mode = MUSB_HOST, -#else - .mode = MUSB_PERIPHERAL, -#endif - .config = &musb_config, - .power = 250, - .platform_ops = &sunxi_musb_ops, -}; - static int musb_usb_probe(struct udevice *dev) { struct sunxi_glue *glue = dev_get_priv(dev); struct musb_host_data *host = &glue->mdata; struct usb_bus_priv *priv = dev_get_uclass_priv(dev); + struct musb_hdrc_platform_data pdata; void *base = dev_read_addr_ptr(dev); int ret; @@ -336,8 +326,14 @@ static int musb_usb_probe(struct udevice *dev) priv->desc_before_addr = true; + memset(&pdata, 0, sizeof(pdata)); + pdata.power = 250; + pdata.platform_ops = &sunxi_musb_ops; + pdata.config = &musb_config; + #ifdef CONFIG_USB_MUSB_HOST - host->host = musb_init_controller(&musb_plat, &glue->dev, base); + pdata.mode = MUSB_HOST; + host->host = musb_init_controller(&pdata, &glue->dev, base); if (!host->host) return -EIO; @@ -345,7 +341,8 @@ static int musb_usb_probe(struct udevice *dev) if (!ret) printf("Allwinner mUSB OTG (Host)\n"); #else - ret = musb_register(&musb_plat, &glue->dev, base); + pdata.mode = MUSB_PERIPHERAL; + ret = musb_register(&pdata, &glue->dev, base); if (!ret) printf("Allwinner mUSB OTG (Peripheral)\n"); #endif