Message ID | 20180427150848.12075-10-pure.logic@nexus-software.ie |
---|---|
State | Superseded |
Headers | show
Return-Path: <u-boot-bounces@lists.denx.de> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=nexus-software.ie Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=nexus-software-ie.20150623.gappssmtp.com header.i=@nexus-software-ie.20150623.gappssmtp.com header.b="G4rCxjL7"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 40XcrD0dTbz9s1P for <incoming@patchwork.ozlabs.org>; Sat, 28 Apr 2018 01:13:00 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id AF94AC2221D; Fri, 27 Apr 2018 15:11:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id E793CC22226; Fri, 27 Apr 2018 15:09:35 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 4EEB0C2221E; Fri, 27 Apr 2018 15:09:09 +0000 (UTC) Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by lists.denx.de (Postfix) with ESMTPS id 1156EC221E2 for <u-boot@lists.denx.de>; Fri, 27 Apr 2018 15:09:06 +0000 (UTC) Received: by mail-wm0-f68.google.com with SMTP id j5so3504373wme.5 for <u-boot@lists.denx.de>; Fri, 27 Apr 2018 08:09:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=UKL+ojJfh5Gz4+LAcodowrdvTNlHMs5FAsKe5DAeTAY=; b=G4rCxjL7UAW5lik/HYO3Q0VN3jkw5NIL09lOiRq0MmgmNDGn+Rbo3sxfi/Yij6TYLJ ug1h41ccyLZR7n+wjFa9d3p1K1vNW1O4FyInwiQPOGEkAdbHW04t0xUpe5bM7SvqkhTm KE1plyk6NucPmos0Fb8UlGCwA2HY8u4X2fGRH4FI36N/SM9s/w5zhISFq61HvjptC5QU n8jrIl8Euz6sYEmua3vx3EYcjZJdYemWQGC7ugQSzf2iYB6j/ZwFf0aNWJ3oiRKjIpLV cZ6+awZmR5VA0sBXAdbxhKytEqK3ngO5IJKMTUQLOcwRew/y3S8vwNglB5dl0FNL5e2L Zihw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=UKL+ojJfh5Gz4+LAcodowrdvTNlHMs5FAsKe5DAeTAY=; b=jOc5Fqni3VJUC+r536G5SeE5Q0Pq8ar9rjn51EmErA5pIKrlhi1FBF/8h3TxudtRpG xIeGvZ//+ciEa+z9fZbCwSQp78iKF96lsqV5gkTajWoSFoKwAhN/RELzB2Bo6ecH1wqU wg28cyyrXpgqDXpSJi6pnN96tbkMSnkBV6zGOhwNkKYyka3yzITueogUwMiUuZli8yax e7Me9NxRLO3EJriiQgVpvM73i+EMkLfqio+WrmWKL3w23NV/jhCMb2fVVp2Vuj8x4Klc mMOslRnowFGJjk4WA7bf5vC+AHliI0HNAyqxgdKS96qXujEwhObOS6xG8KASkGXYhUrJ BfWw== X-Gm-Message-State: ALQs6tAsg8zYkLDukbfWLsTVyh108qPQaQOSt58HP+XnQta5X91uNqhU kNi9WbwIVdOg7WNRIZQ0sCXGu/GK X-Google-Smtp-Source: AB8JxZr0bpgvpU8MW31Kf5UvaptOHwM2z7n2G8NTMM5qWaMA9CTF/plX2A8ZyXSCAHvV+lX0mL6rjg== X-Received: by 2002:a50:a1a5:: with SMTP id 34-v6mr3895884edk.273.1524841745195; Fri, 27 Apr 2018 08:09:05 -0700 (PDT) Received: from event-horizon.net ([109.255.42.2]) by smtp.gmail.com with ESMTPSA id d17-v6sm1041063ede.65.2018.04.27.08.09.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Apr 2018 08:09:04 -0700 (PDT) From: Bryan O'Donoghue <pure.logic@nexus-software.ie> To: u-boot@lists.denx.de Date: Fri, 27 Apr 2018 16:08:48 +0100 Message-Id: <20180427150848.12075-10-pure.logic@nexus-software.ie> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180427150848.12075-1-pure.logic@nexus-software.ie> References: <20180427150848.12075-1-pure.logic@nexus-software.ie> Cc: Marek Vasut <marex@denx.de> Subject: [U-Boot] [PATCH 9/9] usb: composite convert __set_bit to generic_set_bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion <u-boot.lists.denx.de> List-Unsubscribe: <https://lists.denx.de/options/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=unsubscribe> List-Archive: <http://lists.denx.de/pipermail/u-boot/> List-Post: <mailto:u-boot@lists.denx.de> List-Help: <mailto:u-boot-request@lists.denx.de?subject=help> List-Subscribe: <https://lists.denx.de/listinfo/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de> |
Series |
Fixup set_bit/clear_bit definition and usage
|
expand
|
diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c index d0ee7847b9..e5d802a80e 100644 --- a/drivers/usb/gadget/composite.c +++ b/drivers/usb/gadget/composite.c @@ -379,7 +379,7 @@ static int set_config(struct usb_composite_dev *cdev, ep = (struct usb_endpoint_descriptor *)*descriptors; addr = ((ep->bEndpointAddress & 0x80) >> 3) | (ep->bEndpointAddress & 0x0f); - __set_bit(addr, f->endpoints); + generic_set_bit(addr, f->endpoints); } result = f->set_alt(f, tmp, 0);
Compiling the f_mass_storage driver for an x86 target results in a compilation error as set_bit and clear_bit are provided by bitops.h To address that situation we discussed on the list moving to genetic_set_bit() instead. Doing a quick grep for similar situations in drivers/usb shows that the composite device is using __set_bit(). This patch switches over to generic_set_bit to maintain consistency between the two gadget drivers. Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie> Cc: Lukasz Majewski <lukma@denx.de> Cc: Marek Vasut <marex@denx.de> --- drivers/usb/gadget/composite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)