diff mbox series

[U-Boot,2/2] ARM: rmobile: Build u-boot-elf.srec on Gen3

Message ID 20180224112418.14203-2-marek.vasut+renesas@gmail.com
State Accepted
Delegated to: Tom Rini
Headers show
Series [U-Boot,1/2] Makefile: add u-boot-elf.srec if CONFIG_REMAKE_ELF is defined | expand

Commit Message

Marek Vasut Feb. 24, 2018, 11:24 a.m. UTC 
From: Masaru Nagai <masaru.nagai.vx@renesas.com>

The u-boot-elf.srec is needed for the minimon update on Gen3 SoCs,
conveniently generate this file.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
---
 include/configs/rcar-gen3-common.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Tom Rini Feb. 24, 2018, 7:16 p.m. UTC | #1 
On Sat, Feb 24, 2018 at 12:24:18PM +0100, Marek Vasut wrote:

> From: Masaru Nagai <masaru.nagai.vx@renesas.com>
> 
> The u-boot-elf.srec is needed for the minimon update on Gen3 SoCs,
> conveniently generate this file.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> ---
>  include/configs/rcar-gen3-common.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/configs/rcar-gen3-common.h b/include/configs/rcar-gen3-common.h
> index 226069d67c..d665caf274 100644
> --- a/include/configs/rcar-gen3-common.h
> +++ b/include/configs/rcar-gen3-common.h
> @@ -13,6 +13,7 @@
>  #include <asm/arch/rmobile.h>
>  
>  #define CONFIG_REMAKE_ELF
> +#define CONFIG_BUILD_TARGET	"u-boot-elf.srec"
>  
>  /* boot option */
>  #define CONFIG_SUPPORT_RAW_INITRD

As is, this is fine.  But, there's a small number of CONFIG_BUILD_TARGET
platforms, can you take a pass at Kconfig conversion (and you should be
able to say default "u-boot-elf.srec" if RCAR_GEN3, default "u-boot.itb"
if ARCH_SUNXI, etc, for the few users we have currently.  Thanks!
Marek Vasut Feb. 24, 2018, 7:50 p.m. UTC | #2 
On 02/24/2018 08:16 PM, Tom Rini wrote:
> On Sat, Feb 24, 2018 at 12:24:18PM +0100, Marek Vasut wrote:
> 
>> From: Masaru Nagai <masaru.nagai.vx@renesas.com>
>>
>> The u-boot-elf.srec is needed for the minimon update on Gen3 SoCs,
>> conveniently generate this file.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
>> ---
>>  include/configs/rcar-gen3-common.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/include/configs/rcar-gen3-common.h b/include/configs/rcar-gen3-common.h
>> index 226069d67c..d665caf274 100644
>> --- a/include/configs/rcar-gen3-common.h
>> +++ b/include/configs/rcar-gen3-common.h
>> @@ -13,6 +13,7 @@
>>  #include <asm/arch/rmobile.h>
>>  
>>  #define CONFIG_REMAKE_ELF
>> +#define CONFIG_BUILD_TARGET	"u-boot-elf.srec"
>>  
>>  /* boot option */
>>  #define CONFIG_SUPPORT_RAW_INITRD
> 
> As is, this is fine.  But, there's a small number of CONFIG_BUILD_TARGET
> platforms, can you take a pass at Kconfig conversion (and you should be
> able to say default "u-boot-elf.srec" if RCAR_GEN3, default "u-boot.itb"
> if ARCH_SUNXI, etc, for the few users we have currently.  Thanks!

After 2018.03 release though, I don't want to break the current one for
anyone.
diff mbox series

Patch

diff --git a/include/configs/rcar-gen3-common.h b/include/configs/rcar-gen3-common.h
index 226069d67c..d665caf274 100644
--- a/include/configs/rcar-gen3-common.h
+++ b/include/configs/rcar-gen3-common.h
@@ -13,6 +13,7 @@ 
 #include <asm/arch/rmobile.h>
 
 #define CONFIG_REMAKE_ELF
+#define CONFIG_BUILD_TARGET	"u-boot-elf.srec"
 
 /* boot option */
 #define CONFIG_SUPPORT_RAW_INITRD