diff mbox series

[U-Boot,2/4] net: sh_eth: Return directly from sh_eth_recv_start

Message ID 20180217000444.8375-2-marek.vasut+renesas@gmail.com
State Accepted
Commit 60279b5757990665386799ccf681d420de295404
Delegated to: Marek Vasut
Headers show
Series [U-Boot,1/4] net: sh_eth: Zap port variable | expand

Commit Message

Marek Vasut Feb. 17, 2018, 12:04 a.m. UTC
Drop the len variable, it's useless.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Cc: Joe Hershberger <joe.hershberger@ni.com>
---
 drivers/net/sh_eth.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Joe Hershberger Feb. 19, 2018, 9:37 p.m. UTC | #1
On Fri, Feb 16, 2018 at 6:04 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> Drop the len variable, it's useless.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> Cc: Joe Hershberger <joe.hershberger@ni.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
diff mbox series

Patch

diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c
index b3c0509989..bdb054a36a 100644
--- a/drivers/net/sh_eth.c
+++ b/drivers/net/sh_eth.c
@@ -120,7 +120,6 @@  err:
 
 static int sh_eth_recv_start(struct sh_eth_dev *eth)
 {
-	int len = 0;
 	struct sh_eth_info *port_info = &eth->port_info[eth->port];
 
 	/* Check if the rx descriptor is ready */
@@ -132,9 +131,7 @@  static int sh_eth_recv_start(struct sh_eth_dev *eth)
 	if (port_info->rx_desc_cur->rd0 & RD_RFE)
 		return -EINVAL;
 
-	len = port_info->rx_desc_cur->rd1 & 0xffff;
-
-	return len;
+	return port_info->rx_desc_cur->rd1 & 0xffff;
 }
 
 static void sh_eth_recv_finish(struct sh_eth_dev *eth)