From patchwork Tue Feb 13 18:23:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 873110 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3zgrY502grz9sRm for ; Wed, 14 Feb 2018 05:24:40 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id B4279C21FD6; Tue, 13 Feb 2018 18:24:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 467A8C21FA8; Tue, 13 Feb 2018 18:24:32 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id CFEA1C21C3F; Tue, 13 Feb 2018 18:24:30 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by lists.denx.de (Postfix) with ESMTPS id 7DBEFC21F8C for ; Tue, 13 Feb 2018 18:24:30 +0000 (UTC) Received: from workstation4.fritz.box ([88.152.14.75]) by mail.gmx.com (mrgmx003 [212.227.17.184]) with ESMTPSA (Nemesis) id 0LaoHI-1eNYqg18dU-00kOyF; Tue, 13 Feb 2018 19:24:26 +0100 From: Heinrich Schuchardt To: Tom Rini Date: Tue, 13 Feb 2018 19:23:29 +0100 Message-Id: <20180213182329.11684-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.14.2 X-Provags-ID: V03:K0:APUD9VBnB3hGQ0ACuMQmuQsguASKyPqOULxoSIvt/JO5bJm3/Ka L2taxTyh3DLg3WMe/mHgYKCvDIxbLaj+pvI8CwCA/ZKjd875L0jkhXnzfyD+Gyv1y809SVu TI37pti8iIH82Fp+stBYmWDPn7N/VX3IzFGzxhuwD6X1l9Lk0Y2kPgQBsphbC8UM2uexYjP 7sqfE6sAx9KvYG0KLyfLw== X-UI-Out-Filterresults: notjunk:1; V01:K0:yDayOq3Aj0U=:UXwxPZ0p/0Akoo4it9ltWM l2NGXmbGaYf8o0vMA7LQDK3A+4m6ldADPfVdDCmLLRBFP0gCjh0aS26OSMy/DiDOb3m5fhyZo ql/1VH1bmPe6u27jFxUraX52gooqzji43bGj4IPnNSEmpu1OQLPyRF/GVIX7cDICyvGAX52AP 8Aqkh9TOxJS124QeCZmHfH28F8z+KtQ7yLxu3W1ZNdRXfF798TBYnUzyHa5tKb9c52Jkb6x3G GX6fkkjH3zBryvfzsKSYNHQ1wK8DsPuV6jy/RdXi5laFEkIH/dcPIHaduNkbpbevafREWd9hw epiEZa71S/i/0q7aZSWcqIRzE6NNuODdOEtcFNs5YDs0WTdGUWp7iJ0v5KVMSvFjKInn4wNLN TCxUPtaCEF1vop1MkjY3tNwkfm63x5FPAPZcmuHZoHJ5dtnRYGfFRtIhkPaFIiERosrrbPOvJ YUCdL3wH1SrrS5lXZyZ5Bk5Tcn8tG1JorPjzL+ke1ZZfQFBkHdyvrMhKHfri/diVvYGLk4A3B g/neSKXUTf90pIUKtcl1WzO98veBKdZkxY2EMQLnO+ou5UGr3AGH1rgJXI0WCll80N/Mux46c bpxhSZxKWQetmT2aaTxvtJ5nBnRwl6EFfMgdieTR07gTB9r7ZftKOTHnFTpF/1HKXHAHUCZuv wmw6ukY1zAGavvk8I0v6NLqRyQujnIycqfX9Na5NnGRPJ7OGPZxelbB+/Lr5QicyFEUWle3Vi TXxwPisZJTUmsqenRIDNSMuLKGZ5rY43TVuBM/DMnDHAEhccY/vXvhDu/eeDcl6qmn2rljSbk 2ncMgZobygiQ/lsYeKQzLI5GKwTrg== Cc: Heinrich Schuchardt , u-boot@lists.denx.de Subject: [U-Boot] [PATCH 1/1] fs: fat: avoid superfluous conversion calling set_cluster X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Parameter size of function set_cluster is of type unsigned long. It makes no sense to convert actsize to int before passing it to set_cluster as size. Signed-off-by: Heinrich Schuchardt Reviewed-by: Lukasz Majewski --- fs/fat/fat_write.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/fat/fat_write.c b/fs/fat/fat_write.c index 2b753df2820..ccc03cecb6e 100644 --- a/fs/fat/fat_write.c +++ b/fs/fat/fat_write.c @@ -679,7 +679,8 @@ set_contents(fsdata *mydata, dir_entry *dentptr, __u8 *buffer, /* set remaining bytes */ actsize = filesize; - if (set_cluster(mydata, curclust, buffer, (int)actsize) != 0) { + if (set_cluster(mydata, curclust, buffer, + (unsigned long)actsize) != 0) { debug("error: writing cluster\n"); return -1; } @@ -696,7 +697,8 @@ set_contents(fsdata *mydata, dir_entry *dentptr, __u8 *buffer, return 0; getit: - if (set_cluster(mydata, curclust, buffer, (int)actsize) != 0) { + if (set_cluster(mydata, curclust, buffer, + (unsigned long)actsize) != 0) { debug("error: writing cluster\n"); return -1; }