| Message ID | 20180121110025.9645-1-peng.fan@nxp.com |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [U-Boot,V2,1/4] mmc: fsl_esdhc: add strobe and tuning entry | expand |
On 01/21/2018 08:00 PM, Peng Fan wrote: > Add entries that will be used for tuning control. > The whole layout not changed, just expand reserved3[84] and > rename other reservedx in sequence. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > Cc: Stefano Babic <sbabic@denx.de> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Jaehoon Chung <jh80.chung@samsung.com> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung > --- > drivers/mmc/fsl_esdhc.c | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) > > diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c > index 71c62f4233..f6279307d8 100644 > --- a/drivers/mmc/fsl_esdhc.c > +++ b/drivers/mmc/fsl_esdhc.c > @@ -61,23 +61,27 @@ struct fsl_esdhc { > uint dllctrl; > uint dllstat; > uint clktunectrlstatus; > - char reserved3[84]; > + char reserved3[4]; > + uint strobe_dllctrl; > + uint strobe_dllstat; > + char reserved4[72]; > uint vendorspec; > uint mmcboot; > uint vendorspec2; > - char reserved4[48]; > + uint tuning_ctrl; /* on i.MX6/7/8 */ > + char reserved5[44]; > uint hostver; /* Host controller version register */ > - char reserved5[4]; /* reserved */ > - uint dmaerraddr; /* DMA error address register */ > char reserved6[4]; /* reserved */ > - uint dmaerrattr; /* DMA error attribute register */ > + uint dmaerraddr; /* DMA error address register */ > char reserved7[4]; /* reserved */ > + uint dmaerrattr; /* DMA error attribute register */ > + char reserved8[4]; /* reserved */ > uint hostcapblt2; /* Host controller capabilities register 2 */ > - char reserved8[8]; /* reserved */ > + char reserved9[8]; /* reserved */ > uint tcr; /* Tuning control register */ > - char reserved9[28]; /* reserved */ > + char reserved10[28]; /* reserved */ > uint sddirctl; /* SD direction control register */ > - char reserved10[712];/* reserved */ > + char reserved11[712];/* reserved */ > uint scr; /* eSDHC control register */ > }; > >
On 21/01/2018 12:00, Peng Fan wrote: > Add entries that will be used for tuning control. > The whole layout not changed, just expand reserved3[84] and > rename other reservedx in sequence. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > Cc: Stefano Babic <sbabic@denx.de> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Jaehoon Chung <jh80.chung@samsung.com> > --- > drivers/mmc/fsl_esdhc.c | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) > > diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c > index 71c62f4233..f6279307d8 100644 > --- a/drivers/mmc/fsl_esdhc.c > +++ b/drivers/mmc/fsl_esdhc.c > @@ -61,23 +61,27 @@ struct fsl_esdhc { > uint dllctrl; > uint dllstat; > uint clktunectrlstatus; > - char reserved3[84]; > + char reserved3[4]; > + uint strobe_dllctrl; > + uint strobe_dllstat; > + char reserved4[72]; > uint vendorspec; > uint mmcboot; > uint vendorspec2; > - char reserved4[48]; > + uint tuning_ctrl; /* on i.MX6/7/8 */ > + char reserved5[44]; > uint hostver; /* Host controller version register */ > - char reserved5[4]; /* reserved */ > - uint dmaerraddr; /* DMA error address register */ > char reserved6[4]; /* reserved */ > - uint dmaerrattr; /* DMA error attribute register */ > + uint dmaerraddr; /* DMA error address register */ > char reserved7[4]; /* reserved */ > + uint dmaerrattr; /* DMA error attribute register */ > + char reserved8[4]; /* reserved */ > uint hostcapblt2; /* Host controller capabilities register 2 */ > - char reserved8[8]; /* reserved */ > + char reserved9[8]; /* reserved */ > uint tcr; /* Tuning control register */ > - char reserved9[28]; /* reserved */ > + char reserved10[28]; /* reserved */ > uint sddirctl; /* SD direction control register */ > - char reserved10[712];/* reserved */ > + char reserved11[712];/* reserved */ > uint scr; /* eSDHC control register */ > }; > > Applied to u-boot-imx, thanks ! Best regards, Stefano Babic
diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c index 71c62f4233..f6279307d8 100644 --- a/drivers/mmc/fsl_esdhc.c +++ b/drivers/mmc/fsl_esdhc.c @@ -61,23 +61,27 @@ struct fsl_esdhc { uint dllctrl; uint dllstat; uint clktunectrlstatus; - char reserved3[84]; + char reserved3[4]; + uint strobe_dllctrl; + uint strobe_dllstat; + char reserved4[72]; uint vendorspec; uint mmcboot; uint vendorspec2; - char reserved4[48]; + uint tuning_ctrl; /* on i.MX6/7/8 */ + char reserved5[44]; uint hostver; /* Host controller version register */ - char reserved5[4]; /* reserved */ - uint dmaerraddr; /* DMA error address register */ char reserved6[4]; /* reserved */ - uint dmaerrattr; /* DMA error attribute register */ + uint dmaerraddr; /* DMA error address register */ char reserved7[4]; /* reserved */ + uint dmaerrattr; /* DMA error attribute register */ + char reserved8[4]; /* reserved */ uint hostcapblt2; /* Host controller capabilities register 2 */ - char reserved8[8]; /* reserved */ + char reserved9[8]; /* reserved */ uint tcr; /* Tuning control register */ - char reserved9[28]; /* reserved */ + char reserved10[28]; /* reserved */ uint sddirctl; /* SD direction control register */ - char reserved10[712];/* reserved */ + char reserved11[712];/* reserved */ uint scr; /* eSDHC control register */ };
Add entries that will be used for tuning control. The whole layout not changed, just expand reserved3[84] and rename other reservedx in sequence. Signed-off-by: Peng Fan <peng.fan@nxp.com> Cc: Stefano Babic <sbabic@denx.de> Cc: Fabio Estevam <fabio.estevam@nxp.com> Cc: Jaehoon Chung <jh80.chung@samsung.com> --- drivers/mmc/fsl_esdhc.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-)