diff mbox series

[U-Boot] efi_loader: don't increment part twice per loop

Message ID 20171010103229.71768-1-jsg@jsg.id.au
State Accepted
Commit bcbc4a80462c42c5d5ccac0287b8a7d49df9e179
Headers show
Series [U-Boot] efi_loader: don't increment part twice per loop | expand

Commit Message

Jonathan Gray Oct. 10, 2017, 10:32 a.m. UTC
Correct a mistake in the part number handling of
16a73b249d138fedeb188710533902ed7aac1ddc and only increment part once
per loop.

Signed-off-by: Jonathan Gray <jsg@jsg.id.au>
---
 lib/efi_loader/efi_disk.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Peter Robinson Oct. 10, 2017, 12:37 p.m. UTC | #1
On Tue, Oct 10, 2017 at 11:32 AM, Jonathan Gray <jsg@jsg.id.au> wrote:
> Correct a mistake in the part number handling of
> 16a73b249d138fedeb188710533902ed7aac1ddc and only increment part once
> per loop.
>
> Signed-off-by: Jonathan Gray <jsg@jsg.id.au>
Tested-by: Peter Robinson <pbrobinson@gmail.com>

Tested on the Pine64

> ---
>  lib/efi_loader/efi_disk.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/lib/efi_loader/efi_disk.c b/lib/efi_loader/efi_disk.c
> index 6b192701a8..e61dbc8058 100644
> --- a/lib/efi_loader/efi_disk.c
> +++ b/lib/efi_loader/efi_disk.c
> @@ -360,7 +360,6 @@ int efi_disk_register(void)
>                                         continue;
>                                 efi_disk_add_dev(devname, if_typename, desc,
>                                                  i, 0, part);
> -                               part++;
>                         }
>
>                         /* ... and add block device: */
> --
> 2.14.2
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
Alexander Graf Oct. 10, 2017, 4:14 p.m. UTC | #2
> Correct a mistake in the part number handling of
> 16a73b249d138fedeb188710533902ed7aac1ddc and only increment part once
> per loop.
> 
> Signed-off-by: Jonathan Gray <jsg@jsg.id.au>
> Tested-by: Peter Robinson <pbrobinson@gmail.com>

Thanks, applied to efi-next

Alex
diff mbox series

Patch

diff --git a/lib/efi_loader/efi_disk.c b/lib/efi_loader/efi_disk.c
index 6b192701a8..e61dbc8058 100644
--- a/lib/efi_loader/efi_disk.c
+++ b/lib/efi_loader/efi_disk.c
@@ -360,7 +360,6 @@  int efi_disk_register(void)
 					continue;
 				efi_disk_add_dev(devname, if_typename, desc,
 						 i, 0, part);
-				part++;
 			}
 
 			/* ... and add block device: */