| Message ID | 20170912014031.31651-1-xypron.glpk@gmx.de |
|---|---|
| State | Accepted |
| Commit | 8a1c44271c55961fb70fb6177f9c02fdb05287c5 |
| Delegated to: | Bin Meng |
| Headers | show |
| Series | [U-Boot,1/1] x86: ivybridge: remove unused variables | expand |
On 11 September 2017 at 19:40, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > legacy_hole_base_k and legacy_hole_size_k are defined but > not used. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > arch/x86/cpu/ivybridge/northbridge.c | 10 ---------- > 1 file changed, 10 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On Tue, Sep 12, 2017 at 9:40 AM, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > legacy_hole_base_k and legacy_hole_size_k are defined but > not used. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > arch/x86/cpu/ivybridge/northbridge.c | 10 ---------- > 1 file changed, 10 deletions(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On Sat, Sep 16, 2017 at 10:24 AM, Bin Meng <bmeng.cn@gmail.com> wrote: > On Tue, Sep 12, 2017 at 9:40 AM, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: >> legacy_hole_base_k and legacy_hole_size_k are defined but >> not used. >> >> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> >> --- >> arch/x86/cpu/ivybridge/northbridge.c | 10 ---------- >> 1 file changed, 10 deletions(-) >> > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> applied to u-boot-x86, thanks!
diff --git a/arch/x86/cpu/ivybridge/northbridge.c b/arch/x86/cpu/ivybridge/northbridge.c index 94f31c40be..442942956b 100644 --- a/arch/x86/cpu/ivybridge/northbridge.c +++ b/arch/x86/cpu/ivybridge/northbridge.c @@ -34,16 +34,6 @@ int bridge_silicon_revision(struct udevice *dev) return bridge_id | stepping; } -/* - * Reserve everything between A segment and 1MB: - * - * 0xa0000 - 0xbffff: legacy VGA - * 0xc0000 - 0xcffff: VGA OPROM (needed by kernel) - * 0xe0000 - 0xfffff: SeaBIOS, if used, otherwise DMI - */ -static const int legacy_hole_base_k = 0xa0000 / 1024; -static const int legacy_hole_size_k = 384; - static int get_pcie_bar(struct udevice *dev, u32 *base, u32 *len) { u32 pciexbar_reg;
legacy_hole_base_k and legacy_hole_size_k are defined but not used. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- arch/x86/cpu/ivybridge/northbridge.c | 10 ---------- 1 file changed, 10 deletions(-)