| Message ID | 20170823205906.20933-4-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Accepted |
| Commit | 80c914f1bb86d1b14a3cd993afdd20287d7a314b |
| Delegated to: | Tom Rini |
| Headers | show |
On Wed, Aug 23, 2017 at 10:59:01PM +0200, Thomas Petazzoni wrote: > Most of the platforms are using CONFIG_SYS_CBSIZE + > sizeof(CONFIG_SYS_PROMPT) + 16 as their value for CONFIG_SYS_PBSIZE, > so let's adopt this for the fallback value of CONFIG_SYS_PBSIZE. > > This will allow us to drop an explicit definition of CONFIG_SYS_PBSIZE > from a large number of platforms. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Reviewed-by: Tom Rini <trini@konsulko.com>
On Wed, Aug 23, 2017 at 10:59:01PM +0200, Thomas Petazzoni wrote: > Most of the platforms are using CONFIG_SYS_CBSIZE + > sizeof(CONFIG_SYS_PROMPT) + 16 as their value for CONFIG_SYS_PBSIZE, > so let's adopt this for the fallback value of CONFIG_SYS_PBSIZE. > > This will allow us to drop an explicit definition of CONFIG_SYS_PBSIZE > from a large number of platforms. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Reviewed-by: Tom Rini <trini@konsulko.com> Applied to u-boot/master, thanks!
diff --git a/include/config_fallbacks.h b/include/config_fallbacks.h index f9461f0..09fcee4 100644 --- a/include/config_fallbacks.h +++ b/include/config_fallbacks.h @@ -81,7 +81,7 @@ #endif #ifndef CONFIG_SYS_PBSIZE -#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + 128) +#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16) #endif #ifndef CONFIG_FIT_SIGNATURE
Most of the platforms are using CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16 as their value for CONFIG_SYS_PBSIZE, so let's adopt this for the fallback value of CONFIG_SYS_PBSIZE. This will allow us to drop an explicit definition of CONFIG_SYS_PBSIZE from a large number of platforms. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- include/config_fallbacks.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)