From patchwork Sun Jul 30 18:59:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 795418 X-Patchwork-Delegate: jason.jin@freescale.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3xLBhw6d3Dz9s8J for ; Mon, 31 Jul 2017 04:59:43 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 65BA0C21E4E; Sun, 30 Jul 2017 18:59:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id E2CB4C21C6A; Sun, 30 Jul 2017 18:59:37 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 373C0C21C6A; Sun, 30 Jul 2017 18:59:36 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by lists.denx.de (Postfix) with ESMTPS id E54C1C21C58 for ; Sun, 30 Jul 2017 18:59:35 +0000 (UTC) Received: from LT002.fritz.box ([84.118.154.110]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MOOdZ-1dWgMr108j-005mKQ; Sun, 30 Jul 2017 20:59:32 +0200 From: Heinrich Schuchardt To: Huan Wang , Angelo Dureghello Date: Sun, 30 Jul 2017 20:59:27 +0200 Message-Id: <20170730185927.9770-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.11.0 X-Provags-ID: V03:K0:Df37QWvWLGFNb4Yr1QgyjVK00YnoTC7dyXkFu8WZAK67w7M1ik5 tn53vWS9ZiGuI4kcKL6M/4qru2bzzjyGvnmU46UvP8OJbhZC1KCbr3zhVnx2y+5PJLN+oAr +G34S6ygVlMD4sah66apuDVj0csJjRHcEXzcjkjkiIgTMosTSFqkcGKJTLKLt7F2ttPKjB+ WLi0KzPMGmE29uJcBpGuw== X-UI-Out-Filterresults: notjunk:1; V01:K0:w7JuN0GLL1c=:8JGqsfXXA1d4UEIYtCAEah qfGVRlKzaR+/wiOfw9p/AdVo1f34Yb4ulz3934DawB3zKot1uwpVYVKqUJ6GHO+BWlfqBouMt KT3HleDrrbMpC8KJ7HrHP9H47OLWeAXPF6BUI/syh2RNjbWrFV3ggBt7FHfUYcm+7dsyV9+LI LgVp3rWBDL7lMjOvuZ3bFm8fTs/q0ZmqKPEL8UxhpkbH4R72ioACaL7zF5dHVzDwvNfkYfxS9 mIucLsCgiFd1V93E14KIOzuQ/1IGt5Fl2KB8o2v9PuQhjoofso9J2XHt1LqwZE1CV3WdhzWpL c6GDf+DpYPOzXia1PQ+RK9d7huV6WH7YUsLVYrbTNP9M15uHjlDr8ppvzQ/l7eCHXhpSFLdNS vlsw9YysAsImxRLVB+244Abukmx0Kala220TuulSbcBII6Esq//fmOUwaYJPkmLH/JbnNiH23 9Gs/MS9WPulaY/eDIJEJva58BOSlZ5HgiMqDQ4KcZcZ0DmhHGrHg8+WJgrPtpkE8T6MlHYv6h OCwqtFljoVdpZPUwG/IX3ZbeQIsE3svKJXzPeKKEFjmd1nK92Fx99uzSpUP4jwxq8cg3GQIxR U+3o+qat0C+VxreHnb3yJqtQxY8NhL0nkyQZ+hfvGvlfjfEkfbh91RspgikLF3DqwA0/5AEXd zacSRlCZgos+vgXacRJtB1263Cmn6K9LxOmkTnSbYAT1G8SeRZ0nhKqlRKx2Vq7j8jQm9zBr5 Lw1aa/y91iC1c2RXvkMhp4juGzsA7FRRf2VTsgZGzRteWvYV4z9sZSaGp9VsC6xIxrO+/egWj aG3xwUvckpJ5YpMIAYs96E1UyP8Nw== Cc: u-boot@lists.denx.de, Heinrich Schuchardt Subject: [U-Boot] [RFC 1/1] m68k: mfc5227x: do not rely on uninitialized stack values X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The behavior get_clocks depends on the unitialized value of bootmode. By setting it to zero we get a defined behavior and can get rid of superfluos coding. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt --- I have no hardware to test this. Please, check thorougly before merging. --- --- arch/m68k/cpu/mcf5227x/speed.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/arch/m68k/cpu/mcf5227x/speed.c b/arch/m68k/cpu/mcf5227x/speed.c index 44de4a6701..978cc7adc6 100644 --- a/arch/m68k/cpu/mcf5227x/speed.c +++ b/arch/m68k/cpu/mcf5227x/speed.c @@ -73,14 +73,8 @@ int get_clocks(void) ccm_t *ccm = (ccm_t *)MMAP_CCM; pll_t *pll = (pll_t *)MMAP_PLL; - int vco, temp, pcrvalue, pfdr; - u8 bootmode; - - pcrvalue = in_be32(&pll->pcr) & 0xFF0F0FFF; - pfdr = pcrvalue >> 24; - - if (pfdr == 0x1E) - bootmode = 0; /* Normal Mode */ + int vco, temp, pcrvalue; + u8 bootmode = 0; /* Normal Mode */; #ifdef CONFIG_CF_SBF bootmode = 3; /* Serial Mode */