From patchwork Thu Jul 13 20:51:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 787986 X-Patchwork-Delegate: agraf@suse.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3x7p3105pmz9s7m for ; Fri, 14 Jul 2017 06:54:20 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id BE4DAC21EF4; Thu, 13 Jul 2017 20:52:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_LOW autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 50FCBC21E68; Thu, 13 Jul 2017 20:51:46 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id BC277C21E14; Thu, 13 Jul 2017 20:51:42 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by lists.denx.de (Postfix) with ESMTPS id EF14FC21E16 for ; Thu, 13 Jul 2017 20:51:41 +0000 (UTC) Received: from localhost.localdomain ([88.152.145.149]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MNIAz-1dc3XQ1pDl-006tHL; Thu, 13 Jul 2017 22:51:41 +0200 From: Heinrich Schuchardt To: Alexander Graf Date: Thu, 13 Jul 2017 22:51:34 +0200 Message-Id: <20170713205135.1538-5-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170713205135.1538-1-xypron.glpk@gmx.de> References: <20170713205135.1538-1-xypron.glpk@gmx.de> X-Provags-ID: V03:K0:HAyEpbo/aGvXUpto3zEbDGdS8JUKqDFk9yUlTU028yGdsAkS4Z5 AsBkZYhlD7V+SIYPQuTn0OOR0kyuM8G5hjr30jWPX1q5o88MyYPANi9FnJkoa/13BM41/EA wAk84BUwRIQcrOF/SuLTxsx9p+AbbZjPzlCRE3bR3hei6k1ettozzKR2nM0kBfS5asXgpBG DDOlQQK/Q0+e0G6umhcVQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:rXdafy4JTpk=:x0SK+robJKmStwQr37GEvo 72fBIZweyk2ksTrGuwiey65mzu8urhTa9X0iBOGdrgOkvdv8GtjqzzThltIAkvLPx/Snbgbpj oFg88Wh+a/kraQwk8c1S5RPLFWp9p+Q2J6d3dKBFRU4xk+1qXLuZ9v6urfKUSzRapUIbjtD4j Vm/904REdBLX2J+QGVdfAyS0gs4OSvKzr8wTZ4jAD3IFjM5pDaGr8+WwUFvTQCHWYnqHcmjIS R7qLBQEqC4V1+wdE799e3I88HsYq6lQ00pWm8DQW/RWkNhHiAlJWPKjViOkwnYUxaYFRqEIKi 9tpwP6GZdWKfSA8f7EUiTvyUm+oOfvOHQHnxPdG8PAyY+LwbFl64mlpMAJwcxK75b7C/AvMyh k4aSUOqIQZO/NA+S+SSw15w7FWdCgqGX3cvv7jySGv3DRGlyCBmK3Ef5AQhxlgo2x1+aJ2V7e pNfjalfmXpivWX5EBTyWHZuiRQjKHUCN/DqC6ZOTcu18ShEVucTYAm8PTxolYjNjkV95iRFCq RtJtlJU6/oJHOOBQ6hV+aZ3kait7KFtpq2kDOptGNyi060YhT8xTzzAvuG1ZyfWm6hedWqs2Z qTpZWrZ+mdBsTQq2+mBvw9BUo7yULRVujIflkexUb2Bbt8tHZlAr3L75OK36YQIDQJPtmxN7V tnY0Q03Tr897hOhTDxeDR4/Y0cWNXvXTSN/oKf7aPjXFK1B/nZA9x9onhyPeks/ZmXsJPTJ6L N7nkXCCTsZMfNcOJGkxG6NVMAyRyEefXD8A1rcNsnvGe0qJWlbLzevUtOPxROxW09pflTHxiA z9EJqsJVDtakO2R+NKjXDgbJDHTMQ== Cc: u-boot@lists.denx.de, Heinrich Schuchardt Subject: [U-Boot] [PATCH v2 4/5] efi_loader: debug info in efi_convert_device_path_to_text X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The debug information provided by efi_convert_device_path_to_text is insufficient. The type and the subtype are needed to find out why the function did not support a conversion. Signed-off-by: Heinrich Schuchardt --- v2 debug statement has to be after parameter check to avoid NULL dereference --- lib/efi_loader/efi_device_path_to_text.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/efi_loader/efi_device_path_to_text.c b/lib/efi_loader/efi_device_path_to_text.c index a5ea63300b..56de328286 100644 --- a/lib/efi_loader/efi_device_path_to_text.c +++ b/lib/efi_loader/efi_device_path_to_text.c @@ -41,6 +41,9 @@ uint16_t *efi_convert_device_path_to_text( return NULL; } + debug("EFI: type %d, subtype %d\n", + device_path->type, device_path->sub_type); + switch (device_path->type) { case DEVICE_PATH_TYPE_MESSAGING_DEVICE: switch (device_path->sub_type) {