diff mbox

[U-Boot,v2,21/28] rockchip: video: Take the vop device out of standby

Message ID 20170531235737.11676-22-sjg@chromium.org
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Simon Glass May 31, 2017, 11:57 p.m. UTC
On reset the standby bit is clear, but if U-Boot is chain-loaded from
another boot loader it may be set. Clear it before starting up video so
that it works correctly.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

Changes in v2: None

 drivers/video/rockchip/rk_vop.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Anatolij Gustschin June 2, 2017, 5:39 a.m. UTC | #1
On Wed, 31 May 2017 17:57:29 -0600
Simon Glass sjg@chromium.org wrote:

> On reset the standby bit is clear, but if U-Boot is chain-loaded from
> another boot loader it may be set. Clear it before starting up video so
> that it works correctly.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> 
> Changes in v2: None
> 
>  drivers/video/rockchip/rk_vop.c | 3 +++
>  1 file changed, 3 insertions(+)

Acked-by: Anatolij Gustschin <agust@denx.de>
Simon Glass June 9, 2017, 12:01 a.m. UTC | #2
On Wed, 31 May 2017 17:57:29 -0600
Simon Glass sjg@chromium.org wrote:

> On reset the standby bit is clear, but if U-Boot is chain-loaded from
> another boot loader it may be set. Clear it before starting up video so
> that it works correctly.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v2: None
>
>  drivers/video/rockchip/rk_vop.c | 3 +++
>  1 file changed, 3 insertions(+)

Acked-by: Anatolij Gustschin <agust@denx.de>

Applied to u-boot-dm, thanks!
diff mbox

Patch

diff --git a/drivers/video/rockchip/rk_vop.c b/drivers/video/rockchip/rk_vop.c
index b9b0b296ca..d970aae524 100644
--- a/drivers/video/rockchip/rk_vop.c
+++ b/drivers/video/rockchip/rk_vop.c
@@ -104,6 +104,9 @@  void rkvop_mode_set(struct rk3288_vop *regs,
 	uint flags;
 	int mode_flags;
 
+	/* remove from standby */
+	rk_clrreg(&regs->sys_ctrl, V_STANDBY_EN(1));
+
 	switch (mode) {
 	case VOP_MODE_HDMI:
 		clrsetbits_le32(&regs->sys_ctrl, M_ALL_OUT_EN,