From patchwork Wed May 31 23:57:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 769443 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3wdSR908Cpz9sD5 for ; Thu, 1 Jun 2017 10:10:28 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="JoDhovNt"; dkim-atps=neutral Received: by lists.denx.de (Postfix, from userid 105) id BA47EC21C97; Thu, 1 Jun 2017 00:09:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id C8E82C21CB0; Wed, 31 May 2017 23:59:00 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 5E4D2C21CE1; Wed, 31 May 2017 23:58:06 +0000 (UTC) Received: from mail-oi0-f54.google.com (mail-oi0-f54.google.com [209.85.218.54]) by lists.denx.de (Postfix) with ESMTPS id D4DD6C21C6D for ; Wed, 31 May 2017 23:58:01 +0000 (UTC) Received: by mail-oi0-f54.google.com with SMTP id h4so35452854oib.3 for ; Wed, 31 May 2017 16:58:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Th0jBtQW1Q+h+tX8NKgSGm3g1OfQ7D7Zssfm+dVit64=; b=JoDhovNtGgz+RJVId/pdGTCsBnghIe5mTXUL3KsTlb08PfCmUQDZKDTTolwdW68My4 sI6Al+FRMViujFAYGPkv2H/QS027KohENaDXICd9z+nAIQV+WXEgm3OpS/LsgfWIpIuJ tJjz79N7+wLKRqslIaEMFclkt20Y28bnEkGYtt//TJSyEGbreH26PcHRtfBFBDB7rH9X fzNFA4hPcNvM5t0u9Vd2RXPU1gRdoX+4DbhDYalvyTx8AMbH0wvG833XD69q80/NNIY7 YwUMwQ98h+3Dfvxx6Ou6Hz7jjCoSXk71FL/YLVtEZkYyv3RaH9RuWaVvnwKL7apsHmvT ABUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Th0jBtQW1Q+h+tX8NKgSGm3g1OfQ7D7Zssfm+dVit64=; b=AcyZegK6a+eVTNRyERAH8tKEgVvYDlL1ZfFmwlbc+NlzTcJWU0WTWK9IuBxrgbFTL1 HNlQezfxirVKBfVvpTT9/lUa3QjEhLoU7nnMOVGlgghC0cnBv9Oo+6y4ZAEWUuh/z56t hY8KgPfvdPDClrRWs70RHOG4rr3mFviu9MWk9eO0Quvmys9thhp++CzWOMZsLLiyAbYv 7ZbbuH2IW+GvZSzGXh/Mt6OGy7xltz+wmQDOCgSO2Xz0qq0gvK0fdo7KA7yPkrbIuh+t JZwbquxjgykycfaxHkuMc3Erct4aSh5FFaRCRPPQ71B+RO/Z61jShgURDDTuxSzZg/QX QftQ== X-Gm-Message-State: AODbwcA0x5RP5V3+UdHeUzXLuqmwS2KJSGozvIzKQl5w2kkbDNFG+VNi 1RxdPAgBXOBxbo5B X-Received: by 10.202.245.133 with SMTP id t127mr14141873oih.189.1496275080648; Wed, 31 May 2017 16:58:00 -0700 (PDT) Received: from kaki.bld.corp.google.com ([100.100.197.131]) by smtp.gmail.com with ESMTPSA id w79sm8079307oiw.13.2017.05.31.16.57.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 May 2017 16:57:58 -0700 (PDT) Received: by kaki.bld.corp.google.com (Postfix, from userid 121222) id 1EF0040140; Wed, 31 May 2017 17:57:57 -0600 (MDT) From: Simon Glass To: U-Boot Mailing List Date: Wed, 31 May 2017 17:57:22 -0600 Message-Id: <20170531235737.11676-15-sjg@chromium.org> X-Mailer: git-send-email 2.13.0.219.gdb65acc882-goog In-Reply-To: <20170531235737.11676-1-sjg@chromium.org> References: <20170531235737.11676-1-sjg@chromium.org> Cc: Stephen Warren , Tom Warren , Riley Baird Subject: [U-Boot] [PATCH v2 14/28] tegra: clock: Avoid a divide-by-zero error X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The clock fix-up for tegra is still present in the code. It causes a divide-by-zero bug after relocation when chain-loading U-Boot from coreboot. Fix this by adding a check. Signed-off-by: Simon Glass Fixes: 7468676 (ARM: tegra: fix clock_get_periph_rate() for UART clocks) Signed-off-by: Simon Glass --- Changes in v2: None arch/arm/mach-tegra/clock.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-tegra/clock.c b/arch/arm/mach-tegra/clock.c index ce68c7d0cc..dc58b3027d 100644 --- a/arch/arm/mach-tegra/clock.c +++ b/arch/arm/mach-tegra/clock.c @@ -339,8 +339,11 @@ unsigned long clock_get_periph_rate(enum periph_id periph_id, * return value doesn't help. In summary this clock driver is * quite broken but I'm afraid I have no idea how to fix it * without completely replacing it. + * + * Be careful to avoid a divide by zero error. */ - div -= 2; + if (div >= 1) + div -= 2; break; #endif default: