diff mbox

[U-Boot] odroid: remove COMPAT_DM_I2C_COMPAT config

Message ID 20170530010647.4952-1-jh80.chung@samsung.com
State Changes Requested
Delegated to: Minkyu Kang
Headers show

Commit Message

Jaehoon Chung May 30, 2017, 1:06 a.m. UTC
Remove the COMPAT_DM_I2C_COMPAT config.

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
This patch is based on "Enable the CONFIG_DM_MMC for Exynos4 series"

 configs/odroid_defconfig | 2 +-
 include/configs/odroid.h | 5 -----
 2 files changed, 1 insertion(+), 6 deletions(-)

Comments

Simon Glass June 1, 2017, 3:12 a.m. UTC | #1
On 29 May 2017 at 19:06, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Remove the COMPAT_DM_I2C_COMPAT config.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> This patch is based on "Enable the CONFIG_DM_MMC for Exynos4 series"
>
>  configs/odroid_defconfig | 2 +-
>  include/configs/odroid.h | 5 -----
>  2 files changed, 1 insertion(+), 6 deletions(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>
Minkyu Kang June 5, 2017, 4:01 a.m. UTC | #2
Hi

2017. 6. 1. 12:35에 "Simon Glass" <sjg@chromium.org>님이 작성:

On 29 May 2017 at 19:06, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Remove the COMPAT_DM_I2C_COMPAT config.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> This patch is based on "Enable the CONFIG_DM_MMC for Exynos4 series"
>
>  configs/odroid_defconfig | 2 +-
>  include/configs/odroid.h | 5 -----
>  2 files changed, 1 insertion(+), 6 deletions(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>
Jaehoon Chung June 5, 2017, 4:07 a.m. UTC | #3
Hi Minkyu,

On 06/05/2017 01:01 PM, Minkyu Kang wrote:
> Hi

Sure, I will rebase on your latest. And i will modify the subject about typo.

s/COMPAT/CONFIG/

Will send the patch.

Best Regards,
Jaehoon Chung

> 
> 2017. 6. 1. 12:35에 "Simon Glass" <sjg@chromium.org>님이 작성:
> 
> On 29 May 2017 at 19:06, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>> Remove the COMPAT_DM_I2C_COMPAT config.
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> ---
>> This patch is based on "Enable the CONFIG_DM_MMC for Exynos4 series"
>>
>>  configs/odroid_defconfig | 2 +-
>>  include/configs/odroid.h | 5 -----
>>  2 files changed, 1 insertion(+), 6 deletions(-)
>>
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
> 
> 
> Could you please rebase?
> 
> Thanks
>
diff mbox

Patch

diff --git a/configs/odroid_defconfig b/configs/odroid_defconfig
index a28058a..1d13119 100644
--- a/configs/odroid_defconfig
+++ b/configs/odroid_defconfig
@@ -38,7 +38,7 @@  CONFIG_CMD_FS_GENERIC=y
 CONFIG_ISO_PARTITION=y
 CONFIG_OF_CONTROL=y
 CONFIG_DFU_MMC=y
-CONFIG_DM_I2C_COMPAT=y
+CONFIG_SYS_I2C_S3C24X0=y
 CONFIG_MMC_DW=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_SDMA=y
diff --git a/include/configs/odroid.h b/include/configs/odroid.h
index 6cc7dd1..64f8f8d 100644
--- a/include/configs/odroid.h
+++ b/include/configs/odroid.h
@@ -175,11 +175,6 @@ 
 	"scriptaddr=0x42000000\0" \
 	"fdtaddr=40800000\0"
 
-/* I2C */
-#define CONFIG_SYS_I2C_S3C24X0
-#define CONFIG_SYS_I2C_S3C24X0_SPEED	100000
-#define CONFIG_SYS_I2C_S3C24X0_SLAVE	0
-
 /* GPT */
 #define CONFIG_RANDOM_UUID