From patchwork Wed May 24 00:15:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 766271 X-Patchwork-Delegate: philipp.tomsich@theobroma-systems.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3wXXwr4m8Lz9rxw for ; Wed, 24 May 2017 10:15:39 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="vT01McFN"; dkim-atps=neutral Received: by lists.denx.de (Postfix, from userid 105) id 5959FC21C6F; Wed, 24 May 2017 00:15:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 711C6C21C2A; Wed, 24 May 2017 00:15:21 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 1CCD3C21C2A; Wed, 24 May 2017 00:15:19 +0000 (UTC) Received: from mail-oi0-f45.google.com (mail-oi0-f45.google.com [209.85.218.45]) by lists.denx.de (Postfix) with ESMTPS id 5F110C21C27 for ; Wed, 24 May 2017 00:15:19 +0000 (UTC) Received: by mail-oi0-f45.google.com with SMTP id b204so222654062oii.1 for ; Tue, 23 May 2017 17:15:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=pUg08KIz1wMjf8GdJpI7ypxIh4SG/asbEBACi6cfJiQ=; b=vT01McFNRKM2lnPyDXOdP2/FEFBhhGWC6jCxRQHWDbw9uHW3aQckMlp3QZZL4iMpLr wnd2DkbEgDlOOfGJCUYAp7LBQtSLHryeVctCwrqJZtLcX1OAX7iuOBkuS/Ak259/+PUA yfjhh3bKw5WHF+zvbrHyBIdsv/SFCBS3i1eIOPrB2IiOQoiChAcXQmsu+jg4CJAKjUSy s8sE4w8JK4F7jvmSEeuko7NfjpLJ4zd81PiWr+YxOFLRlCH5qhpd2UTG9R0hpJriCrAL rchBfZiWDZt6Br6ehOEE+f6ZjDF0pCDWDKXuC8YMyXS2gHgExn3ysEQx7GQNBaFH/NDo 0R1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=pUg08KIz1wMjf8GdJpI7ypxIh4SG/asbEBACi6cfJiQ=; b=IzlDjogyy7aqh9DJ6A0ZjnbDpcObWRNl9acfXVHy84oaEIseILANdwNBi3bRrz/WGo iiZJAP3JMxoD8qsBh42oJJnMyT5jZDZPetDehKMNGemKUiXEc/YNdOYEdSJVNTLvnytt YjagDvO9cbZnFTdC1+Z1gOzqGy1qIKU1kENvU1zNd9qCMftzdcznF4DGC5Ptr2Hg/qM3 nC1xAFCwMHWvP58nmRaaS5k0bo5Do3k8Vd7P/v3j9fBvumK5AAaxz5b09ISakOGOcyfP XZblEXMBh0U/l007pfKChpjV3qnfFG28p8jE1flqs8v0LYVWLD7JGzYhVUYHOuguk2gj vxYA== X-Gm-Message-State: AODbwcDiVdiAHpwRYG+bWiK3qzWu+KiLPTJ+PaUb9GrjXiJho3vDGwOc MFIvw92tmQD4MmoT X-Received: by 10.157.14.14 with SMTP id c14mr3824805otc.90.1495584917824; Tue, 23 May 2017 17:15:17 -0700 (PDT) Received: from kaki.bld.corp.google.com ([100.100.184.96]) by smtp.gmail.com with ESMTPSA id b206sm1067498oia.14.2017.05.23.17.15.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 May 2017 17:15:17 -0700 (PDT) Received: by kaki.bld.corp.google.com (Postfix, from userid 121222) id B962A40350; Tue, 23 May 2017 18:15:15 -0600 (MDT) From: Simon Glass To: U-Boot Mailing List Date: Tue, 23 May 2017 18:15:14 -0600 Message-Id: <20170524001514.3480-1-sjg@chromium.org> X-Mailer: git-send-email 2.13.0.219.gdb65acc882-goog Cc: Jeffy Chen , Lin huang Subject: [U-Boot] [PATCH] rockchip: Set up default PWM flags X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" At present if the PWM set_invert() method is not called then the flags are not set up and the driver does not work properly. Fix this by setting up the default flags when probing. Signed-off-by: Simon Glass Fixes: 874ee59 (rockchip: pwm: implement pwm_set_invert()) Acked-by: Philipp Tomsich Reviewed-by: Philipp Tomsich --- drivers/pwm/rk_pwm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pwm/rk_pwm.c b/drivers/pwm/rk_pwm.c index f3b2f7615d..5d78d4a67d 100644 --- a/drivers/pwm/rk_pwm.c +++ b/drivers/pwm/rk_pwm.c @@ -92,6 +92,7 @@ static int rk_pwm_probe(struct udevice *dev) return -EINVAL; } priv->freq = clk_get_rate(&clk); + priv->enable_conf = PWM_DUTY_POSTIVE | PWM_INACTIVE_POSTIVE; return 0; }