| Message ID | 20170410173459.30461-9-sjg@chromium.org |
|---|---|
| State | Accepted |
| Delegated to: | Simon Glass |
| Headers | show |
2017-04-11 1:34 GMT+08:00 Simon Glass <sjg@chromium.org>: > The existing 'led' command does not support driver model. Rename it to > indicate that it is legacy code. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > Changes in v2: None > > cmd/Makefile | 2 +- > cmd/legacy_led.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/cmd/Makefile b/cmd/Makefile > index ef1406b3f8..19d450e0fb 100644 > --- a/cmd/Makefile > +++ b/cmd/Makefile > @@ -78,7 +78,7 @@ obj-$(CONFIG_CMD_ITEST) += itest.o > obj-$(CONFIG_CMD_JFFS2) += jffs2.o > obj-$(CONFIG_CMD_CRAMFS) += cramfs.o > obj-$(CONFIG_CMD_LDRINFO) += ldrinfo.o > -obj-$(CONFIG_LED_STATUS_CMD) += led.o > +obj-$(CONFIG_LED_STATUS_CMD) += legacy_led.o > obj-$(CONFIG_CMD_LICENSE) += license.o > obj-y += load.o > obj-$(CONFIG_LOGBUFFER) += log.o > diff --git a/cmd/legacy_led.c b/cmd/legacy_led.c > index 951a5e242f..1ec2e43e50 100644 > --- a/cmd/legacy_led.c > +++ b/cmd/legacy_led.c > @@ -86,7 +86,7 @@ void __weak __led_blink(led_id_t mask, int freq) > { > } > > -int do_led (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) > +int do_legacy_led(cmd_tbl_t *cmdtp, int flag, int argc, char * const > argv[]) > { > int i, match = 0; > enum led_cmd cmd; > @@ -148,7 +148,7 @@ int do_led (cmd_tbl_t *cmdtp, int flag, int argc, char > * const argv[]) > } > > U_BOOT_CMD( > - led, 4, 1, do_led, > + led, 4, 1, do_legacy_led, > "[" > #ifdef CONFIG_LED_STATUS_BOARD_SPECIFIC > #ifdef CONFIG_LED_STATUS0 > -- > 2.12.2.715.g7642488e1d-goog > > Reviewed-by: Ziping Chen <techping.chan@gmail.com>
On 12 April 2017 at 02:53, Ziping Chen <techping.chan@gmail.com> wrote: > > > 2017-04-11 1:34 GMT+08:00 Simon Glass <sjg@chromium.org>: >> >> The existing 'led' command does not support driver model. Rename it to >> indicate that it is legacy code. >> >> Signed-off-by: Simon Glass <sjg@chromium.org> >> --- >> >> Changes in v2: None >> >> cmd/Makefile | 2 +- >> cmd/legacy_led.c | 4 ++-- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> > > Reviewed-by: Ziping Chen <techping.chan@gmail.com> Applied to u-boot-dm
diff --git a/cmd/Makefile b/cmd/Makefile index ef1406b3f8..19d450e0fb 100644 --- a/cmd/Makefile +++ b/cmd/Makefile @@ -78,7 +78,7 @@ obj-$(CONFIG_CMD_ITEST) += itest.o obj-$(CONFIG_CMD_JFFS2) += jffs2.o obj-$(CONFIG_CMD_CRAMFS) += cramfs.o obj-$(CONFIG_CMD_LDRINFO) += ldrinfo.o -obj-$(CONFIG_LED_STATUS_CMD) += led.o +obj-$(CONFIG_LED_STATUS_CMD) += legacy_led.o obj-$(CONFIG_CMD_LICENSE) += license.o obj-y += load.o obj-$(CONFIG_LOGBUFFER) += log.o diff --git a/cmd/legacy_led.c b/cmd/legacy_led.c index 951a5e242f..1ec2e43e50 100644 --- a/cmd/legacy_led.c +++ b/cmd/legacy_led.c @@ -86,7 +86,7 @@ void __weak __led_blink(led_id_t mask, int freq) { } -int do_led (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) +int do_legacy_led(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) { int i, match = 0; enum led_cmd cmd; @@ -148,7 +148,7 @@ int do_led (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) } U_BOOT_CMD( - led, 4, 1, do_led, + led, 4, 1, do_legacy_led, "[" #ifdef CONFIG_LED_STATUS_BOARD_SPECIFIC #ifdef CONFIG_LED_STATUS0
The existing 'led' command does not support driver model. Rename it to indicate that it is legacy code. Signed-off-by: Simon Glass <sjg@chromium.org> --- Changes in v2: None cmd/Makefile | 2 +- cmd/legacy_led.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)