diff mbox

[U-Boot,v6,8/9] rockchip: Add PXE and DHCP to the default boot targets

Message ID 20170105081624.11398-9-romain.perier@collabora.com
State Superseded
Delegated to: Simon Glass
Headers show

Commit Message

Romain Perier Jan. 5, 2017, 8:16 a.m. UTC
From: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

Now that at least on the firefly board we have network support, enable
PXE and DHCP boot targets by default.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Acked-by: Simon Glass <sjg@chromium.org>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
---

Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None

 include/configs/rockchip-common.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Simon Glass Jan. 11, 2017, 3:04 a.m. UTC | #1
Hi Romain,

On 5 January 2017 at 01:16, Romain Perier <romain.perier@collabora.com> wrote:
>
> From: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
>
> Now that at least on the firefly board we have network support, enable
> PXE and DHCP boot targets by default.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> Acked-by: Simon Glass <sjg@chromium.org>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> ---
>
> Changes in v6: None
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
>  include/configs/rockchip-common.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h
> index 9ec71c4baa..be53e659ee 100644
> --- a/include/configs/rockchip-common.h
> +++ b/include/configs/rockchip-common.h
> @@ -14,7 +14,9 @@
>  /* First try to boot from SD (index 0), then eMMC (index 1 */
>  #define BOOT_TARGET_DEVICES(func) \
>         func(MMC, mmc, 0) \
> -       func(MMC, mmc, 1)
> +       func(MMC, mmc, 1) \
> +       func(PXE, pxe, na) \
> +       func(DHCP, dchp, na)
>
>   /* Enable gpt partition table */
>  #define CONFIG_CMD_GPT
> --
> 2.11.0
>

Thanks for doing this. Unfortunately this patch fails to build for
most rockchip boards - do you have time to take a look?

Regards,
Simon
diff mbox

Patch

diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h
index 9ec71c4baa..be53e659ee 100644
--- a/include/configs/rockchip-common.h
+++ b/include/configs/rockchip-common.h
@@ -14,7 +14,9 @@ 
 /* First try to boot from SD (index 0), then eMMC (index 1 */
 #define BOOT_TARGET_DEVICES(func) \
 	func(MMC, mmc, 0) \
-	func(MMC, mmc, 1)
+	func(MMC, mmc, 1) \
+	func(PXE, pxe, na) \
+	func(DHCP, dchp, na)
 
  /* Enable gpt partition table */
 #define CONFIG_CMD_GPT