diff mbox

[U-Boot,2/7] misc: Tegra BPMP: support child node devices

Message ID 20160729191506.24803-2-swarren@wwwdotorg.org
State Superseded
Delegated to: Tom Warren
Headers show

Commit Message

Stephen Warren July 29, 2016, 7:15 p.m. UTC 
From: Stephen Warren <swarren@nvidia.com>

The BPMP bindings allow devices to be represented as child nodes of the
BPMP node. This requires the driver to trigger scanning of its node for
those child nodes.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 drivers/misc/tegra186_bpmp.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Simon Glass Aug. 1, 2016, 1:03 a.m. UTC | #1 
Hi Stephen,

On 29 July 2016 at 13:15, Stephen Warren <swarren@wwwdotorg.org> wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> The BPMP bindings allow devices to be represented as child nodes of the
> BPMP node. This requires the driver to trigger scanning of its node for
> those child nodes.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
>  drivers/misc/tegra186_bpmp.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/misc/tegra186_bpmp.c b/drivers/misc/tegra186_bpmp.c
> index 147528da9269..526d812ecd39 100644
> --- a/drivers/misc/tegra186_bpmp.c
> +++ b/drivers/misc/tegra186_bpmp.c
> @@ -129,6 +129,10 @@ static int tegra186_bpmp_bind(struct udevice *dev)
>         if (ret)
>                 return ret;
>
> +       ret = dm_scan_fdt_node(dev, gd->fdt_blob, dev->of_offset, false);
> +       if (ret)
> +               return ret;
> +

Can you use dm_scan_fdt_dev() here? Hot off the press.

>         return 0;
>  }
>
> --
> 2.9.2
>

Regards,
Simon
diff mbox

Patch

diff --git a/drivers/misc/tegra186_bpmp.c b/drivers/misc/tegra186_bpmp.c
index 147528da9269..526d812ecd39 100644
--- a/drivers/misc/tegra186_bpmp.c
+++ b/drivers/misc/tegra186_bpmp.c
@@ -129,6 +129,10 @@  static int tegra186_bpmp_bind(struct udevice *dev)
 	if (ret)
 		return ret;
 
+	ret = dm_scan_fdt_node(dev, gd->fdt_blob, dev->of_offset, false);
+	if (ret)
+		return ret;
+
 	return 0;
 }