diff mbox

[U-Boot,1/2] ARM: am57xx_evm: Enable QSPI support

Message ID 20160729063347.17626-2-vigneshr@ti.com
State Superseded
Headers show

Commit Message

Raghavendra, Vignesh July 29, 2016, 6:33 a.m. UTC
AM571x IDK and AM572x IDK EVMs have spansion s25fl256s QSPI flash on the
board connected to TI QSPI IP over CS0. Therefore enable QSPI support.

Signed-off-by: Vignesh R <vigneshr@ti.com>
---
 configs/am57xx_evm_defconfig |  5 +++++
 include/configs/am57xx_evm.h | 36 ++++++++++++++++++++++++++++++++++++
 2 files changed, 41 insertions(+)

Comments

Mugunthan V N July 29, 2016, 8:54 a.m. UTC | #1
On Friday 29 July 2016 12:03 PM, Vignesh R wrote:
> AM571x IDK and AM572x IDK EVMs have spansion s25fl256s QSPI flash on the
> board connected to TI QSPI IP over CS0. Therefore enable QSPI support.
> 
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
>  configs/am57xx_evm_defconfig |  5 +++++
>  include/configs/am57xx_evm.h | 36 ++++++++++++++++++++++++++++++++++++
>  2 files changed, 41 insertions(+)
> 
> diff --git a/configs/am57xx_evm_defconfig b/configs/am57xx_evm_defconfig
> index 8a8a4c9090b0..c95f45aca8b5 100644
> --- a/configs/am57xx_evm_defconfig
> +++ b/configs/am57xx_evm_defconfig
> @@ -41,3 +41,8 @@ CONFIG_SPL_OF_LIBFDT=y
>  CONFIG_SPL_LOAD_FIT=y
>  CONFIG_OF_LIST="am57xx-beagle-x15 am572x-idk"
>  CONFIG_DM_I2C=y
> +CONFIG_DM_SPI=y
> +CONFIG_DM_SPI_FLASH=y
> +CONFIG_SPI_FLASH_SPANSION=y
> +CONFIG_TI_QSPI=y
> +CONFIG_CMD_SF=y

CONFIG_SPI_FLASH_BAR ???

Regards
Mugunthan V N

> diff --git a/include/configs/am57xx_evm.h b/include/configs/am57xx_evm.h
> index 2db199db33b7..083886ba262f 100644
> --- a/include/configs/am57xx_evm.h
> +++ b/include/configs/am57xx_evm.h
> @@ -86,4 +86,40 @@
>  #define CONFIG_EEPROM_CHIP_ADDRESS 0x50
>  #define CONFIG_EEPROM_BUS_ADDRESS 0
>  
> +/*
> + * Default to using SPI for environment, etc.
> + * 0x000000 - 0x040000 : QSPI.SPL (256KiB)
> + * 0x040000 - 0x140000 : QSPI.u-boot (1MiB)
> + * 0x140000 - 0x1C0000 : QSPI.u-boot-spl-os (512KiB)
> + * 0x1C0000 - 0x1D0000 : QSPI.u-boot-env (64KiB)
> + * 0x1D0000 - 0x1E0000 : QSPI.u-boot-env.backup1 (64KiB)
> + * 0x1E0000 - 0x9E0000 : QSPI.kernel (8MiB)
> + * 0x9E0000 - 0x2000000 : USERLAND
> + */
> +#define CONFIG_SYS_SPI_KERNEL_OFFS      0x1E0000
> +#define CONFIG_SYS_SPI_ARGS_OFFS        0x140000
> +#define CONFIG_SYS_SPI_ARGS_SIZE        0x80000
> +
> +#ifdef CONFIG_SPL_BUILD
> +#undef CONFIG_DM_SPI
> +#undef CONFIG_DM_SPI_FLASH
> +#undef CONFIG_SPL_MAX_SIZE
> +#define CONFIG_SPL_MAX_SIZE             (256 << 10) /* 256 KiB */
> +#endif
> +
> +/* SPI SPL */
> +#define CONFIG_SPL_SPI_SUPPORT
> +#define CONFIG_SPL_DMA_SUPPORT
> +#define CONFIG_TI_EDMA3
> +#define CONFIG_SPL_SPI_LOAD
> +#define CONFIG_SPL_SPI_FLASH_SUPPORT
> +#define CONFIG_SYS_SPI_U_BOOT_OFFS     0x40000
> +
> +/* SPI */
> +#undef	CONFIG_OMAP3_SPI
> +#define CONFIG_TI_SPI_MMAP
> +#define CONFIG_SF_DEFAULT_SPEED                76800000
> +#define CONFIG_SF_DEFAULT_MODE                 SPI_MODE_0
> +#define CONFIG_QSPI_QUAD_SUPPORT
> +
>  #endif /* __CONFIG_AM57XX_EVM_H */
>
Raghavendra, Vignesh July 29, 2016, 8:57 a.m. UTC | #2
On Friday 29 July 2016 02:24 PM, Mugunthan V N wrote:
> On Friday 29 July 2016 12:03 PM, Vignesh R wrote:
>> AM571x IDK and AM572x IDK EVMs have spansion s25fl256s QSPI flash on the
>> board connected to TI QSPI IP over CS0. Therefore enable QSPI support.
>>
>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>> ---
>>  configs/am57xx_evm_defconfig |  5 +++++
>>  include/configs/am57xx_evm.h | 36 ++++++++++++++++++++++++++++++++++++
>>  2 files changed, 41 insertions(+)
>>
>> diff --git a/configs/am57xx_evm_defconfig b/configs/am57xx_evm_defconfig
>> index 8a8a4c9090b0..c95f45aca8b5 100644
>> --- a/configs/am57xx_evm_defconfig
>> +++ b/configs/am57xx_evm_defconfig
>> @@ -41,3 +41,8 @@ CONFIG_SPL_OF_LIBFDT=y
>>  CONFIG_SPL_LOAD_FIT=y
>>  CONFIG_OF_LIST="am57xx-beagle-x15 am572x-idk"
>>  CONFIG_DM_I2C=y
>> +CONFIG_DM_SPI=y
>> +CONFIG_DM_SPI_FLASH=y
>> +CONFIG_SPI_FLASH_SPANSION=y
>> +CONFIG_TI_QSPI=y
>> +CONFIG_CMD_SF=y
> 
> CONFIG_SPI_FLASH_BAR ???

That config option is already enabled in am57xx_evm_defconfig.
Mugunthan V N July 29, 2016, 9:17 a.m. UTC | #3
On Friday 29 July 2016 02:27 PM, Vignesh R wrote:
> 
> 
> On Friday 29 July 2016 02:24 PM, Mugunthan V N wrote:
>> On Friday 29 July 2016 12:03 PM, Vignesh R wrote:
>>> AM571x IDK and AM572x IDK EVMs have spansion s25fl256s QSPI flash on the
>>> board connected to TI QSPI IP over CS0. Therefore enable QSPI support.
>>>
>>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>>> ---
>>>  configs/am57xx_evm_defconfig |  5 +++++
>>>  include/configs/am57xx_evm.h | 36 ++++++++++++++++++++++++++++++++++++
>>>  2 files changed, 41 insertions(+)
>>>
>>> diff --git a/configs/am57xx_evm_defconfig b/configs/am57xx_evm_defconfig
>>> index 8a8a4c9090b0..c95f45aca8b5 100644
>>> --- a/configs/am57xx_evm_defconfig
>>> +++ b/configs/am57xx_evm_defconfig
>>> @@ -41,3 +41,8 @@ CONFIG_SPL_OF_LIBFDT=y
>>>  CONFIG_SPL_LOAD_FIT=y
>>>  CONFIG_OF_LIST="am57xx-beagle-x15 am572x-idk"
>>>  CONFIG_DM_I2C=y
>>> +CONFIG_DM_SPI=y
>>> +CONFIG_DM_SPI_FLASH=y
>>> +CONFIG_SPI_FLASH_SPANSION=y
>>> +CONFIG_TI_QSPI=y
>>> +CONFIG_CMD_SF=y
>>
>> CONFIG_SPI_FLASH_BAR ???
> 
> That config option is already enabled in am57xx_evm_defconfig.
> 

Okay, I could see all spi related configs here, so I thought you missed
adding CONFIG_SPI_FLASH_BAR.

Reviewed-by: Mugunthan V N <mugunthanvnm@ti.com>

Regards
Mugunthan V N
diff mbox

Patch

diff --git a/configs/am57xx_evm_defconfig b/configs/am57xx_evm_defconfig
index 8a8a4c9090b0..c95f45aca8b5 100644
--- a/configs/am57xx_evm_defconfig
+++ b/configs/am57xx_evm_defconfig
@@ -41,3 +41,8 @@  CONFIG_SPL_OF_LIBFDT=y
 CONFIG_SPL_LOAD_FIT=y
 CONFIG_OF_LIST="am57xx-beagle-x15 am572x-idk"
 CONFIG_DM_I2C=y
+CONFIG_DM_SPI=y
+CONFIG_DM_SPI_FLASH=y
+CONFIG_SPI_FLASH_SPANSION=y
+CONFIG_TI_QSPI=y
+CONFIG_CMD_SF=y
diff --git a/include/configs/am57xx_evm.h b/include/configs/am57xx_evm.h
index 2db199db33b7..083886ba262f 100644
--- a/include/configs/am57xx_evm.h
+++ b/include/configs/am57xx_evm.h
@@ -86,4 +86,40 @@ 
 #define CONFIG_EEPROM_CHIP_ADDRESS 0x50
 #define CONFIG_EEPROM_BUS_ADDRESS 0
 
+/*
+ * Default to using SPI for environment, etc.
+ * 0x000000 - 0x040000 : QSPI.SPL (256KiB)
+ * 0x040000 - 0x140000 : QSPI.u-boot (1MiB)
+ * 0x140000 - 0x1C0000 : QSPI.u-boot-spl-os (512KiB)
+ * 0x1C0000 - 0x1D0000 : QSPI.u-boot-env (64KiB)
+ * 0x1D0000 - 0x1E0000 : QSPI.u-boot-env.backup1 (64KiB)
+ * 0x1E0000 - 0x9E0000 : QSPI.kernel (8MiB)
+ * 0x9E0000 - 0x2000000 : USERLAND
+ */
+#define CONFIG_SYS_SPI_KERNEL_OFFS      0x1E0000
+#define CONFIG_SYS_SPI_ARGS_OFFS        0x140000
+#define CONFIG_SYS_SPI_ARGS_SIZE        0x80000
+
+#ifdef CONFIG_SPL_BUILD
+#undef CONFIG_DM_SPI
+#undef CONFIG_DM_SPI_FLASH
+#undef CONFIG_SPL_MAX_SIZE
+#define CONFIG_SPL_MAX_SIZE             (256 << 10) /* 256 KiB */
+#endif
+
+/* SPI SPL */
+#define CONFIG_SPL_SPI_SUPPORT
+#define CONFIG_SPL_DMA_SUPPORT
+#define CONFIG_TI_EDMA3
+#define CONFIG_SPL_SPI_LOAD
+#define CONFIG_SPL_SPI_FLASH_SUPPORT
+#define CONFIG_SYS_SPI_U_BOOT_OFFS     0x40000
+
+/* SPI */
+#undef	CONFIG_OMAP3_SPI
+#define CONFIG_TI_SPI_MMAP
+#define CONFIG_SF_DEFAULT_SPEED                76800000
+#define CONFIG_SF_DEFAULT_MODE                 SPI_MODE_0
+#define CONFIG_QSPI_QUAD_SUPPORT
+
 #endif /* __CONFIG_AM57XX_EVM_H */