From patchwork Mon Jun 20 18:26:10 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Tietz X-Patchwork-Id: 638191 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 3rYK7b2G2Cz9t10 for ; Tue, 21 Jun 2016 04:26:35 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 42593A767A; Mon, 20 Jun 2016 20:26:27 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fNf0L51uhCDs; Mon, 20 Jun 2016 20:26:27 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 7F79CA7685; Mon, 20 Jun 2016 20:26:24 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 7F8A6A7674 for ; Mon, 20 Jun 2016 20:26:19 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jbYI4rm7WgGK for ; Mon, 20 Jun 2016 20:26:19 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail.moses.super-online.de (moses.super-online.de [5.9.156.4]) by theia.denx.de (Postfix) with ESMTPS id 32F6DA763D for ; Mon, 20 Jun 2016 20:26:15 +0200 (CEST) Received: by mail.moses.super-online.de (Postfix, from userid 303) id DD8C62840838; Mon, 20 Jun 2016 20:26:14 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on moses.super-online.de X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, RP_MATCHES_RCVD,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from mail.moses.super-online.de (localhost [127.0.0.1]) by mail.moses.super-online.de (Postfix) with ESMTP id CBE3A28405E5 for ; Mon, 20 Jun 2016 20:26:11 +0200 (CEST) Received: from lightning.dresden.micronet24.de (dresden.micronet24.de [89.247.133.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: web53p1) by mail.moses.super-online.de (Postfix) with ESMTPSA id 8EA9B28402C8 for ; Mon, 20 Jun 2016 20:26:11 +0200 (CEST) Received: from obelix.dresden.micronet24.de ([192.168.0.14]) by lightning.dresden.micronet24.de with esmtp (Exim 4.84_2) (envelope-from ) id 1bF3ti-0003nQ-OS for u-boot@lists.denx.de; Mon, 20 Jun 2016 20:26:10 +0200 Received: from localhost ([::1] helo=obelix.dresden.micronet24.de) by obelix.dresden.micronet24.de with esmtp (Exim 4.84_2) (envelope-from ) id 1bF3ti-0005XW-LF for u-boot@lists.denx.de; Mon, 20 Jun 2016 20:26:10 +0200 From: Benjamin Tietz To: u-boot@lists.denx.de Date: Mon, 20 Jun 2016 20:26:10 +0200 Message-ID: <20160620182610.21075.53697.stgit@obelix.dresden.micronet24.de> In-Reply-To: <20160620182505.21075.54136.stgit@obelix.dresden.micronet24.de> References: <20160620182505.21075.54136.stgit@obelix.dresden.micronet24.de> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-SA-Exim-Connect-IP: 192.168.0.14 X-SA-Exim-Mail-From: uboot@dresden.micronet24.de X-SA-Exim-Scanned: No (on lightning.dresden.micronet24.de); SAEximRunCond expanded to false X-Virus-Scanned: ClamAV SMTP VirusScan Subject: [U-Boot] [PATCH v2 02/22] stm32: gpio_direction_output: make sure, output is set to push-pull X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Previously the bit for settting the pin-behaviour was left undefined, which may result in an open-drain behaviour for the affected pin. Now it is correctly initialized, always. --- drivers/gpio/stm32_gpio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/stm32_gpio.c b/drivers/gpio/stm32_gpio.c index 2457211..d092c8f 100644 --- a/drivers/gpio/stm32_gpio.c +++ b/drivers/gpio/stm32_gpio.c @@ -236,6 +236,7 @@ int gpio_direction_output(unsigned gpio, int value) #if defined(CONFIG_STM32F4) || defined(CONFIG_STM32F7) ctl.af = STM32_GPIO_AF0; ctl.mode = STM32_GPIO_MODE_OUT; + ctl.otype = STM32_GPIO_OTYPE_PP; ctl.pupd = STM32_GPIO_PUPD_NO; ctl.speed = STM32_GPIO_SPEED_50M; #elif defined(CONFIG_STM32F1)