| Message ID | 201601250352.02648.marex@denx.de |
|---|---|
| State | Rejected |
| Headers | show |
Hi Marek, On Mon, Jan 25, 2016 at 10:52 AM, Marek Vasut <marex@denx.de> wrote: > On Monday, January 25, 2016 at 03:45:25 AM, Bin Meng wrote: >> On Mon, Jan 25, 2016 at 10:42 AM, Bin Meng <bmeng.cn@gmail.com> wrote: >> > On Mon, Jan 25, 2016 at 1:01 AM, Stefano Babic <sbabic@denx.de> wrote: >> >> On 24/01/2016 17:41, Marek Vasut wrote: >> >>> On Sunday, January 24, 2016 at 05:19:54 PM, Tom Rini wrote: >> >>>> On Sun, Jan 24, 2016 at 12:00:42PM +0800, Bin Meng wrote: >> >>>>> Hi, >> >>>>> >> >>>>> Summary of 71 commits for 1100 boards (24 threads, 1 job per thread) >> >>>>> 01: iocon / bamboo: Drop CONFIG_SYS_LONGHELP >> >>>>> >> >>>>> blackfin: + bf561-acvilon cm-bf561 blackstamp bf537-minotaur >> >>>>> >> >>>>> bct-brettl2 cm-bf527 bf506f-ezkit ip04 bf527-sdp pr1 >> >>>>> bf527-ad7160-eval bf609-ezkit bf537-stamp bf527-ezkit-v2 cm-bf537e >> >>>>> tcm-bf518 cm-bf537u bf527-ezkit cm-bf533 bf533-ezkit ibf-dsp561 >> >>>>> bf537-pnav bf537-srv1 cm-bf548 bf538f-ezkit bf548-ezkit bf525-ucr2 >> >>>>> blackvme tcm-bf537 bf533-stamp dnp5370 bf518f-ezbrd bf526-ezbrd >> >>>>> bf561-ezkit br4 >> >>>>> >> >>>>> aarch64: + test >> >>>>> >> >>>>> avr32: + atngw100mkii grasshopper atstk1002 atngw100 >> >>>>> >> >>>>> sh: + sh7753evb sh7785lcr_32bit sh7785lcr >> >>>>> >> >>>>> arc: + arcangel4-be axs101 axs103 tb100 arcangel4 >> >>>>> >> >>>>> openrisc: + openrisc-generic >> >>>>> >> >>>>> powerpc: + TQM834x katmai >> >>>>> >> >>>>> arm: + mx28evk mx28evk_nand xfi3 bg0900 sansa_fuze_plus >> >>>>> >> >>>>> mx23evk m28evk sc_sps_1 mx28evk_spi apx4devkit mx23_olinuxino >> >>>>> mx28evk_auart_console >> >>> >> >>> All of MXS is broken, why ? I don't recall any chances to MXS being >> >>> done recently, so what happened ? >> >> >> >> I confirm this - I have not seen any breakage (but I built today with an >> >> older gcc). Bing, can you output what you have seen for mxs boards ? >> >> They looks ok to me. >> > >> > $ make m28evk_defconfig >> > >> > HOSTCC scripts/basic/fixdep >> > HOSTCC scripts/kconfig/conf.o >> > SHIPPED scripts/kconfig/zconf.tab.c >> > SHIPPED scripts/kconfig/zconf.lex.c >> > SHIPPED scripts/kconfig/zconf.hash.c >> > HOSTCC scripts/kconfig/zconf.tab.o >> > HOSTLD scripts/kconfig/conf >> > >> > # >> > # configuration written to .config >> > # >> > $ make >> > scripts/kconfig/conf --silentoldconfig Kconfig >> > >> > CHK include/config.h >> > UPD include/config.h >> > GEN include/autoconf.mk >> > GEN include/autoconf.mk.dep >> > GEN spl/include/autoconf.mk >> > CHK include/config/uboot.release >> > UPD include/config/uboot.release >> > CHK include/generated/version_autogenerated.h >> > UPD include/generated/version_autogenerated.h >> > CHK include/generated/timestamp_autogenerated.h >> > UPD include/generated/timestamp_autogenerated.h >> > CC lib/asm-offsets.s >> > CHK include/generated/generic-asm-offsets.h >> > UPD include/generated/generic-asm-offsets.h >> > CC arch/arm/lib/asm-offsets.s >> > CHK include/generated/asm-offsets.h >> > UPD include/generated/asm-offsets.h >> > HOSTCC tools/bmp_logo >> > HOSTCC tools/envcrc.o >> > WRAP tools/lib/crc32.c >> > HOSTCC tools/lib/crc32.o >> > WRAP tools/common/env_embedded.c >> > HOSTCC tools/common/env_embedded.o >> > WRAP tools/lib/sha1.c >> > HOSTCC tools/lib/sha1.o >> > HOSTLD tools/envcrc >> > HOSTCC tools/gen_eth_addr >> > HOSTCC tools/img2srec >> > HOSTCC tools/mkenvimage.o >> > HOSTCC tools/os_support.o >> > HOSTLD tools/mkenvimage >> > HOSTCC tools/aisimage.o >> > HOSTCC tools/atmelimage.o >> > WRAP tools/common/bootm.c >> > HOSTCC tools/common/bootm.o >> > HOSTCC tools/default_image.o >> > WRAP tools/lib/fdtdec_common.c >> > HOSTCC tools/lib/fdtdec_common.o >> > WRAP tools/lib/fdtdec.c >> > HOSTCC tools/lib/fdtdec.o >> > HOSTCC tools/fit_common.o >> > HOSTCC tools/fit_image.o >> > HOSTCC tools/gpimage.o >> > HOSTCC tools/gpimage-common.o >> > WRAP tools/common/image-fit.c >> > HOSTCC tools/common/image-fit.o >> > HOSTCC tools/image-host.o >> > WRAP tools/common/image.c >> > HOSTCC tools/common/image.o >> > HOSTCC tools/imagetool.o >> > HOSTCC tools/imximage.o >> > HOSTCC tools/kwbimage.o >> > WRAP tools/lib/md5.c >> > HOSTCC tools/lib/md5.o >> > HOSTCC tools/lpc32xximage.o >> > HOSTCC tools/mxsimage.o >> > HOSTCC tools/omapimage.o >> > HOSTCC tools/pblimage.o >> > HOSTCC tools/pbl_crc32.o >> > WRAP tools/lib/rc4.c >> > HOSTCC tools/lib/rc4.o >> > HOSTCC tools/rkcommon.o >> > HOSTCC tools/rkimage.o >> > HOSTCC tools/rksd.o >> > HOSTCC tools/rkspi.o >> > HOSTCC tools/socfpgaimage.o >> > WRAP tools/lib/sha256.c >> > HOSTCC tools/lib/sha256.o >> > WRAP tools/common/hash.c >> > HOSTCC tools/common/hash.o >> > HOSTCC tools/ublimage.o >> > HOSTCC tools/zynqimage.o >> > WRAP tools/lib/libfdt/fdt.c >> > HOSTCC tools/lib/libfdt/fdt.o >> > WRAP tools/lib/libfdt/fdt_ro.c >> > HOSTCC tools/lib/libfdt/fdt_ro.o >> > WRAP tools/lib/libfdt/fdt_rw.c >> > HOSTCC tools/lib/libfdt/fdt_rw.o >> > WRAP tools/lib/libfdt/fdt_strerror.c >> > HOSTCC tools/lib/libfdt/fdt_strerror.o >> > WRAP tools/lib/libfdt/fdt_wip.c >> > HOSTCC tools/lib/libfdt/fdt_wip.o >> > WRAP tools/lib/libfdt/fdt_region.c >> > HOSTCC tools/lib/libfdt/fdt_region.o >> > HOSTCC tools/dumpimage.o >> > HOSTLD tools/dumpimage >> > HOSTCC tools/mkimage.o >> > HOSTLD tools/mkimage >> > HOSTCC tools/mxsboot >> > >> > tools/mxsboot.c: In function ‘mx28_create_sd_image’: >> > tools/mxsboot.c:560: warning: implicit declaration of function ‘htole32’ >> > /tmp/cchLIV6q.o: In function `main': >> > mxsboot.c:(.text+0x6d8): undefined reference to `htole32' >> > mxsboot.c:(.text+0x6e7): undefined reference to `htole32' >> > mxsboot.c:(.text+0x6f6): undefined reference to `htole32' >> > mxsboot.c:(.text+0x705): undefined reference to `htole32' >> > mxsboot.c:(.text+0x711): undefined reference to `htole32' >> > /tmp/cchLIV6q.o:mxsboot.c:(.text+0x71d): more undefined references to >> > `htole32' follow >> > collect2: ld returned 1 exit status >> > make[1]: *** [tools/mxsboot] Error 1 >> > make: *** [tools] Error 2 >> > >> > I am using gcc 4.1.2 as the HOSTCC. >> >> Just switched to gcc 4.7.2 as the HOSTCC, still have this 'htole32' >> error. As Tom mentioned, this might be related to the host openssl-dev >> enviroment? > > No, it's not. Try this patch: > > --8<-- > diff --git a/tools/mxsboot.c b/tools/mxsboot.c > index 3434c81..dd1027d 100644 > --- a/tools/mxsboot.c > +++ b/tools/mxsboot.c > @@ -7,6 +7,7 @@ > * SPDX-License-Identifier: GPL-2.0+ > */ > > +#define _BSD_SOURCE > #include <endian.h> > #include <fcntl.h> > #include <sys/stat.h> > -->8-- > No, it does not work with either gcc 4.1.2 or 4.7.2 :( tools/mxsboot.c:10:1: warning: "_BSD_SOURCE" redefined In file included from /usr/include/stdint.h:26, from ././include/compiler.h:19, from ././include/libfdt_env.h:12, from <command line>:1: /usr/include/features.h:162:1: warning: this is the location of the previous definition tools/mxsboot.c: In function ‘mx28_create_sd_image’: tools/mxsboot.c:561: warning: implicit declaration of function ‘htole32’ /tmp/ccGE1ile.o: In function `main': mxsboot.c:(.text+0x6d8): undefined reference to `htole32' mxsboot.c:(.text+0x6e7): undefined reference to `htole32' mxsboot.c:(.text+0x6f6): undefined reference to `htole32' mxsboot.c:(.text+0x705): undefined reference to `htole32' mxsboot.c:(.text+0x711): undefined reference to `htole32' /tmp/ccGE1ile.o:mxsboot.c:(.text+0x71d): more undefined references to `htole32' follow collect2: ld returned 1 exit status make[1]: *** [tools/mxsboot] Error 1 make: *** [tools] Error 2 > It does the same thing the manpage endian(3) suggests. But I wonder if we > shouldn't instead switch to something more portable ? Regards, Bin
On Monday, January 25, 2016 at 03:58:38 AM, Bin Meng wrote: > Hi Marek, > > On Mon, Jan 25, 2016 at 10:52 AM, Marek Vasut <marex@denx.de> wrote: > > On Monday, January 25, 2016 at 03:45:25 AM, Bin Meng wrote: > >> On Mon, Jan 25, 2016 at 10:42 AM, Bin Meng <bmeng.cn@gmail.com> wrote: > >> > On Mon, Jan 25, 2016 at 1:01 AM, Stefano Babic <sbabic@denx.de> wrote: > >> >> On 24/01/2016 17:41, Marek Vasut wrote: > >> >>> On Sunday, January 24, 2016 at 05:19:54 PM, Tom Rini wrote: > >> >>>> On Sun, Jan 24, 2016 at 12:00:42PM +0800, Bin Meng wrote: > >> >>>>> Hi, > >> >>>>> > >> >>>>> Summary of 71 commits for 1100 boards (24 threads, 1 job per > >> >>>>> thread) 01: iocon / bamboo: Drop CONFIG_SYS_LONGHELP > >> >>>>> > >> >>>>> blackfin: + bf561-acvilon cm-bf561 blackstamp bf537-minotaur > >> >>>>> > >> >>>>> bct-brettl2 cm-bf527 bf506f-ezkit ip04 bf527-sdp pr1 > >> >>>>> bf527-ad7160-eval bf609-ezkit bf537-stamp bf527-ezkit-v2 cm-bf537e > >> >>>>> tcm-bf518 cm-bf537u bf527-ezkit cm-bf533 bf533-ezkit ibf-dsp561 > >> >>>>> bf537-pnav bf537-srv1 cm-bf548 bf538f-ezkit bf548-ezkit bf525-ucr2 > >> >>>>> blackvme tcm-bf537 bf533-stamp dnp5370 bf518f-ezbrd bf526-ezbrd > >> >>>>> bf561-ezkit br4 > >> >>>>> > >> >>>>> aarch64: + test > >> >>>>> > >> >>>>> avr32: + atngw100mkii grasshopper atstk1002 atngw100 > >> >>>>> > >> >>>>> sh: + sh7753evb sh7785lcr_32bit sh7785lcr > >> >>>>> > >> >>>>> arc: + arcangel4-be axs101 axs103 tb100 arcangel4 > >> >>>>> > >> >>>>> openrisc: + openrisc-generic > >> >>>>> > >> >>>>> powerpc: + TQM834x katmai > >> >>>>> > >> >>>>> arm: + mx28evk mx28evk_nand xfi3 bg0900 sansa_fuze_plus > >> >>>>> > >> >>>>> mx23evk m28evk sc_sps_1 mx28evk_spi apx4devkit mx23_olinuxino > >> >>>>> mx28evk_auart_console > >> >>> > >> >>> All of MXS is broken, why ? I don't recall any chances to MXS being > >> >>> done recently, so what happened ? > >> >> > >> >> I confirm this - I have not seen any breakage (but I built today with > >> >> an older gcc). Bing, can you output what you have seen for mxs > >> >> boards ? They looks ok to me. > >> > > >> > $ make m28evk_defconfig > >> > > >> > HOSTCC scripts/basic/fixdep > >> > HOSTCC scripts/kconfig/conf.o > >> > SHIPPED scripts/kconfig/zconf.tab.c > >> > SHIPPED scripts/kconfig/zconf.lex.c > >> > SHIPPED scripts/kconfig/zconf.hash.c > >> > HOSTCC scripts/kconfig/zconf.tab.o > >> > HOSTLD scripts/kconfig/conf > >> > > >> > # > >> > # configuration written to .config > >> > # > >> > $ make > >> > scripts/kconfig/conf --silentoldconfig Kconfig > >> > > >> > CHK include/config.h > >> > UPD include/config.h > >> > GEN include/autoconf.mk > >> > GEN include/autoconf.mk.dep > >> > GEN spl/include/autoconf.mk > >> > CHK include/config/uboot.release > >> > UPD include/config/uboot.release > >> > CHK include/generated/version_autogenerated.h > >> > UPD include/generated/version_autogenerated.h > >> > CHK include/generated/timestamp_autogenerated.h > >> > UPD include/generated/timestamp_autogenerated.h > >> > CC lib/asm-offsets.s > >> > CHK include/generated/generic-asm-offsets.h > >> > UPD include/generated/generic-asm-offsets.h > >> > CC arch/arm/lib/asm-offsets.s > >> > CHK include/generated/asm-offsets.h > >> > UPD include/generated/asm-offsets.h > >> > HOSTCC tools/bmp_logo > >> > HOSTCC tools/envcrc.o > >> > WRAP tools/lib/crc32.c > >> > HOSTCC tools/lib/crc32.o > >> > WRAP tools/common/env_embedded.c > >> > HOSTCC tools/common/env_embedded.o > >> > WRAP tools/lib/sha1.c > >> > HOSTCC tools/lib/sha1.o > >> > HOSTLD tools/envcrc > >> > HOSTCC tools/gen_eth_addr > >> > HOSTCC tools/img2srec > >> > HOSTCC tools/mkenvimage.o > >> > HOSTCC tools/os_support.o > >> > HOSTLD tools/mkenvimage > >> > HOSTCC tools/aisimage.o > >> > HOSTCC tools/atmelimage.o > >> > WRAP tools/common/bootm.c > >> > HOSTCC tools/common/bootm.o > >> > HOSTCC tools/default_image.o > >> > WRAP tools/lib/fdtdec_common.c > >> > HOSTCC tools/lib/fdtdec_common.o > >> > WRAP tools/lib/fdtdec.c > >> > HOSTCC tools/lib/fdtdec.o > >> > HOSTCC tools/fit_common.o > >> > HOSTCC tools/fit_image.o > >> > HOSTCC tools/gpimage.o > >> > HOSTCC tools/gpimage-common.o > >> > WRAP tools/common/image-fit.c > >> > HOSTCC tools/common/image-fit.o > >> > HOSTCC tools/image-host.o > >> > WRAP tools/common/image.c > >> > HOSTCC tools/common/image.o > >> > HOSTCC tools/imagetool.o > >> > HOSTCC tools/imximage.o > >> > HOSTCC tools/kwbimage.o > >> > WRAP tools/lib/md5.c > >> > HOSTCC tools/lib/md5.o > >> > HOSTCC tools/lpc32xximage.o > >> > HOSTCC tools/mxsimage.o > >> > HOSTCC tools/omapimage.o > >> > HOSTCC tools/pblimage.o > >> > HOSTCC tools/pbl_crc32.o > >> > WRAP tools/lib/rc4.c > >> > HOSTCC tools/lib/rc4.o > >> > HOSTCC tools/rkcommon.o > >> > HOSTCC tools/rkimage.o > >> > HOSTCC tools/rksd.o > >> > HOSTCC tools/rkspi.o > >> > HOSTCC tools/socfpgaimage.o > >> > WRAP tools/lib/sha256.c > >> > HOSTCC tools/lib/sha256.o > >> > WRAP tools/common/hash.c > >> > HOSTCC tools/common/hash.o > >> > HOSTCC tools/ublimage.o > >> > HOSTCC tools/zynqimage.o > >> > WRAP tools/lib/libfdt/fdt.c > >> > HOSTCC tools/lib/libfdt/fdt.o > >> > WRAP tools/lib/libfdt/fdt_ro.c > >> > HOSTCC tools/lib/libfdt/fdt_ro.o > >> > WRAP tools/lib/libfdt/fdt_rw.c > >> > HOSTCC tools/lib/libfdt/fdt_rw.o > >> > WRAP tools/lib/libfdt/fdt_strerror.c > >> > HOSTCC tools/lib/libfdt/fdt_strerror.o > >> > WRAP tools/lib/libfdt/fdt_wip.c > >> > HOSTCC tools/lib/libfdt/fdt_wip.o > >> > WRAP tools/lib/libfdt/fdt_region.c > >> > HOSTCC tools/lib/libfdt/fdt_region.o > >> > HOSTCC tools/dumpimage.o > >> > HOSTLD tools/dumpimage > >> > HOSTCC tools/mkimage.o > >> > HOSTLD tools/mkimage > >> > HOSTCC tools/mxsboot > >> > > >> > tools/mxsboot.c: In function ‘mx28_create_sd_image’: > >> > tools/mxsboot.c:560: warning: implicit declaration of function > >> > ‘htole32’ /tmp/cchLIV6q.o: In function `main': > >> > mxsboot.c:(.text+0x6d8): undefined reference to `htole32' > >> > mxsboot.c:(.text+0x6e7): undefined reference to `htole32' > >> > mxsboot.c:(.text+0x6f6): undefined reference to `htole32' > >> > mxsboot.c:(.text+0x705): undefined reference to `htole32' > >> > mxsboot.c:(.text+0x711): undefined reference to `htole32' > >> > /tmp/cchLIV6q.o:mxsboot.c:(.text+0x71d): more undefined references to > >> > `htole32' follow > >> > collect2: ld returned 1 exit status > >> > make[1]: *** [tools/mxsboot] Error 1 > >> > make: *** [tools] Error 2 > >> > > >> > I am using gcc 4.1.2 as the HOSTCC. > >> > >> Just switched to gcc 4.7.2 as the HOSTCC, still have this 'htole32' > >> error. As Tom mentioned, this might be related to the host openssl-dev > >> enviroment? > > > > No, it's not. Try this patch: > > > > --8<-- > > diff --git a/tools/mxsboot.c b/tools/mxsboot.c > > index 3434c81..dd1027d 100644 > > --- a/tools/mxsboot.c > > +++ b/tools/mxsboot.c > > @@ -7,6 +7,7 @@ > > > > * SPDX-License-Identifier: GPL-2.0+ > > */ > > > > +#define _BSD_SOURCE > > > > #include <endian.h> > > #include <fcntl.h> > > #include <sys/stat.h> > > > > -->8-- > > No, it does not work with either gcc 4.1.2 or 4.7.2 :( > > tools/mxsboot.c:10:1: warning: "_BSD_SOURCE" redefined > In file included from /usr/include/stdint.h:26, > from ././include/compiler.h:19, > from ././include/libfdt_env.h:12, > from <command line>:1: > /usr/include/features.h:162:1: warning: this is the location of the > previous definition > tools/mxsboot.c: In function ‘mx28_create_sd_image’: > tools/mxsboot.c:561: warning: implicit declaration of function ‘htole32’ > /tmp/ccGE1ile.o: In function `main': > mxsboot.c:(.text+0x6d8): undefined reference to `htole32' > mxsboot.c:(.text+0x6e7): undefined reference to `htole32' > mxsboot.c:(.text+0x6f6): undefined reference to `htole32' > mxsboot.c:(.text+0x705): undefined reference to `htole32' > mxsboot.c:(.text+0x711): undefined reference to `htole32' > /tmp/ccGE1ile.o:mxsboot.c:(.text+0x71d): more undefined references to > `htole32' follow > collect2: ld returned 1 exit status > make[1]: *** [tools/mxsboot] Error 1 > make: *** [tools] Error 2 > > > It does the same thing the manpage endian(3) suggests. But I wonder if we > > shouldn't instead switch to something more portable ? Ow, then a bit of googling shows this patch: http://lists.denx.de/pipermail/u-boot/2014-October/192919.html
Hi Marek, On Mon, Jan 25, 2016 at 11:01 AM, Marek Vasut <marex@denx.de> wrote: > On Monday, January 25, 2016 at 03:58:38 AM, Bin Meng wrote: >> Hi Marek, >> >> On Mon, Jan 25, 2016 at 10:52 AM, Marek Vasut <marex@denx.de> wrote: >> > On Monday, January 25, 2016 at 03:45:25 AM, Bin Meng wrote: >> >> On Mon, Jan 25, 2016 at 10:42 AM, Bin Meng <bmeng.cn@gmail.com> wrote: >> >> > On Mon, Jan 25, 2016 at 1:01 AM, Stefano Babic <sbabic@denx.de> wrote: >> >> >> On 24/01/2016 17:41, Marek Vasut wrote: >> >> >>> On Sunday, January 24, 2016 at 05:19:54 PM, Tom Rini wrote: >> >> >>>> On Sun, Jan 24, 2016 at 12:00:42PM +0800, Bin Meng wrote: >> >> >>>>> Hi, >> >> >>>>> >> >> >>>>> Summary of 71 commits for 1100 boards (24 threads, 1 job per >> >> >>>>> thread) 01: iocon / bamboo: Drop CONFIG_SYS_LONGHELP >> >> >>>>> >> >> >>>>> blackfin: + bf561-acvilon cm-bf561 blackstamp bf537-minotaur >> >> >>>>> >> >> >>>>> bct-brettl2 cm-bf527 bf506f-ezkit ip04 bf527-sdp pr1 >> >> >>>>> bf527-ad7160-eval bf609-ezkit bf537-stamp bf527-ezkit-v2 cm-bf537e >> >> >>>>> tcm-bf518 cm-bf537u bf527-ezkit cm-bf533 bf533-ezkit ibf-dsp561 >> >> >>>>> bf537-pnav bf537-srv1 cm-bf548 bf538f-ezkit bf548-ezkit bf525-ucr2 >> >> >>>>> blackvme tcm-bf537 bf533-stamp dnp5370 bf518f-ezbrd bf526-ezbrd >> >> >>>>> bf561-ezkit br4 >> >> >>>>> >> >> >>>>> aarch64: + test >> >> >>>>> >> >> >>>>> avr32: + atngw100mkii grasshopper atstk1002 atngw100 >> >> >>>>> >> >> >>>>> sh: + sh7753evb sh7785lcr_32bit sh7785lcr >> >> >>>>> >> >> >>>>> arc: + arcangel4-be axs101 axs103 tb100 arcangel4 >> >> >>>>> >> >> >>>>> openrisc: + openrisc-generic >> >> >>>>> >> >> >>>>> powerpc: + TQM834x katmai >> >> >>>>> >> >> >>>>> arm: + mx28evk mx28evk_nand xfi3 bg0900 sansa_fuze_plus >> >> >>>>> >> >> >>>>> mx23evk m28evk sc_sps_1 mx28evk_spi apx4devkit mx23_olinuxino >> >> >>>>> mx28evk_auart_console >> >> >>> >> >> >>> All of MXS is broken, why ? I don't recall any chances to MXS being >> >> >>> done recently, so what happened ? >> >> >> >> >> >> I confirm this - I have not seen any breakage (but I built today with >> >> >> an older gcc). Bing, can you output what you have seen for mxs >> >> >> boards ? They looks ok to me. >> >> > >> >> > $ make m28evk_defconfig >> >> > >> >> > HOSTCC scripts/basic/fixdep >> >> > HOSTCC scripts/kconfig/conf.o >> >> > SHIPPED scripts/kconfig/zconf.tab.c >> >> > SHIPPED scripts/kconfig/zconf.lex.c >> >> > SHIPPED scripts/kconfig/zconf.hash.c >> >> > HOSTCC scripts/kconfig/zconf.tab.o >> >> > HOSTLD scripts/kconfig/conf >> >> > >> >> > # >> >> > # configuration written to .config >> >> > # >> >> > $ make >> >> > scripts/kconfig/conf --silentoldconfig Kconfig >> >> > >> >> > CHK include/config.h >> >> > UPD include/config.h >> >> > GEN include/autoconf.mk >> >> > GEN include/autoconf.mk.dep >> >> > GEN spl/include/autoconf.mk >> >> > CHK include/config/uboot.release >> >> > UPD include/config/uboot.release >> >> > CHK include/generated/version_autogenerated.h >> >> > UPD include/generated/version_autogenerated.h >> >> > CHK include/generated/timestamp_autogenerated.h >> >> > UPD include/generated/timestamp_autogenerated.h >> >> > CC lib/asm-offsets.s >> >> > CHK include/generated/generic-asm-offsets.h >> >> > UPD include/generated/generic-asm-offsets.h >> >> > CC arch/arm/lib/asm-offsets.s >> >> > CHK include/generated/asm-offsets.h >> >> > UPD include/generated/asm-offsets.h >> >> > HOSTCC tools/bmp_logo >> >> > HOSTCC tools/envcrc.o >> >> > WRAP tools/lib/crc32.c >> >> > HOSTCC tools/lib/crc32.o >> >> > WRAP tools/common/env_embedded.c >> >> > HOSTCC tools/common/env_embedded.o >> >> > WRAP tools/lib/sha1.c >> >> > HOSTCC tools/lib/sha1.o >> >> > HOSTLD tools/envcrc >> >> > HOSTCC tools/gen_eth_addr >> >> > HOSTCC tools/img2srec >> >> > HOSTCC tools/mkenvimage.o >> >> > HOSTCC tools/os_support.o >> >> > HOSTLD tools/mkenvimage >> >> > HOSTCC tools/aisimage.o >> >> > HOSTCC tools/atmelimage.o >> >> > WRAP tools/common/bootm.c >> >> > HOSTCC tools/common/bootm.o >> >> > HOSTCC tools/default_image.o >> >> > WRAP tools/lib/fdtdec_common.c >> >> > HOSTCC tools/lib/fdtdec_common.o >> >> > WRAP tools/lib/fdtdec.c >> >> > HOSTCC tools/lib/fdtdec.o >> >> > HOSTCC tools/fit_common.o >> >> > HOSTCC tools/fit_image.o >> >> > HOSTCC tools/gpimage.o >> >> > HOSTCC tools/gpimage-common.o >> >> > WRAP tools/common/image-fit.c >> >> > HOSTCC tools/common/image-fit.o >> >> > HOSTCC tools/image-host.o >> >> > WRAP tools/common/image.c >> >> > HOSTCC tools/common/image.o >> >> > HOSTCC tools/imagetool.o >> >> > HOSTCC tools/imximage.o >> >> > HOSTCC tools/kwbimage.o >> >> > WRAP tools/lib/md5.c >> >> > HOSTCC tools/lib/md5.o >> >> > HOSTCC tools/lpc32xximage.o >> >> > HOSTCC tools/mxsimage.o >> >> > HOSTCC tools/omapimage.o >> >> > HOSTCC tools/pblimage.o >> >> > HOSTCC tools/pbl_crc32.o >> >> > WRAP tools/lib/rc4.c >> >> > HOSTCC tools/lib/rc4.o >> >> > HOSTCC tools/rkcommon.o >> >> > HOSTCC tools/rkimage.o >> >> > HOSTCC tools/rksd.o >> >> > HOSTCC tools/rkspi.o >> >> > HOSTCC tools/socfpgaimage.o >> >> > WRAP tools/lib/sha256.c >> >> > HOSTCC tools/lib/sha256.o >> >> > WRAP tools/common/hash.c >> >> > HOSTCC tools/common/hash.o >> >> > HOSTCC tools/ublimage.o >> >> > HOSTCC tools/zynqimage.o >> >> > WRAP tools/lib/libfdt/fdt.c >> >> > HOSTCC tools/lib/libfdt/fdt.o >> >> > WRAP tools/lib/libfdt/fdt_ro.c >> >> > HOSTCC tools/lib/libfdt/fdt_ro.o >> >> > WRAP tools/lib/libfdt/fdt_rw.c >> >> > HOSTCC tools/lib/libfdt/fdt_rw.o >> >> > WRAP tools/lib/libfdt/fdt_strerror.c >> >> > HOSTCC tools/lib/libfdt/fdt_strerror.o >> >> > WRAP tools/lib/libfdt/fdt_wip.c >> >> > HOSTCC tools/lib/libfdt/fdt_wip.o >> >> > WRAP tools/lib/libfdt/fdt_region.c >> >> > HOSTCC tools/lib/libfdt/fdt_region.o >> >> > HOSTCC tools/dumpimage.o >> >> > HOSTLD tools/dumpimage >> >> > HOSTCC tools/mkimage.o >> >> > HOSTLD tools/mkimage >> >> > HOSTCC tools/mxsboot >> >> > >> >> > tools/mxsboot.c: In function ‘mx28_create_sd_image’: >> >> > tools/mxsboot.c:560: warning: implicit declaration of function >> >> > ‘htole32’ /tmp/cchLIV6q.o: In function `main': >> >> > mxsboot.c:(.text+0x6d8): undefined reference to `htole32' >> >> > mxsboot.c:(.text+0x6e7): undefined reference to `htole32' >> >> > mxsboot.c:(.text+0x6f6): undefined reference to `htole32' >> >> > mxsboot.c:(.text+0x705): undefined reference to `htole32' >> >> > mxsboot.c:(.text+0x711): undefined reference to `htole32' >> >> > /tmp/cchLIV6q.o:mxsboot.c:(.text+0x71d): more undefined references to >> >> > `htole32' follow >> >> > collect2: ld returned 1 exit status >> >> > make[1]: *** [tools/mxsboot] Error 1 >> >> > make: *** [tools] Error 2 >> >> > >> >> > I am using gcc 4.1.2 as the HOSTCC. >> >> >> >> Just switched to gcc 4.7.2 as the HOSTCC, still have this 'htole32' >> >> error. As Tom mentioned, this might be related to the host openssl-dev >> >> enviroment? >> > >> > No, it's not. Try this patch: >> > >> > --8<-- >> > diff --git a/tools/mxsboot.c b/tools/mxsboot.c >> > index 3434c81..dd1027d 100644 >> > --- a/tools/mxsboot.c >> > +++ b/tools/mxsboot.c >> > @@ -7,6 +7,7 @@ >> > >> > * SPDX-License-Identifier: GPL-2.0+ >> > */ >> > >> > +#define _BSD_SOURCE >> > >> > #include <endian.h> >> > #include <fcntl.h> >> > #include <sys/stat.h> >> > >> > -->8-- >> >> No, it does not work with either gcc 4.1.2 or 4.7.2 :( >> >> tools/mxsboot.c:10:1: warning: "_BSD_SOURCE" redefined >> In file included from /usr/include/stdint.h:26, >> from ././include/compiler.h:19, >> from ././include/libfdt_env.h:12, >> from <command line>:1: >> /usr/include/features.h:162:1: warning: this is the location of the >> previous definition >> tools/mxsboot.c: In function ‘mx28_create_sd_image’: >> tools/mxsboot.c:561: warning: implicit declaration of function ‘htole32’ >> /tmp/ccGE1ile.o: In function `main': >> mxsboot.c:(.text+0x6d8): undefined reference to `htole32' >> mxsboot.c:(.text+0x6e7): undefined reference to `htole32' >> mxsboot.c:(.text+0x6f6): undefined reference to `htole32' >> mxsboot.c:(.text+0x705): undefined reference to `htole32' >> mxsboot.c:(.text+0x711): undefined reference to `htole32' >> /tmp/ccGE1ile.o:mxsboot.c:(.text+0x71d): more undefined references to >> `htole32' follow >> collect2: ld returned 1 exit status >> make[1]: *** [tools/mxsboot] Error 1 >> make: *** [tools] Error 2 >> >> > It does the same thing the manpage endian(3) suggests. But I wonder if we >> > shouldn't instead switch to something more portable ? > > Ow, then a bit of googling shows this patch: > > http://lists.denx.de/pipermail/u-boot/2014-October/192919.html This works! I can prepare a patch if you like. Regards, Bin
On Monday, January 25, 2016 at 04:12:37 AM, Bin Meng wrote: > Hi Marek, Hi! > On Mon, Jan 25, 2016 at 11:01 AM, Marek Vasut <marex@denx.de> wrote: > > On Monday, January 25, 2016 at 03:58:38 AM, Bin Meng wrote: > >> Hi Marek, > >> > >> On Mon, Jan 25, 2016 at 10:52 AM, Marek Vasut <marex@denx.de> wrote: > >> > On Monday, January 25, 2016 at 03:45:25 AM, Bin Meng wrote: > >> >> On Mon, Jan 25, 2016 at 10:42 AM, Bin Meng <bmeng.cn@gmail.com> wrote: > >> >> > On Mon, Jan 25, 2016 at 1:01 AM, Stefano Babic <sbabic@denx.de> wrote: > >> >> >> On 24/01/2016 17:41, Marek Vasut wrote: > >> >> >>> On Sunday, January 24, 2016 at 05:19:54 PM, Tom Rini wrote: > >> >> >>>> On Sun, Jan 24, 2016 at 12:00:42PM +0800, Bin Meng wrote: > >> >> >>>>> Hi, > >> >> >>>>> > >> >> >>>>> Summary of 71 commits for 1100 boards (24 threads, 1 job per > >> >> >>>>> thread) 01: iocon / bamboo: Drop CONFIG_SYS_LONGHELP > >> >> >>>>> > >> >> >>>>> blackfin: + bf561-acvilon cm-bf561 blackstamp > >> >> >>>>> bf537-minotaur > >> >> >>>>> > >> >> >>>>> bct-brettl2 cm-bf527 bf506f-ezkit ip04 bf527-sdp pr1 > >> >> >>>>> bf527-ad7160-eval bf609-ezkit bf537-stamp bf527-ezkit-v2 > >> >> >>>>> cm-bf537e tcm-bf518 cm-bf537u bf527-ezkit cm-bf533 bf533-ezkit > >> >> >>>>> ibf-dsp561 bf537-pnav bf537-srv1 cm-bf548 bf538f-ezkit > >> >> >>>>> bf548-ezkit bf525-ucr2 blackvme tcm-bf537 bf533-stamp dnp5370 > >> >> >>>>> bf518f-ezbrd bf526-ezbrd bf561-ezkit br4 > >> >> >>>>> > >> >> >>>>> aarch64: + test > >> >> >>>>> > >> >> >>>>> avr32: + atngw100mkii grasshopper atstk1002 atngw100 > >> >> >>>>> > >> >> >>>>> sh: + sh7753evb sh7785lcr_32bit sh7785lcr > >> >> >>>>> > >> >> >>>>> arc: + arcangel4-be axs101 axs103 tb100 arcangel4 > >> >> >>>>> > >> >> >>>>> openrisc: + openrisc-generic > >> >> >>>>> > >> >> >>>>> powerpc: + TQM834x katmai > >> >> >>>>> > >> >> >>>>> arm: + mx28evk mx28evk_nand xfi3 bg0900 > >> >> >>>>> sansa_fuze_plus > >> >> >>>>> > >> >> >>>>> mx23evk m28evk sc_sps_1 mx28evk_spi apx4devkit mx23_olinuxino > >> >> >>>>> mx28evk_auart_console > >> >> >>> > >> >> >>> All of MXS is broken, why ? I don't recall any chances to MXS > >> >> >>> being done recently, so what happened ? > >> >> >> > >> >> >> I confirm this - I have not seen any breakage (but I built today > >> >> >> with an older gcc). Bing, can you output what you have seen for > >> >> >> mxs boards ? They looks ok to me. > >> >> > > >> >> > $ make m28evk_defconfig > >> >> > > >> >> > HOSTCC scripts/basic/fixdep > >> >> > HOSTCC scripts/kconfig/conf.o > >> >> > SHIPPED scripts/kconfig/zconf.tab.c > >> >> > SHIPPED scripts/kconfig/zconf.lex.c > >> >> > SHIPPED scripts/kconfig/zconf.hash.c > >> >> > HOSTCC scripts/kconfig/zconf.tab.o > >> >> > HOSTLD scripts/kconfig/conf > >> >> > > >> >> > # > >> >> > # configuration written to .config > >> >> > # > >> >> > $ make > >> >> > scripts/kconfig/conf --silentoldconfig Kconfig > >> >> > > >> >> > CHK include/config.h > >> >> > UPD include/config.h > >> >> > GEN include/autoconf.mk > >> >> > GEN include/autoconf.mk.dep > >> >> > GEN spl/include/autoconf.mk > >> >> > CHK include/config/uboot.release > >> >> > UPD include/config/uboot.release > >> >> > CHK include/generated/version_autogenerated.h > >> >> > UPD include/generated/version_autogenerated.h > >> >> > CHK include/generated/timestamp_autogenerated.h > >> >> > UPD include/generated/timestamp_autogenerated.h > >> >> > CC lib/asm-offsets.s > >> >> > CHK include/generated/generic-asm-offsets.h > >> >> > UPD include/generated/generic-asm-offsets.h > >> >> > CC arch/arm/lib/asm-offsets.s > >> >> > CHK include/generated/asm-offsets.h > >> >> > UPD include/generated/asm-offsets.h > >> >> > HOSTCC tools/bmp_logo > >> >> > HOSTCC tools/envcrc.o > >> >> > WRAP tools/lib/crc32.c > >> >> > HOSTCC tools/lib/crc32.o > >> >> > WRAP tools/common/env_embedded.c > >> >> > HOSTCC tools/common/env_embedded.o > >> >> > WRAP tools/lib/sha1.c > >> >> > HOSTCC tools/lib/sha1.o > >> >> > HOSTLD tools/envcrc > >> >> > HOSTCC tools/gen_eth_addr > >> >> > HOSTCC tools/img2srec > >> >> > HOSTCC tools/mkenvimage.o > >> >> > HOSTCC tools/os_support.o > >> >> > HOSTLD tools/mkenvimage > >> >> > HOSTCC tools/aisimage.o > >> >> > HOSTCC tools/atmelimage.o > >> >> > WRAP tools/common/bootm.c > >> >> > HOSTCC tools/common/bootm.o > >> >> > HOSTCC tools/default_image.o > >> >> > WRAP tools/lib/fdtdec_common.c > >> >> > HOSTCC tools/lib/fdtdec_common.o > >> >> > WRAP tools/lib/fdtdec.c > >> >> > HOSTCC tools/lib/fdtdec.o > >> >> > HOSTCC tools/fit_common.o > >> >> > HOSTCC tools/fit_image.o > >> >> > HOSTCC tools/gpimage.o > >> >> > HOSTCC tools/gpimage-common.o > >> >> > WRAP tools/common/image-fit.c > >> >> > HOSTCC tools/common/image-fit.o > >> >> > HOSTCC tools/image-host.o > >> >> > WRAP tools/common/image.c > >> >> > HOSTCC tools/common/image.o > >> >> > HOSTCC tools/imagetool.o > >> >> > HOSTCC tools/imximage.o > >> >> > HOSTCC tools/kwbimage.o > >> >> > WRAP tools/lib/md5.c > >> >> > HOSTCC tools/lib/md5.o > >> >> > HOSTCC tools/lpc32xximage.o > >> >> > HOSTCC tools/mxsimage.o > >> >> > HOSTCC tools/omapimage.o > >> >> > HOSTCC tools/pblimage.o > >> >> > HOSTCC tools/pbl_crc32.o > >> >> > WRAP tools/lib/rc4.c > >> >> > HOSTCC tools/lib/rc4.o > >> >> > HOSTCC tools/rkcommon.o > >> >> > HOSTCC tools/rkimage.o > >> >> > HOSTCC tools/rksd.o > >> >> > HOSTCC tools/rkspi.o > >> >> > HOSTCC tools/socfpgaimage.o > >> >> > WRAP tools/lib/sha256.c > >> >> > HOSTCC tools/lib/sha256.o > >> >> > WRAP tools/common/hash.c > >> >> > HOSTCC tools/common/hash.o > >> >> > HOSTCC tools/ublimage.o > >> >> > HOSTCC tools/zynqimage.o > >> >> > WRAP tools/lib/libfdt/fdt.c > >> >> > HOSTCC tools/lib/libfdt/fdt.o > >> >> > WRAP tools/lib/libfdt/fdt_ro.c > >> >> > HOSTCC tools/lib/libfdt/fdt_ro.o > >> >> > WRAP tools/lib/libfdt/fdt_rw.c > >> >> > HOSTCC tools/lib/libfdt/fdt_rw.o > >> >> > WRAP tools/lib/libfdt/fdt_strerror.c > >> >> > HOSTCC tools/lib/libfdt/fdt_strerror.o > >> >> > WRAP tools/lib/libfdt/fdt_wip.c > >> >> > HOSTCC tools/lib/libfdt/fdt_wip.o > >> >> > WRAP tools/lib/libfdt/fdt_region.c > >> >> > HOSTCC tools/lib/libfdt/fdt_region.o > >> >> > HOSTCC tools/dumpimage.o > >> >> > HOSTLD tools/dumpimage > >> >> > HOSTCC tools/mkimage.o > >> >> > HOSTLD tools/mkimage > >> >> > HOSTCC tools/mxsboot > >> >> > > >> >> > tools/mxsboot.c: In function ‘mx28_create_sd_image’: > >> >> > tools/mxsboot.c:560: warning: implicit declaration of function > >> >> > ‘htole32’ /tmp/cchLIV6q.o: In function `main': > >> >> > mxsboot.c:(.text+0x6d8): undefined reference to `htole32' > >> >> > mxsboot.c:(.text+0x6e7): undefined reference to `htole32' > >> >> > mxsboot.c:(.text+0x6f6): undefined reference to `htole32' > >> >> > mxsboot.c:(.text+0x705): undefined reference to `htole32' > >> >> > mxsboot.c:(.text+0x711): undefined reference to `htole32' > >> >> > /tmp/cchLIV6q.o:mxsboot.c:(.text+0x71d): more undefined references > >> >> > to `htole32' follow > >> >> > collect2: ld returned 1 exit status > >> >> > make[1]: *** [tools/mxsboot] Error 1 > >> >> > make: *** [tools] Error 2 > >> >> > > >> >> > I am using gcc 4.1.2 as the HOSTCC. > >> >> > >> >> Just switched to gcc 4.7.2 as the HOSTCC, still have this 'htole32' > >> >> error. As Tom mentioned, this might be related to the host > >> >> openssl-dev enviroment? > >> > > >> > No, it's not. Try this patch: > >> > > >> > --8<-- > >> > diff --git a/tools/mxsboot.c b/tools/mxsboot.c > >> > index 3434c81..dd1027d 100644 > >> > --- a/tools/mxsboot.c > >> > +++ b/tools/mxsboot.c > >> > @@ -7,6 +7,7 @@ > >> > > >> > * SPDX-License-Identifier: GPL-2.0+ > >> > */ > >> > > >> > +#define _BSD_SOURCE > >> > > >> > #include <endian.h> > >> > #include <fcntl.h> > >> > #include <sys/stat.h> > >> > > >> > -->8-- > >> > >> No, it does not work with either gcc 4.1.2 or 4.7.2 :( > >> > >> tools/mxsboot.c:10:1: warning: "_BSD_SOURCE" redefined > >> In file included from /usr/include/stdint.h:26, > >> > >> from ././include/compiler.h:19, > >> from ././include/libfdt_env.h:12, > >> > >> from <command line>:1: > >> /usr/include/features.h:162:1: warning: this is the location of the > >> previous definition > >> tools/mxsboot.c: In function ‘mx28_create_sd_image’: > >> tools/mxsboot.c:561: warning: implicit declaration of function ‘htole32’ > >> /tmp/ccGE1ile.o: In function `main': > >> mxsboot.c:(.text+0x6d8): undefined reference to `htole32' > >> mxsboot.c:(.text+0x6e7): undefined reference to `htole32' > >> mxsboot.c:(.text+0x6f6): undefined reference to `htole32' > >> mxsboot.c:(.text+0x705): undefined reference to `htole32' > >> mxsboot.c:(.text+0x711): undefined reference to `htole32' > >> /tmp/ccGE1ile.o:mxsboot.c:(.text+0x71d): more undefined references to > >> `htole32' follow > >> collect2: ld returned 1 exit status > >> make[1]: *** [tools/mxsboot] Error 1 > >> make: *** [tools] Error 2 > >> > >> > It does the same thing the manpage endian(3) suggests. But I wonder if > >> > we shouldn't instead switch to something more portable ? > > > > Ow, then a bit of googling shows this patch: > > > > http://lists.denx.de/pipermail/u-boot/2014-October/192919.html > > This works! I can prepare a patch if you like. Excellent, and it seems like the more permanent solution I had in mind too :) I guess you already have the patch ready anyway, so please submit it. Thanks!
diff --git a/tools/mxsboot.c b/tools/mxsboot.c index 3434c81..dd1027d 100644 --- a/tools/mxsboot.c +++ b/tools/mxsboot.c @@ -7,6 +7,7 @@ * SPDX-License-Identifier: GPL-2.0+ */ +#define _BSD_SOURCE #include <endian.h> #include <fcntl.h> #include <sys/stat.h>