From patchwork Sat Jan 16 05:26:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 568962 X-Patchwork-Delegate: daniel.schwierzeck@googlemail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 38E74140BAB for ; Sat, 16 Jan 2016 16:26:56 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 188A6A7693; Sat, 16 Jan 2016 06:26:51 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T2MmEfdApqRw; Sat, 16 Jan 2016 06:26:50 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id A8C3AA75F5; Sat, 16 Jan 2016 06:26:50 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 8FA4EA75F5 for ; Sat, 16 Jan 2016 06:26:48 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v-s4zhB_Sic5 for ; Sat, 16 Jan 2016 06:26:48 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by theia.denx.de (Postfix) with ESMTPS id 33182A748A for ; Sat, 16 Jan 2016 06:26:44 +0100 (CET) Received: from mail.nefkom.net (unknown [192.168.8.184]) by mail-out.m-online.net (Postfix) with ESMTP id 3pj7Cj2NNtz3hlgJ; Sat, 16 Jan 2016 06:26:41 +0100 (CET) X-Auth-Info: NBNtjsyccRhd+oEQzl4/btNYdUPox0zvT0sflLZP87I= Received: from chi.localnet (unknown [195.140.253.167]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by smtp-auth.mnet-online.de (Postfix) with ESMTPSA id 3pj7Ch5HQBzvdWV; Sat, 16 Jan 2016 06:26:40 +0100 (CET) From: Marek Vasut To: Wills Wang Date: Sat, 16 Jan 2016 06:26:39 +0100 User-Agent: KMail/1.13.7 (Linux/3.14-2-amd64; KDE/4.13.1; x86_64; ; ) References: In-Reply-To: MIME-Version: 1.0 Message-Id: <201601160626.39480.marex@denx.de> Cc: Axel Lin , "rev13@wp.pl" , u-boot@lists.denx.de, Purna Chandra Mandal , Joe Hershberger , Jagan Teki Subject: Re: [U-Boot] [PATCH v6 00/10] add support for atheros ath79 based SOCs X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" On Monday, January 04, 2016 at 12:06:17 PM, Wills Wang wrote: > These series of patch add support for atheros ath79 based SOCs in u-boot, > at the present moment it's just available for ar933x and qca953x chip. > > Changes in v6: > - Remove useless "else" > - Move ar933x as separate patch > - Add get_bootstrap in reset.c > - Use map_physmem instead of KSEG1ADDR > - Add arch_cpu_init for detect SOC type for early > - Define magic value in ddr.c > - Remove wait loop in putc and getc > - Use map_physmem instead of KSEG1ADDR > - Add rrw_delay in ath79_spi_priv for more accurate timing > - Remove ath79_spi_delay > - Calculate delay in ath79_spi_set_speed > - Convert SZ_XXX into hex in ap121.h > - Remove useless CONFIG_SYS_INIT_SP_OFFSET in ap121.h > - Add board_early_init_f for DDR and pin initialization > - Select UART and SPI in ap121_defconfig > - Add support for qca953x I wanted to try this patchset, so I picked [1], since I didn't feel like fishing out patches from the list. Especially since this wasn't sent as a series, but as separate patches, which makes things annoying. The [1] does not even compile, which is surprising. I would expect that if you submit patches, you would at least compile-test them. Sigh. I needed this patch: ---8<--- --->8--- Once I managed to fix things, I compiled ap121. I tried booting it on arduino yun (ar9331), but it hung in start.S in setup_c0_status . If I comment this out, it hangs in lowlevel_init, right at the beginning. That's where I gave up. [1] http://git.denx.de/?p=u-boot/u-boot- mips.git;a=shortlog;h=refs/heads/mips_ath79_v6 Best regards, Marek Vasut diff --git a/arch/mips/mach-ath79/cpu.c b/arch/mips/mach-ath79/cpu.c index 2952679..140c65c 100644 --- a/arch/mips/mach-ath79/cpu.c +++ b/arch/mips/mach-ath79/cpu.c @@ -9,8 +9,8 @@ #include #include #include -#include -#include +#include +#include struct ath79_soc_desc { enum ath79_soc_type soc; diff --git a/arch/mips/mach-ath79/reset.c b/arch/mips/mach-ath79/reset.c index 410b900..fe32d80 100644 --- a/arch/mips/mach-ath79/reset.c +++ b/arch/mips/mach-ath79/reset.c @@ -9,7 +9,7 @@ #include #include #include -#include +#include #include void _machine_restart(void)