From patchwork Tue Aug 11 15:20:38 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Bradford X-Patchwork-Id: 506136 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 732711400A0 for ; Wed, 12 Aug 2015 01:20:54 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=bradfordembedded.com header.i=@bradfordembedded.com header.b=q6eXlR4O; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b=mcFKKOr/; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 2B7904BB95; Tue, 11 Aug 2015 17:20:52 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VWziIfnOwoJI; Tue, 11 Aug 2015 17:20:51 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 403384B9A1; Tue, 11 Aug 2015 17:20:51 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 649194B9A1 for ; Tue, 11 Aug 2015 17:20:46 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WldOUmfGP4QT for ; Tue, 11 Aug 2015 17:20:46 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by theia.denx.de (Postfix) with ESMTPS id 069304B98F for ; Tue, 11 Aug 2015 17:20:41 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id BB65222754 for ; Tue, 11 Aug 2015 11:20:40 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Tue, 11 Aug 2015 11:20:40 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= bradfordembedded.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=MeVUHskQ5AYoyXSuXYth3PShaac=; b=q6eXlR 4OSOAWQfHfQ/WQelYEiz0QXZT0+XtgbFi4MbQdjKu38A2XXPLbLEW8OIDjIagObJ dNrhwItilyfzUa7gG6SDurUdMAHOMFNhs05VmS+uhObEyMCVfb6cX8FTCB2BVE0A J11VAc8Ge/oLSxSHoxG3G3YcpsZ8dL/AnpYoc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=MeVUHskQ5AYoyXSuXYth3PShaac=; b=mcFKK Or/pZuH5hdOPvCb9OEn8esxI2mE/L6tBhkDGuecEmO5Yb1a5maYprFjeozk2uaDc 8V+cKYE9BhnxefTYHuAIlxvaHx5cio5oyAb6SZtOoYM9p9q6MDFGYr3TKbY4qYY4 uGXwJBsj4DD9nnJUHoYOApQRekVp6Vj9Ib8TmU= X-Sasl-enc: odrv27kD55mbxBiUMxHMK40SOkGV4Juq4bk+wUnyoyNz 1439306440 Received: from rhino.kodakalaris.net (clr-vpn01.kodakalaris.com [198.140.222.129]) by mail.messagingengine.com (Postfix) with ESMTPA id 55FF2680178; Tue, 11 Aug 2015 11:20:40 -0400 (EDT) Date: Tue, 11 Aug 2015 11:20:38 -0400 From: Andrew Bradford To: Simon Glass Message-ID: <20150811152038.GC13429@rhino.kodakalaris.net> References: <1438950995-7771-1-git-send-email-andrew@bradfordembedded.com> <20150809010859.GA3842@bradfordembedded.com> <20150810113256.GA3645@rhino.kodakalaris.net> <20150811120820.GA13429@rhino.kodakalaris.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Graeme Russ , U-Boot Mailing List , Andrew Bradford Subject: Re: [U-Boot] [PATCH v4] x86: baytrail: Configure FSP UPD from device tree X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Hi Simon, On 08/11 08:06, Simon Glass wrote: > Hi Andrew, > > On 11 August 2015 at 06:08, Andrew Bradford wrote: > > Hi Simon, > > > > On 08/10 21:07, Simon Glass wrote: > >> Hi Bin, > >> > >> On 10 August 2015 at 20:53, Bin Meng wrote: > >> > Hi Andrew, > >> > > >> > On Mon, Aug 10, 2015 at 7:32 PM, Andrew Bradford > >> > wrote: > >> >> Hi Bin, > >> >> > >> >> On 08/09 10:52, Bin Meng wrote: > >> >>> Hi Andrew, > >> >>> > >> >>> On Sun, Aug 9, 2015 at 9:08 AM, Andrew Bradford > >> >>> wrote: > >> >>> > Hi Simon, > >> >>> > > >> >>> > On 08/08 10:18, Simon Glass wrote: > >> >>> >> Hi, > >> >>> >> > >> >>> >> On 7 August 2015 at 06:44, Bin Meng wrote: > >> >>> >> > On Fri, Aug 7, 2015 at 8:36 PM, Andrew Bradford > >> >>> >> > wrote: > >> >>> >> >> From: Andrew Bradford > >> >>> >> >> > >> >>> >> >> Allow for configuration of FSP UPD from the device tree which will > >> >>> >> >> override any settings which the FSP was built with itself. > >> >>> >> >> > >> >>> >> >> Modify the MinnowMax and BayleyBay boards to transfer sensible UPD > >> >>> >> >> settings from the Intel FSPv4 Gold release to the respective dts files, > >> >>> >> >> with the condition that the memory-down parameters for MinnowMax are > >> >>> >> >> also used. > >> >>> >> >> > >> >>> >> >> Signed-off-by: Andrew Bradford > >> >>> >> >> --- > >> >>> >> >> > >> >>> >> > > >> >>> >> > Reviewed-by: Bin Meng > >> >>> >> > Tested-by: Bin Meng > >> >>> >> > > >> >>> >> > >> >>> >> Acked-by: Simon Glass > >> >>> >> Tested on minnowmax: > >> >>> >> Tested-by: Simon Glass > >> >>> >> > >> >>> >> I found that I need to remove two properties from the minnowmax.dts: > >> >>> >> > >> >>> >> - fsp,enable-xhci needs to be removed as this does not work in U-Boot > >> >>> >> at present and stops EHCI from working > >> >>> >> - fsp,mrc-debug-msg needs to be removed to prevent debug information > >> >>> >> being displayed > >> >>> >> > >> >>> >> I plan to apply this with these changes - please let me know if this > >> >>> >> doesn't suit. > >> >>> > > >> >>> > I'm OK with disabling xhci and the MRC debug output in the FSP. > >> >>> > > >> >>> > But if xhci is disabled then I believe when Linux boots that the USB 3.0 > >> >>> > port on Minnow Max will only act as a USB 2.0 port. That u-boot doesn't > >> >>> > yet have working XHCI on E3800 means there is a tradeoff and I wasn't > >> >>> > sure which was a better choice. > >> >>> > >> >>> Does these xHCI ports on MinnowMax work fully on Linux kernel? If it > >> >>> works, I'd rather we keep fsp,enable-xhci in the U-Boot. > >> >> > >> >> I believe that the xhci port does work on Minnow Max in Linux but I do > >> >> not have a board so I'm unable to test, sorry. > >> >> > >> > > >> > OK, my test shows that ehci works fine in U-Boot on Bayley Bay. > >> > > >> > Hi Simon, > >> > > >> > What do you think regarding to xhci vs. ehci in U-Boot? > >> > >> The problem is that USB is then broken in U-Boot. I think it is better > >> to limit the speed for the moment until we have that fixed. It is > >> quite useful to be able to use a keyboard or USB stick in U-Boot. > >> > >> With my testing the bottom (blue) port works fine but the top port > >> does not. This happens regardless of the xhci setting. > > > > Minnowmax has a USB power switch enable which determines if the VBUS2 > > net is turned on or not, which will supply or not supply power to the > > USB 2.0 port. The blue USB 3.0 port also has an enable. Both enables > > and the USB ports themselves are located on page 16 of the schematic > > that I have. > > > > The switches to enable the VBUS for each port are active high and pulled > > down. So to turn them on, I believe that's the point of the pinmuxing > > and GPIO settings which are used in the minnowmax.dts. Can you verify > > if these are correctly turning on VBUS2 (since it sounds like they are > > turning on VBUS1)? If not, when you turn these GPIO on manually, does > > the USB 2.0 port work correctly? > > I see power on the bottom port but not the top one. OK, that's odd, but likely can be fixed with changes to the pin mux and pad settings in the dts. I believe that the "pad-offset" for pin_usb_host_en1@0 is wrong and that it should be 0x250 instead of 0x258. Does that fix it? Thanks, Andrew diff --git a/arch/x86/dts/minnowmax.dts b/arch/x86/dts/minnowmax.dts index d0c0fe6..4988163 100644 --- a/arch/x86/dts/minnowmax.dts +++ b/arch/x86/dts/minnowmax.dts @@ -39,7 +39,7 @@ pin_usb_host_en1@0 { gpio-offset = <0x80 9>; - pad-offset = <0x258>; + pad-offset = <0x250>; mode-gpio; output-value = <1>; direction = ;