From patchwork Fri Apr 19 14:48:42 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philip Paeps X-Patchwork-Id: 238008 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 404452C01B8 for ; Sat, 20 Apr 2013 00:48:57 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 590674A400; Fri, 19 Apr 2013 16:48:54 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cLZqzFBParbk; Fri, 19 Apr 2013 16:48:54 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id D2FBE4A38E; Fri, 19 Apr 2013 16:48:51 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id D62C64A38E for ; Fri, 19 Apr 2013 16:48:49 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B-jVTqJApcjS for ; Fri, 19 Apr 2013 16:48:48 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from rincewind.paeps.cx (rincewind.paeps.cx [5.9.88.46]) by theia.denx.de (Postfix) with ESMTPS id 761404A384 for ; Fri, 19 Apr 2013 16:48:46 +0200 (CEST) Received: from twoflower.paeps.cx (unknown [213.173.227.110]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: philip) by rincewind.paeps.cx (Postfix) with ESMTPSA id E91A585E; Fri, 19 Apr 2013 16:48:44 +0200 (CEST) Date: Fri, 19 Apr 2013 16:48:42 +0200 From: Philip Paeps To: Marek Vasut Message-ID: <20130419144840.GC246@twoflower.paeps.cx> References: <1366344655-8535-1-git-send-email-marex@denx.de> <1366344655-8535-2-git-send-email-marex@denx.de> <20130419130013.GA246@twoflower.paeps.cx> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130419130013.GA246@twoflower.paeps.cx> X-PGP-Fingerprint: 356B AE02 4763 F739 2FA2 E438 2649 E628 C5D3 4D05 X-Date: Today is Prickle-Prickle, the 36th day of Discord in the YOLD 3179 X-Phase-of-Moon: The Moon is Waxing Gibbous (61% of Full) X-Philip-Conspiracy: There is no conspiracy Organization: Happily Disorganized User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Fabio Estevam , u-boot@lists.denx.de, Tom Rini , Scott Wood Subject: Re: [U-Boot] [PATCH 2/6] nand: Add SPL_NAND support to mxc_nand_spl X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de On 2013-04-19 15:00:13 (+0200), Philip Paeps wrote: > On 2013-04-19 06:10:51 (+0200), Marek Vasut wrote: > > To avoid the old function which are used with the nand_spl/ stuff > > getting in the way of NAND SPL framework, the macro > > CONFIG_SPL_NAND_LEGACY was introduced and two remaining legacy > > boards were adjusted. These board need to be either fixed or > > removed in the long run, but I don't have either. > > It sounds like "fixing" these boards is mainly a matter of confirming > that a configuration for them based around CONFIG_SPL_FRAMEWORK will fit > in 2K. If so, I don't think there is any reason to keep legacy support > around. A first build with CONFIG_SPL_FRAMEWORK came out to nearly 4K. Large contributors being (unsurprisingly) libcommon and libgeneric. I had to get rid of a puts() in libspl to make it build without those libraries. Unfortunately, that still came out to 2.2K. Close. :-) I couldn't identify any obvious 100 bytes to scrap from glancing at u-boot-spl.map or objdump -D u-boot-spl, but I'll take a look. - Philip diff --git a/common/spl/spl.c b/common/spl/spl.c index 6a5a136..c061ab4 100644 --- a/common/spl/spl.c +++ b/common/spl/spl.c @@ -50,7 +50,6 @@ static bd_t bdata __attribute__ ((section(".data"))); inline void hang(void) { - puts("### ERROR ### Please RESET the board ###\n"); for (;;) ; }