mbox

[U-Boot,GIT,PULL] mpc83xx: mpc8308rdb enhancements

Message ID 20120917183656.580425350c48594a999aa735@freescale.com
State Rejected
Delegated to: Tom Rini
Headers show

Pull-request

git://git.denx.de/u-boot-mpc83xx.git master

Message

Kim Phillips Sept. 17, 2012, 11:36 p.m. UTC 
Hi Tom,

Ira improved mpc8308rdb h/w support by making it more comprehensive.
Please pull:

The following changes since commit a6f0c4faa4c65a7b7048b12c9d180d7e1aad1721:

  Merge branch 'master' of git://git.denx.de/u-boot-avr32 (2012-09-04 09:17:27 +0200)

are available in the git repository at:


  git://git.denx.de/u-boot-mpc83xx.git master

for you to fetch changes up to 014d1dfc669ab2295d7fa4ec4b9f00a4004917a0:

  mpc8308rdb: add support for eSDHC MMC controller (2012-09-17 17:47:12 -0500)

----------------------------------------------------------------
Ira W. Snyder (5):
      mpc8xxx_spi: fix SPI support on MPC8308RDB
      mpc8308rdb: add support for Spansion SPI flash on header J8
      spansion: add support for S25FL256S1
      mpc8308rdb: add support for FIT images
      mpc8308rdb: add support for eSDHC MMC controller

 board/freescale/mpc8308rdb/mpc8308rdb.c | 58 +++++++++++++++++++++++++++++++++
 drivers/mtd/spi/spansion.c              |  8 +++++
 drivers/spi/mpc8xxx_spi.c               |  4 +++
 include/configs/MPC8308RDB.h            | 31 ++++++++++++++++++
 4 files changed, 101 insertions(+)

Thanks,

Kim

Comments

Tom Rini Sept. 18, 2012, 1:18 a.m. UTC | #1 
On Mon, Sep 17, 2012 at 06:36:56PM -0500, Kim Phillips wrote:
> Hi Tom,
> 
> Ira improved mpc8308rdb h/w support by making it more comprehensive.
> Please pull:
> 
> The following changes since commit a6f0c4faa4c65a7b7048b12c9d180d7e1aad1721:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-avr32 (2012-09-04 09:17:27 +0200)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-mpc83xx.git master
> 
> for you to fetch changes up to 014d1dfc669ab2295d7fa4ec4b9f00a4004917a0:
> 
>   mpc8308rdb: add support for eSDHC MMC controller (2012-09-17 17:47:12 -0500)
> 
> ----------------------------------------------------------------
> Ira W. Snyder (5):
>       mpc8xxx_spi: fix SPI support on MPC8308RDB
>       mpc8308rdb: add support for Spansion SPI flash on header J8
>       spansion: add support for S25FL256S1
>       mpc8308rdb: add support for FIT images
>       mpc8308rdb: add support for eSDHC MMC controller
> 
>  board/freescale/mpc8308rdb/mpc8308rdb.c | 58 +++++++++++++++++++++++++++++++++
>  drivers/mtd/spi/spansion.c              |  8 +++++
>  drivers/spi/mpc8xxx_spi.c               |  4 +++
>  include/configs/MPC8308RDB.h            | 31 ++++++++++++++++++
>  4 files changed, 101 insertions(+)

A number of boards (P2020RDB-PC_36BIT is the one I looked at the log in)
now fail:
spansion.c:74:3: error: unknown field 'page_size' specified in
initializer

Rejected, please fix, sorry.
Ira Snyder Sept. 18, 2012, 3:09 a.m. UTC | #2 
On Mon, Sep 17, 2012 at 06:18:12PM -0700, Tom Rini wrote:
> On Mon, Sep 17, 2012 at 06:36:56PM -0500, Kim Phillips wrote:
> > Hi Tom,
> > 
> > Ira improved mpc8308rdb h/w support by making it more comprehensive.
> > Please pull:
> > 
> > The following changes since commit a6f0c4faa4c65a7b7048b12c9d180d7e1aad1721:
> > 
> >   Merge branch 'master' of git://git.denx.de/u-boot-avr32 (2012-09-04 09:17:27 +0200)
> > 
> > are available in the git repository at:
> > 
> > 
> >   git://git.denx.de/u-boot-mpc83xx.git master
> > 
> > for you to fetch changes up to 014d1dfc669ab2295d7fa4ec4b9f00a4004917a0:
> > 
> >   mpc8308rdb: add support for eSDHC MMC controller (2012-09-17 17:47:12 -0500)
> > 
> > ----------------------------------------------------------------
> > Ira W. Snyder (5):
> >       mpc8xxx_spi: fix SPI support on MPC8308RDB
> >       mpc8308rdb: add support for Spansion SPI flash on header J8
> >       spansion: add support for S25FL256S1
> >       mpc8308rdb: add support for FIT images
> >       mpc8308rdb: add support for eSDHC MMC controller
> > 
> >  board/freescale/mpc8308rdb/mpc8308rdb.c | 58 +++++++++++++++++++++++++++++++++
> >  drivers/mtd/spi/spansion.c              |  8 +++++
> >  drivers/spi/mpc8xxx_spi.c               |  4 +++
> >  include/configs/MPC8308RDB.h            | 31 ++++++++++++++++++
> >  4 files changed, 101 insertions(+)
> 
> A number of boards (P2020RDB-PC_36BIT is the one I looked at the log in)
> now fail:
> spansion.c:74:3: error: unknown field 'page_size' specified in
> initializer
> 
> Rejected, please fix, sorry.
> 
> -- 
> Tom

Tom,

Go ahead and drop the patch "spansion: add support for S25FL256S1" from
the series. The rest should apply without any trouble.

Michal Simek beat me to it in "sf: spansion: Add support for S25FL256S"
(4a4cb4e1114). He got the idcode1 wrong (it should be 0x0219 instead of
0x2019), but I saw a followup patch on the mailing list to fix it.

Thanks,
Ira
Tom Rini Sept. 18, 2012, 2:57 p.m. UTC | #3 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/17/12 20:09, Ira W. Snyder wrote:
> On Mon, Sep 17, 2012 at 06:18:12PM -0700, Tom Rini wrote:
>> On Mon, Sep 17, 2012 at 06:36:56PM -0500, Kim Phillips wrote:
>>> Hi Tom,
>>> 
>>> Ira improved mpc8308rdb h/w support by making it more
>>> comprehensive. Please pull:
>>> 
>>> The following changes since commit
>>> a6f0c4faa4c65a7b7048b12c9d180d7e1aad1721:
>>> 
>>> Merge branch 'master' of git://git.denx.de/u-boot-avr32
>>> (2012-09-04 09:17:27 +0200)
>>> 
>>> are available in the git repository at:
>>> 
>>> 
>>> git://git.denx.de/u-boot-mpc83xx.git master
>>> 
>>> for you to fetch changes up to
>>> 014d1dfc669ab2295d7fa4ec4b9f00a4004917a0:
>>> 
>>> mpc8308rdb: add support for eSDHC MMC controller (2012-09-17
>>> 17:47:12 -0500)
>>> 
>>> ----------------------------------------------------------------
>>>
>>> 
Ira W. Snyder (5):
>>> mpc8xxx_spi: fix SPI support on MPC8308RDB mpc8308rdb: add
>>> support for Spansion SPI flash on header J8 spansion: add
>>> support for S25FL256S1 mpc8308rdb: add support for FIT images 
>>> mpc8308rdb: add support for eSDHC MMC controller
>>> 
>>> board/freescale/mpc8308rdb/mpc8308rdb.c | 58
>>> +++++++++++++++++++++++++++++++++ drivers/mtd/spi/spansion.c
>>> |  8 +++++ drivers/spi/mpc8xxx_spi.c               |  4 +++ 
>>> include/configs/MPC8308RDB.h            | 31
>>> ++++++++++++++++++ 4 files changed, 101 insertions(+)
>> 
>> A number of boards (P2020RDB-PC_36BIT is the one I looked at the
>> log in) now fail: spansion.c:74:3: error: unknown field
>> 'page_size' specified in initializer
>> 
>> Rejected, please fix, sorry.
>> 
>> -- Tom
> 
> Tom,
> 
> Go ahead and drop the patch "spansion: add support for S25FL256S1"
> from the series. The rest should apply without any trouble.
> 
> Michal Simek beat me to it in "sf: spansion: Add support for
> S25FL256S" (4a4cb4e1114). He got the idcode1 wrong (it should be
> 0x0219 instead of 0x2019), but I saw a followup patch on the
> mailing list to fix it.

This is good to know.  My preference however is for a new pull request
with whatever corrections Kim deems necessary.  Thanks!

- -- 
Tom

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iQIcBAEBAgAGBQJQWIvDAAoJENk4IS6UOR1WJ28P/1Kg3p/mTJdkgDFjKjzKURer
Nv9IGEMYEF5VxA7DY7CVDutCMGeeZIf+/oiU7gsBH0Qk/NxgOmn9GYzr/IDfAuQu
69DKyQ6M0n01yk9C4/w5GjT+cAfrp9oz30Y1hKaq7TOVp79pRDX/CRfxVp/Mk8RL
QkDq/QghCzIhC5VH/JP3544VbpSIKdMkTdOoTrzG7319YYZgvYrvEh0w4vBAnqtK
SB6zaIQZYelVFKsl5EnhcB2WCnwRc6jM23nd+wRycd/VsQanrQsr8xlTo11apvBm
JmXcNUNeVuRgZFpwISuzsaAdxgsUw9TifP2Di854RzG8GoVhUlcvKCV0KWD8Q2WA
5/9O2sl7fKYmAsYCQWrjdpHBjSJZpFOwA3E0K+aohCCPX840i5imOZZWlyOr2VTF
k20dUpcIkmi1c8gaJGkHJzsRYhragY8pWTpIxBN3PFjc/MGSWB8loRseg/rJ2BDi
fb2KAVbcp9j/vF60FDc4LSuSIaIdw3tbsAlC/mk4NLRCqPdFJUYYm0pwyAoZycFK
eFb+73i+vVSUkBThQuJrGW+t9EdVgy8xO2Be7dDjqgAeD166YnQynaicfSfe6Eck
lkE5ExuW3ehUDU7ooEMApYXMKkP+m6YrlGBkoN/ShzLsCHbaBejEDtYJfWp1WYaI
3pTd7PFAQM+CnuAZjLK9
=/6OP
-----END PGP SIGNATURE-----