From patchwork Thu Aug 23 03:12:26 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 179494 X-Patchwork-Delegate: daniel.schwierzeck@googlemail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 88F5E2C0093 for ; Thu, 23 Aug 2012 13:12:36 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id D852F28087; Thu, 23 Aug 2012 05:12:34 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DHid5ju4Qp70; Thu, 23 Aug 2012 05:12:34 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id F192F28081; Thu, 23 Aug 2012 05:12:32 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id BCFA028081 for ; Thu, 23 Aug 2012 05:12:30 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NSGdpmdLcNXl for ; Thu, 23 Aug 2012 05:12:30 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by theia.denx.de (Postfix) with ESMTPS id 0A59128080 for ; Thu, 23 Aug 2012 05:12:28 +0200 (CEST) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 6E4B733DF3C; Thu, 23 Aug 2012 03:12:24 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: "Zhi-zhou Zhang" Date: Wed, 22 Aug 2012 23:12:26 -0400 User-Agent: KMail/1.13.7 (Linux/3.5.0; KDE/4.6.5; x86_64; ; ) References: <1345217476-32034-1-git-send-email-etou.zh@gmail.com> <201208181138.32630.vapier@gentoo.org> In-Reply-To: MIME-Version: 1.0 Message-Id: <201208222312.27832.vapier@gentoo.org> Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [[Patch V2] mips: 01/16] add mips64 standalone support X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de On Saturday 18 August 2012 22:25:24 Zhi-zhou Zhang wrote: > On 8/18/12, Mike Frysinger wrote: > > On Saturday 18 August 2012 08:22:51 Zhi-zhou Zhang wrote: > >> On Sat, Aug 18, 2012 at 3:31 AM, Mike Frysinger wrote: > >> > On Friday 17 August 2012 11:30:44 Zhizhou Zhang wrote: > >> > > --- a/arch/mips/config.mk > >> > > +++ b/arch/mips/config.mk > >> > > > >> > > +ifeq "$(CPU)" "mips64" > >> > > +CONFIG_STANDALONE_LOAD_ADDR ?= 0xFfffFfff80200000 -T mips64.lds > >> > > +else > >> > > CONFIG_STANDALONE_LOAD_ADDR ?= 0x80200000 -T mips.lds > >> > > +endif > >> > > >> > the cpu config.mk is sourced after this one. you could change this > >> > to: CONFIG_STANDALONE_LOAD_ADDR ?= > >> > $(DEFAULT_MIPS_STANDALONE_LOAD_ADDR) > >> > DEFAULT_MIPS_STANDALONE_LOAD_ADDR = 0x80200000 -T mips.lds > >> > > >> > then in the mips64/config.mk: > >> > DEFAULT_MIPS_STANDALONE_LOAD_ADDR = 0xFfffFfff80200000 -T mips64.lds > >> > >> Thanks for you advising. But if I changed like so, I should modify > >> mips32/ > >> config.mk and xburst/config.mk as also. > > > > why ? my suggestion shouldn't affect any other cpu config.mk. > > Oh, I'm so sorry, I think that you mean to replace > CONFIG_STANDALONE_LOAD_ADDR by DEFAULT_MIPS_STANDALONE_LOAD_ADDR. > So your idea is to keep both CONFIG_STANDALONE_LOAD_ADDR and > DEFAULT_MIPS_STANDALONE_LOAD_ADDR, one for mips64, anther for mips32. > Actually I haven't test standalone example. I add standalone config > and build option for I would get an error if didn't do that. It brings > me a lot of mess. I want to disable stanalone support in TOP Makefile, > could I do that? i don't know what you mean. you should be able to do: then in your arch/mips/mips64/config.mk, add this one line: DEFAULT_MIPS_STANDALONE_LOAD_ADDR = 0xFfffFfff80200000 -T mips64.lds does that not work ? -mike --- a/arch/mips/config.mk +++ b/arch/mips/config.mk @@ -23,7 +23,8 @@ CROSS_COMPILE ?= mips_4KC- -CONFIG_STANDALONE_LOAD_ADDR ?= 0x80200000 -T mips.lds +CONFIG_STANDALONE_LOAD_ADDR ?= $(DEFAULT_MIPS_STANDALONE_LOAD_ADDR) +DEFAULT_MIPS_STANDALONE_LOAD_ADDR = 0x80200000 -T mips.lds PLATFORM_CPPFLAGS += -DCONFIG_MIPS -D__MIPS__