diff mbox series

arm64: dts: zynqmp: Fix leds subnode name for zcu100/ultra96 v1

Message ID 1a69c3fa0291f991ffcf113ea222c713ba4d4ff0.1598264917.git.michal.simek@xilinx.com
State New
Delegated to: Michal Simek
Headers show
Series arm64: dts: zynqmp: Fix leds subnode name for zcu100/ultra96 v1 | expand

Commit Message

Michal Simek Aug. 24, 2020, 10:28 a.m. UTC
Fix the leds subnode names to match (^led-[0-9a-f]$|led).

Similar change has been also done by commit 08dc0e5dd9aa ("arm64: dts:
meson: fix leds subnodes name").

The patch is fixing this warning:
avnet-ultra96-rev1.dt.yaml: leds: 'ds2', 'ds3', 'ds4', 'ds5' do not match
any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

vbus-det led is not fixed because it is not LED. It should be likely
handled as gpio hog.
---
 arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Michal Simek Sept. 29, 2020, 11:01 a.m. UTC | #1
po 24. 8. 2020 v 12:28 odesílatel Michal Simek <michal.simek@xilinx.com> napsal:
>
> Fix the leds subnode names to match (^led-[0-9a-f]$|led).
>
> Similar change has been also done by commit 08dc0e5dd9aa ("arm64: dts:
> meson: fix leds subnodes name").
>
> The patch is fixing this warning:
> avnet-ultra96-rev1.dt.yaml: leds: 'ds2', 'ds3', 'ds4', 'ds5' do not match
> any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> vbus-det led is not fixed because it is not LED. It should be likely
> handled as gpio hog.
> ---
>  arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> index d60110ad8367..2352dc553ba7 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> @@ -56,27 +56,27 @@ sw4 {
>
>         leds {
>                 compatible = "gpio-leds";
> -               ds2 {
> +               led-ds2 {
>                         label = "ds2";
>                         gpios = <&gpio 20 GPIO_ACTIVE_HIGH>;
>                         linux,default-trigger = "heartbeat";
>                 };
>
> -               ds3 {
> +               led-ds3 {
>                         label = "ds3";
>                         gpios = <&gpio 19 GPIO_ACTIVE_HIGH>;
>                         linux,default-trigger = "phy0tx"; /* WLAN tx */
>                         default-state = "off";
>                 };
>
> -               ds4 {
> +               led-ds4 {
>                         label = "ds4";
>                         gpios = <&gpio 18 GPIO_ACTIVE_HIGH>;
>                         linux,default-trigger = "phy0rx"; /* WLAN rx */
>                         default-state = "off";
>                 };
>
> -               ds5 {
> +               led-ds5 {
>                         label = "ds5";
>                         gpios = <&gpio 17 GPIO_ACTIVE_HIGH>;
>                         linux,default-trigger = "bluetooth-power";
> --
> 2.28.0
>

Applied.
M
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
index d60110ad8367..2352dc553ba7 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
@@ -56,27 +56,27 @@  sw4 {
 
 	leds {
 		compatible = "gpio-leds";
-		ds2 {
+		led-ds2 {
 			label = "ds2";
 			gpios = <&gpio 20 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "heartbeat";
 		};
 
-		ds3 {
+		led-ds3 {
 			label = "ds3";
 			gpios = <&gpio 19 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "phy0tx"; /* WLAN tx */
 			default-state = "off";
 		};
 
-		ds4 {
+		led-ds4 {
 			label = "ds4";
 			gpios = <&gpio 18 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "phy0rx"; /* WLAN rx */
 			default-state = "off";
 		};
 
-		ds5 {
+		led-ds5 {
 			label = "ds5";
 			gpios = <&gpio 17 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "bluetooth-power";