Message ID | 1610533292-4478-1-git-send-email-martin.fuzzey@flowbird.group |
---|---|
State | Accepted |
Commit | 3f832699ff0be590422ac32e409320d684c25ab9 |
Delegated to: | Stefano Babic |
Headers | show |
Series | w1: mxc: fix build | expand |
On Wed, 13 Jan 2021 at 03:21, Martin Fuzzey <martin.fuzzey@flowbird.group> wrote: > > Now that header files no longer include common.h it must be included > first. > > Otherwise the build fails with errors like > include/asm/arch/clock.h:43:1: error: unknown type name 'u32' > u32 imx_get_uartclk(void); > > Fixes: c3dc39a2f85b ("arm: Don't include common.h in header files") > > Signed-off-by: Martin Fuzzey <martin.fuzzey@flowbird.group> > --- > drivers/w1/mxc_w1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass <sjg@chromium.org>
> Now that header files no longer include common.h it must be included > first. > Otherwise the build fails with errors like > include/asm/arch/clock.h:43:1: error: unknown type name 'u32' > u32 imx_get_uartclk(void); > Fixes: c3dc39a2f85b ("arm: Don't include common.h in header files") > Signed-off-by: Martin Fuzzey <martin.fuzzey@flowbird.group> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic
diff --git a/drivers/w1/mxc_w1.c b/drivers/w1/mxc_w1.c index 8e6372f..3aeaaf5 100644 --- a/drivers/w1/mxc_w1.c +++ b/drivers/w1/mxc_w1.c @@ -17,8 +17,8 @@ * Martin Fuzzey <martin.fuzzey@flowbird.group> */ -#include <asm/arch/clock.h> #include <common.h> +#include <asm/arch/clock.h> #include <dm.h> #include <dm/device_compat.h> #include <linux/bitops.h>
Now that header files no longer include common.h it must be included first. Otherwise the build fails with errors like include/asm/arch/clock.h:43:1: error: unknown type name 'u32' u32 imx_get_uartclk(void); Fixes: c3dc39a2f85b ("arm: Don't include common.h in header files") Signed-off-by: Martin Fuzzey <martin.fuzzey@flowbird.group> --- drivers/w1/mxc_w1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)