From patchwork Tue Sep 15 08:05:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bin Meng X-Patchwork-Id: 1364156 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Jm3mQJhe; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BrG4M3ycXz9sVB for ; Tue, 15 Sep 2020 18:05:23 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D308681BD2; Tue, 15 Sep 2020 10:05:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Jm3mQJhe"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 17F0F81BDF; Tue, 15 Sep 2020 10:05:20 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4AAE381281 for ; Tue, 15 Sep 2020 10:05:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bmeng.cn@gmail.com Received: by mail-pf1-x443.google.com with SMTP id d9so1486715pfd.3 for ; Tue, 15 Sep 2020 01:05:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=JZurbD/DkPW38RP96w5AEJV30kSfDctngi9MILGFhJo=; b=Jm3mQJhecWFaKeL9my8OLq6RdosW4V3aRadpD5S7Tp/hbXHAwA1IVYudSYPhT8gpsE PpEsWjLzTblD90I5jORrduAZlBjeO8EgxDZxziVcChobwKvvImzFC0MBZvOO0cwtvvaL 4xdxoC/zcn0uAmPxneTyDoGsCNLm6aq0BVMNNu67D0CJ28aYjx6bSGjLszhkxoEZdHfx jjTub0Jc+nkuGFBQYdKbmcDW+gDRb/4EDAhRIqvftjJv8srZ9745nRwGlvm4wzitL6Mc 4x+7ia8uYdxTM6CxzY6ecLuLR2wdGiqcIX/WJCbQ2QELo4lO3as39WQ3wY4g4gTlxVcu sGMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=JZurbD/DkPW38RP96w5AEJV30kSfDctngi9MILGFhJo=; b=V9AhxpGA9LQ4V9dbjg4I9Rl9Ux0drPD5mpw21t6WJ+vsl1JW04EpjMkcPdPs/BDq4m WiKqyl8WeFtWpYIDffHeiL7z8VsK+i1G45XeCjkZeHcgSlBSYO6KgT/oN/J5GJ/uUXfM /ee6WBMgaQqBMHEcGZwQG5i3yqY04euOZHzCrsQIGZpGW1nf52S1VxuaQ0Gnk4c9nTNN MJ9Z23EK+xD9LBEm9SkRPr4PXQW8Gj1+c9oZ+zHpUahed/du2jgOlxLC5/UfD39PwNKk mIOWQxIZlSHgxcJRYRd7lB9W7oHzfKTppTc0axyubQ/QoVkspTzPC7eMEiZg3XGufAAw 3MIg== X-Gm-Message-State: AOAM5324Jl6mskiEe7V19VOMK3L/hMe9rKD01QZAvMq/fJzaxN6Xw0wj a6eHd1MxTLNofRvDg0JEpZU= X-Google-Smtp-Source: ABdhPJyY/MkdTGaFbyqL/r3Gxhj4/zO21wIhKZZx3IZ6dY1GaqJsHiDUjqYMqSUIC7YIy0+jTdWvsg== X-Received: by 2002:a62:7c82:0:b029:13c:1611:6525 with SMTP id x124-20020a627c820000b029013c16116525mr17285445pfc.5.1600157115693; Tue, 15 Sep 2020 01:05:15 -0700 (PDT) Received: from pek-vx-bsp2.wrs.com (unknown-146-144.windriver.com. [147.11.146.144]) by smtp.gmail.com with ESMTPSA id mh8sm10897737pjb.32.2020.09.15.01.05.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Sep 2020 01:05:15 -0700 (PDT) From: Bin Meng To: Rick Chen , Pragnesh Patel , U-Boot Mailing List Cc: Bin Meng Subject: [PATCH 1/2] ram: sifive: Check return value on clk_enable() Date: Tue, 15 Sep 2020 16:05:06 +0800 Message-Id: <1600157107-57175-1-git-send-email-bmeng.cn@gmail.com> X-Mailer: git-send-email 2.7.4 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean From: Bin Meng The return value should be checked otherwise it's useless to assign the return value to 'ret'. Signed-off-by: Bin Meng --- drivers/ram/sifive/fu540_ddr.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/ram/sifive/fu540_ddr.c b/drivers/ram/sifive/fu540_ddr.c index 5ff8869..f5b2873 100644 --- a/drivers/ram/sifive/fu540_ddr.c +++ b/drivers/ram/sifive/fu540_ddr.c @@ -369,6 +369,11 @@ static int fu540_ddr_probe(struct udevice *dev) } ret = clk_enable(&priv->ddr_clk); + if (ret < 0) { + debug("Could not enable DDR clock\n"); + return ret; + } + priv->ctl = regmap_get_range(map, 0); priv->phy = regmap_get_range(map, 1); priv->physical_filter_ctrl = regmap_get_range(map, 2);