| Message ID | 1596034301-5428-3-git-send-email-claudiu.beznea@microchip.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Eugen Hristev |
| Headers | show |
| Series | clk: at91: add sama7g5 support | expand |
Hi Claudiu, On Wed, 29 Jul 2020 at 08:51, Claudiu Beznea <claudiu.beznea@microchip.com> wrote: > > Check pointer returned by dev_get_parent(). > > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> > --- > drivers/clk/clk-uclass.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c > index 70df9d410f4c..aa1f11a27c41 100644 > --- a/drivers/clk/clk-uclass.c > +++ b/drivers/clk/clk-uclass.c > @@ -459,6 +459,9 @@ struct clk *clk_get_parent(struct clk *clk) > return NULL; > > pdev = dev_get_parent(clk->dev); > + if (!pdev) > + return ERR_PTR(-ENOMEM); A clock device must always have a parent (e.g. the root device). So this check is not useful and adds to code size. > + > pclk = dev_get_clk_ptr(pdev); > if (!pclk) > return ERR_PTR(-ENODEV); > -- > 2.7.4 > Regards, Simon
On 04.08.2020 05:00, Simon Glass wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Hi Claudiu, > > On Wed, 29 Jul 2020 at 08:51, Claudiu Beznea > <claudiu.beznea@microchip.com> wrote: >> >> Check pointer returned by dev_get_parent(). >> >> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> >> --- >> drivers/clk/clk-uclass.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c >> index 70df9d410f4c..aa1f11a27c41 100644 >> --- a/drivers/clk/clk-uclass.c >> +++ b/drivers/clk/clk-uclass.c >> @@ -459,6 +459,9 @@ struct clk *clk_get_parent(struct clk *clk) >> return NULL; >> >> pdev = dev_get_parent(clk->dev); >> + if (!pdev) >> + return ERR_PTR(-ENOMEM); > > A clock device must always have a parent (e.g. the root device). So > this check is not useful and adds to code size. Sure, I'll remove it. > >> + >> pclk = dev_get_clk_ptr(pdev); >> if (!pclk) >> return ERR_PTR(-ENODEV); >> -- >> 2.7.4 >> > > Regards, > Simon >
diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c index 70df9d410f4c..aa1f11a27c41 100644 --- a/drivers/clk/clk-uclass.c +++ b/drivers/clk/clk-uclass.c @@ -459,6 +459,9 @@ struct clk *clk_get_parent(struct clk *clk) return NULL; pdev = dev_get_parent(clk->dev); + if (!pdev) + return ERR_PTR(-ENOMEM); + pclk = dev_get_clk_ptr(pdev); if (!pclk) return ERR_PTR(-ENODEV);
Check pointer returned by dev_get_parent(). Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> --- drivers/clk/clk-uclass.c | 3 +++ 1 file changed, 3 insertions(+)