| Message ID | 1593509762-6610-1-git-send-email-kuldeep.singh@nxp.com |
|---|---|
| State | Superseded |
| Delegated to: | Priyanka Jain |
| Headers | show |
| Series | configs: ls1012a/ls1046a: Define CONFIG_ENV_OVERWRITE | expand |
>-----Original Message----- >From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Kuldeep Singh >Sent: Tuesday, June 30, 2020 3:06 PM >To: u-boot@lists.denx.de >Cc: Priyanka Jain <priyanka.jain@nxp.com>; Kuldeep Singh ><kuldeep.singh@nxp.com> >Subject: [PATCH] configs: ls1012a/ls1046a: Define CONFIG_ENV_OVERWRITE > >CONFIG_ENV_OVERWRITE disable write protection on various environment >variables like "ethaddr" and "serial". > >Define the config in LS1046A and LS1012A common header as both of them >require this entry. Also, resolve an error while setting multiple values of >"ethaddr" variable. > >Before the change: >=> setenv ethaddr 00:E0:0C:00:06:0 >=> setenv ethaddr 00:E0:0C:00:06:1 >Error: Can't overwrite "ethaddr" >Error inserting "ethaddr" variable, errno=1 > >After the change: >=> setenv ethaddr 00:E0:0C:00:06:0 >=> setenv ethaddr 00:E0:0C:00:06:1 > >Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com> >--- > include/configs/ls1012a_common.h | 2 ++ >include/configs/ls1046a_common.h | 2 ++ > 2 files changed, 4 insertions(+) > >diff --git a/include/configs/ls1012a_common.h >b/include/configs/ls1012a_common.h >index 3bea9a9..b7ad303 100644 >--- a/include/configs/ls1012a_common.h >+++ b/include/configs/ls1012a_common.h >@@ -15,6 +15,8 @@ > > #define CONFIG_SKIP_LOWLEVEL_INIT > >+#define CONFIG_ENV_OVERWRITE >+ > #ifdef CONFIG_TFABOOT > #define CONFIG_SYS_INIT_SP_ADDR CONFIG_SYS_TEXT_BASE > #else >diff --git a/include/configs/ls1046a_common.h >b/include/configs/ls1046a_common.h >index 8fe6937..2fdc2d3 100644 >--- a/include/configs/ls1046a_common.h >+++ b/include/configs/ls1046a_common.h >@@ -42,6 +42,8 @@ > > #define CONFIG_SKIP_LOWLEVEL_INIT > >+#define CONFIG_ENV_OVERWRITE >+ > #define CONFIG_VERY_BIG_RAM > #define CONFIG_SYS_DDR_SDRAM_BASE 0x80000000 > #define CONFIG_SYS_FSL_DDR_SDRAM_BASE_PHY 0 >-- >2.7.4 Can you please check if this change can go into defconfig file, instead of adding here? Regards Priyanka
> -----Original Message----- > From: Priyanka Jain (OSS) <priyanka.jain@oss.nxp.com> > Sent: Tuesday, July 21, 2020 2:49 PM > To: Kuldeep Singh <kuldeep.singh@nxp.com>; u-boot@lists.denx.de > Cc: Kuldeep Singh <kuldeep.singh@nxp.com> > Subject: RE: [PATCH] configs: ls1012a/ls1046a: Define > CONFIG_ENV_OVERWRITE > > >-----Original Message----- > >From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Kuldeep Singh > >Sent: Tuesday, June 30, 2020 3:06 PM > >To: u-boot@lists.denx.de > >Cc: Priyanka Jain <priyanka.jain@nxp.com>; Kuldeep Singh > ><kuldeep.singh@nxp.com> > >Subject: [PATCH] configs: ls1012a/ls1046a: Define > CONFIG_ENV_OVERWRITE > > > >CONFIG_ENV_OVERWRITE disable write protection on various > environment > >variables like "ethaddr" and "serial". > > > >Define the config in LS1046A and LS1012A common header as both of them > >require this entry. Also, resolve an error while setting multiple > >values of "ethaddr" variable. > > > >Before the change: > >=> setenv ethaddr 00:E0:0C:00:06:0 > >=> setenv ethaddr 00:E0:0C:00:06:1 > >Error: Can't overwrite "ethaddr" > >Error inserting "ethaddr" variable, errno=1 > > > >After the change: > >=> setenv ethaddr 00:E0:0C:00:06:0 > >=> setenv ethaddr 00:E0:0C:00:06:1 > > > >Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com> > >--- > > include/configs/ls1012a_common.h | 2 ++ > >include/configs/ls1046a_common.h | 2 ++ > > 2 files changed, 4 insertions(+) > > > >diff --git a/include/configs/ls1012a_common.h > >b/include/configs/ls1012a_common.h > >index 3bea9a9..b7ad303 100644 > >--- a/include/configs/ls1012a_common.h > >+++ b/include/configs/ls1012a_common.h > >@@ -15,6 +15,8 @@ > > > > #define CONFIG_SKIP_LOWLEVEL_INIT > > > >+#define CONFIG_ENV_OVERWRITE > >+ > > #ifdef CONFIG_TFABOOT > > #define CONFIG_SYS_INIT_SP_ADDR CONFIG_SYS_TEXT_BASE > > #else > >diff --git a/include/configs/ls1046a_common.h > >b/include/configs/ls1046a_common.h > >index 8fe6937..2fdc2d3 100644 > >--- a/include/configs/ls1046a_common.h > >+++ b/include/configs/ls1046a_common.h > >@@ -42,6 +42,8 @@ > > > > #define CONFIG_SKIP_LOWLEVEL_INIT > > > >+#define CONFIG_ENV_OVERWRITE > >+ > > #define CONFIG_VERY_BIG_RAM > > #define CONFIG_SYS_DDR_SDRAM_BASE 0x80000000 > > #define CONFIG_SYS_FSL_DDR_SDRAM_BASE_PHY 0 > >-- > >2.7.4 > Can you please check if this change can go into defconfig file, instead of > adding here? This will require conversion of CONFIG_ENV_OVERWRITE to Kconfig option to add and entry in defconfig. -Kuldeep
> > Can you please check if this change can go into defconfig file, > > instead of adding here? > > This will require conversion of CONFIG_ENV_OVERWRITE to Kconfig option > to add and entry in defconfig. With little search, I found Adam Ford's patch[1] which convert CONFIG_ENV_OVERWRITE to Kconfig option. I can make my changes on top of this patch. Please let me know your views. -Kuldeep [1] https://patchwork.ozlabs.org/project/uboot/patch/20200703114856.1225522-1-aford173@gmail.com/
diff --git a/include/configs/ls1012a_common.h b/include/configs/ls1012a_common.h index 3bea9a9..b7ad303 100644 --- a/include/configs/ls1012a_common.h +++ b/include/configs/ls1012a_common.h @@ -15,6 +15,8 @@ #define CONFIG_SKIP_LOWLEVEL_INIT +#define CONFIG_ENV_OVERWRITE + #ifdef CONFIG_TFABOOT #define CONFIG_SYS_INIT_SP_ADDR CONFIG_SYS_TEXT_BASE #else diff --git a/include/configs/ls1046a_common.h b/include/configs/ls1046a_common.h index 8fe6937..2fdc2d3 100644 --- a/include/configs/ls1046a_common.h +++ b/include/configs/ls1046a_common.h @@ -42,6 +42,8 @@ #define CONFIG_SKIP_LOWLEVEL_INIT +#define CONFIG_ENV_OVERWRITE + #define CONFIG_VERY_BIG_RAM #define CONFIG_SYS_DDR_SDRAM_BASE 0x80000000 #define CONFIG_SYS_FSL_DDR_SDRAM_BASE_PHY 0
CONFIG_ENV_OVERWRITE disable write protection on various environment variables like "ethaddr" and "serial". Define the config in LS1046A and LS1012A common header as both of them require this entry. Also, resolve an error while setting multiple values of "ethaddr" variable. Before the change: => setenv ethaddr 00:E0:0C:00:06:0 => setenv ethaddr 00:E0:0C:00:06:1 Error: Can't overwrite "ethaddr" Error inserting "ethaddr" variable, errno=1 After the change: => setenv ethaddr 00:E0:0C:00:06:0 => setenv ethaddr 00:E0:0C:00:06:1 Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com> --- include/configs/ls1012a_common.h | 2 ++ include/configs/ls1046a_common.h | 2 ++ 2 files changed, 4 insertions(+)