From patchwork Tue May 26 17:09:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sagar Shrikant Kadam X-Patchwork-Id: 1298224 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=selector1 header.b=XYYBCwuZ; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49WgSZ0gpgz9sRK for ; Wed, 27 May 2020 03:10:06 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 969AE81CB0; Tue, 26 May 2020 19:09:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.b="XYYBCwuZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A2B83818E7; Tue, 26 May 2020 19:09:38 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20627.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eae::627]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 44AE981C56 for ; Tue, 26 May 2020 19:09:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sagar.kadam@sifive.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jVepsJNFByiVstxKnvcjglq5jkOuEUtctjTTqtfsmjFM0FJ2h6Yapds2wndNFPFazuuQNFfvp9HENMdBU6wPOUmzutZXcM0K4ft9HcAGugqUzQjwUknXqAGZjA2KW5nr437+YeEWM2ddbcP+09wvNGypeqIkRmb9XlSU0kZxaZU1wUGVHh5USJx77+KF+V1ryrFEIev/45p5vvz7wqejxWQ6edlqpBvVpzATvTHtJFOY9Qwb9v2m8PrO8ODuVLoYwxkpc8/NBb0w8fGS8CDsxbAyZbXHtV7Iaus4JDz5eZdoz35lgI/2HIGUGL/S2cQFzc7/8HTiij5CjzNdL3bnqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EHTrIZlPrMFnr/V9WrH/jJRmbMo65nwpJBIayhVVP58=; b=fNcrH6wCtZaTTUviLAjUC+g8XKO0ZyypqSRVSMgmt2yWzWYhtNxzns4d/zsth3Mfh5Qst3LBeSh7I5Mb43hJcStbAwP+D7eMEJYd0aMJfHA5ILZxyfUJ1IVR7qkxqtz9NnT2HvNzx0qngf+dnNT9NHblLh9e7qsHJ1928hZWShGnGt2EAcrpwDcfZf1UAh3/F7dApslDW8Lxsp/5jgjn/TYtaPEsBoa9277MycJ8fwjdJEgudEyn55mdz7nNhDvBwRWaDvNf/U4dgyTG+vj1zlqyEokNeH7hCcB35Z1dMCPYlDUIHhH0YJdJ0jXiY+T/+1RpEi4TZPfHepFLclvHcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sifive.com; dmarc=pass action=none header.from=sifive.com; dkim=pass header.d=sifive.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EHTrIZlPrMFnr/V9WrH/jJRmbMo65nwpJBIayhVVP58=; b=XYYBCwuZOmnuZR1ZTfUbODuklUOTKuiQXPtMc+gi2tG3gryPhUGZJ4pZWRmMXmmE6StO+Csclm3pue+0fQ+UMC7h94ona3g9CmtPWvWY3DBFxkyr8VjBCk8N+hQqYw+Q6OSrLXO7gQ0pnHzpw5YMHTXmm6nCJohgHFtceFjbQJ8= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=sifive.com; Received: from BN8PR13MB2611.namprd13.prod.outlook.com (2603:10b6:408:81::17) by BN8PR13MB2897.namprd13.prod.outlook.com (2603:10b6:408:8a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.15; Tue, 26 May 2020 17:09:31 +0000 Received: from BN8PR13MB2611.namprd13.prod.outlook.com ([fe80::c1d9:f4ee:80ab:de83]) by BN8PR13MB2611.namprd13.prod.outlook.com ([fe80::c1d9:f4ee:80ab:de83%6]) with mapi id 15.20.3045.014; Tue, 26 May 2020 17:09:31 +0000 From: Sagar Shrikant Kadam To: u-boot@lists.denx.de, rick@andestech.com, lukma@denx.de Cc: jagan@amarulasolutions.com, bmeng.cn@gmail.com, pragnesh.patel@sifive.com, seanga2@gmail.com, Sagar Shrikant Kadam Subject: [PATCH v2 3/4] riscv: cpu: fixes to display proper CPU features Date: Tue, 26 May 2020 10:09:10 -0700 Message-Id: <1590512951-1045-4-git-send-email-sagar.kadam@sifive.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1590512951-1045-1-git-send-email-sagar.kadam@sifive.com> References: <1590512951-1045-1-git-send-email-sagar.kadam@sifive.com> X-ClientProxiedBy: BYAPR01CA0054.prod.exchangelabs.com (2603:10b6:a03:94::31) To BN8PR13MB2611.namprd13.prod.outlook.com (2603:10b6:408:81::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from gamma07.internal.sifive.com (64.62.193.194) by BYAPR01CA0054.prod.exchangelabs.com (2603:10b6:a03:94::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3021.23 via Frontend Transport; Tue, 26 May 2020 17:09:30 +0000 X-Mailer: git-send-email 2.7.4 X-Originating-IP: [64.62.193.194] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4e07d711-9f15-4116-f02d-08d801978e15 X-MS-TrafficTypeDiagnostic: BN8PR13MB2897: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-Forefront-PRVS: 041517DFAB X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UDwK9ISoDiBYpQU+dyw/Yma9gjkdDy6Wx5xXU0AYjSMnSfqyjCKrAbl8RhE6IrwKX6lGvLJh6odMJZDpNgxbZfcynYVrz9viBazxZl2xlzAodmX4ZgMljEkcPETEtobZztxfLhDir10QuHh6fcKBNEIQ8bVLyqoVyNRSDCGVb8d6AeWqIkAbdZIX5C2EpP9HDQg/S8jiJSIE6SvClWLw02oQftq6+eUqMJ/YyCFiA3nDAzxXSgzpXOcWncbfN7WWEj14Lk3BosPLzCm0bgKIeE1oluechkRBaynvtPZMXE7DJ8OVSaOK9a1tjSQ8/HKmgFw2idxnpsOcMrk8umnYUw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR13MB2611.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(346002)(376002)(136003)(396003)(39840400004)(8936002)(8676002)(36756003)(2616005)(66556008)(6666004)(86362001)(66476007)(956004)(52116002)(26005)(186003)(7696005)(16526019)(66946007)(6486002)(107886003)(316002)(4326008)(2906002)(478600001)(5660300002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: zNIUIXkRpAO6GC++yd0EuRuR1FX/ahY8rnTS4arswiuE8yhr0nmxq0gePFNTD/1/vzwW/krl+JXPjp4Qdgttn3n2Vk50oATbFdgjDJOg+mnPn55uo8xqSHzVAYP9vJNrtO4H47Br//fVtB6MWxMvKYurxH2cvOi+Rl5/7st4SqVP+EH4zAYqwMv8/GAfjh5Q8IV6PFkJUOi2Yg5k1S1Mgxb6MyExF7dQhrlM9ounYvT2BZJImASijGFePSN5IFLjZ0+1V5L+i5UE5ZoeozpQWAQvYw6Uc+YzUGOUgFeCnu7AgiQJ/g3GmLPl9eT8P+aXlv4JFx5TDt3QRgQOhtj2DmthuBRryPlU1bgdv4vmru08Edk5XjvmxFhbgdcTvGuSNPbg2oxUCZU+TscjJmMIhWAAa8Mq5+i5LdtLFuvCcHd2204durWYdcOnC7NmcvhxJJ3J/X1WFb7XGXxakRbqnqNVKxMh6FQ7rPvElcja/2s= X-OriginatorOrg: sifive.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e07d711-9f15-4116-f02d-08d801978e15 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2020 17:09:31.1585 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BRsEqji0NZAs3LS2a5Xmkg5mXSbSSYLodNGNVtpdKqnnemHwlvV7UvscvkGX/NoXfNmdprENrkE4UZAvZQHpng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR13MB2897 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean The cmd "cpu detail" fetches uninitialized cpu feature information and thus displays wrong / inconsitent details as below. FU540-C000 doesn't have any microcode, yet the cmd display's it. => cpu detail 0: cpu@0 rv64imac ID = 0, freq = 999.100 MHz: L1 cache, MMU, Microcode, Device ID Microcode version 0x0 Device ID 0x0 1: cpu@1 rv64imafdc ID = 1, freq = 999.100 MHz: L1 cache, MMU, Microcode, Device ID Microcode version 0x0 Device ID 0x0 2: cpu@2 rv64imafdc ID = 2, freq = 999.100 MHz: L1 cache, MMU, Microcode, Device ID Microcode version 0x0 Device ID 0x0 3: cpu@3 rv64imafdc ID = 3, freq = 999.100 MHz: L1 cache, MMU, Microcode, Device ID Microcode version 0x0 Device ID 0x0 4: cpu@4 rv64imafdc ID = 4, freq = 999.100 MHz: L1 cache, MMU, Microcode, Device ID Microcode version 0x0 Device ID 0x0 The L1 cache or MMU entry seen above is also displayed inconsistently. So initialize features to zero before fetching from device tree. Additionally the conditional check to read "mmu-type" from device tree is not rightly handled due to which the cpu feature doesn't include CPU_FEAT_MMU even if it's corresponding entry is present in device tree. We now see correct features as: => cpu detail 0: cpu@0 rv64imac ID = 0, freq = 999.100 MHz 1: cpu@1 rv64imafdc ID = 1, freq = 999.100 MHz: MMU 2: cpu@2 rv64imafdc ID = 2, freq = 999.100 MHz: MMU 3: cpu@3 rv64imafdc ID = 3, freq = 999.100 MHz: MMU 4: cpu@4 rv64imafdc ID = 4, freq = 999.100 MHz: MMU Signed-off-by: Sagar Shrikant Kadam Reviewed-by: Pragnesh Patel --- drivers/cpu/riscv_cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/cpu/riscv_cpu.c b/drivers/cpu/riscv_cpu.c index 76b0489..8c4b5e7 100644 --- a/drivers/cpu/riscv_cpu.c +++ b/drivers/cpu/riscv_cpu.c @@ -38,6 +38,8 @@ static int riscv_cpu_get_info(struct udevice *dev, struct cpu_info *info) /* Zero out the frequency, in case sizeof(ulong) != sizeof(u32) */ info->cpu_freq = 0; + /* Initialise cpu features before updating from device tree */ + info->features = 0; /* First try getting the frequency from the assigned clock */ ret = clk_get_by_index(dev, 0, &clk); @@ -52,7 +54,7 @@ static int riscv_cpu_get_info(struct udevice *dev, struct cpu_info *info) dev_read_u32(dev, "clock-frequency", (u32 *)&info->cpu_freq); mmu = dev_read_string(dev, "mmu-type"); - if (!mmu) + if (mmu) info->features |= BIT(CPU_FEAT_MMU); return 0;