From patchwork Wed Jul 10 10:23:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ye Li X-Patchwork-Id: 1130322 X-Patchwork-Delegate: hs@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="c5mnqWwu"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 45kFdL3pVXz9sBF for ; Wed, 10 Jul 2019 20:23:18 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 34F17C21E2B; Wed, 10 Jul 2019 10:23:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 75744C21D8A; Wed, 10 Jul 2019 10:23:12 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id E032AC21D8A; Wed, 10 Jul 2019 10:23:10 +0000 (UTC) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50088.outbound.protection.outlook.com [40.107.5.88]) by lists.denx.de (Postfix) with ESMTPS id 63CCDC21D56 for ; Wed, 10 Jul 2019 10:23:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QE7z8VgE3QF9d5RrHedNC10gkn2mzp7R1ZGFHKM4i2I=; b=c5mnqWwuvrh0CaANHWRm8rCnZD0jiQnqZsqmEzKH5tZSWw9+m/Adiz7/HW8F/BPcBFmjwSmYTORE2A8vZObccjJX+cp2d/wn233yV2MEOAr1CWX7tz4Mf+xjS55dfxzS21slOl5HpGBc4uJKrWvTOWzoOX82D0wkP9pCMVRm+1Y= Received: from VI1PR04MB4414.eurprd04.prod.outlook.com (20.177.55.153) by VI1PR04MB4816.eurprd04.prod.outlook.com (20.177.48.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.18; Wed, 10 Jul 2019 10:23:09 +0000 Received: from VI1PR04MB4414.eurprd04.prod.outlook.com ([fe80::6517:7774:1033:6466]) by VI1PR04MB4414.eurprd04.prod.outlook.com ([fe80::6517:7774:1033:6466%7]) with mapi id 15.20.2052.020; Wed, 10 Jul 2019 10:23:09 +0000 From: Ye Li To: "hs@denx.de" , Peng Fan Thread-Topic: [PATCH 1/2] i2c-mux-gpio: Fix GPIO request flag issue Thread-Index: AQHVNwl4uXnJo/Uqf0GuS2W4o8DKEw== Date: Wed, 10 Jul 2019 10:23:09 +0000 Message-ID: <1562754169-45024-1-git-send-email-ye.li@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK2PR06CA0017.apcprd06.prod.outlook.com (2603:1096:202:2e::29) To VI1PR04MB4414.eurprd04.prod.outlook.com (2603:10a6:803:6e::25) authentication-results: spf=none (sender IP is ) smtp.mailfrom=ye.li@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.68] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4efe14ad-1a1f-4f39-9aaf-08d705209aac x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VI1PR04MB4816; x-ms-traffictypediagnostic: VI1PR04MB4816: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-forefront-prvs: 0094E3478A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(136003)(346002)(39860400002)(396003)(376002)(199004)(189003)(53936002)(4744005)(86362001)(186003)(66946007)(99286004)(66476007)(66556008)(64756008)(66446008)(6506007)(386003)(102836004)(26005)(2906002)(14444005)(14454004)(256004)(54906003)(110136005)(316002)(2501003)(52116002)(71190400001)(478600001)(3846002)(6116002)(68736007)(5660300002)(8936002)(476003)(8676002)(6512007)(25786009)(81166006)(4326008)(81156014)(305945005)(7736002)(6636002)(66066001)(486006)(6436002)(36756003)(44832011)(71200400001)(6486002)(50226002)(2616005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB4816; H:VI1PR04MB4414.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: x0dLrMhvYwn2frPE3bB0nney3DuzXAOo2fArf27XuTyRlh+3AHkJwpMliR74o9z+z+lXgrS68GBLqSyYhaaVRdwotlh+52G+dpPUyHghpyAysF5hUE9M5wI6hZ2OLcLhgzvugRaP9Husfk4RHOJV00h1O5HR/vGzrVsXX9MGmWdLjt8ccbzmnpF5JNX7ouFUztfYKHPYsLfgF5eZ4UlmPGOae0ozw66nNoErDJuXeqey565xsM2/8RrURguiIpVHHp0UhS5gVdBRsB9dsB5YAoqR3bDWCZNdCuiBWr/yZd5PKlHmGw/BRbW8qSrq0zGNcD+2jxrv2Bb3beuE6mDlcrOdca0+P9sL7wrs1Wh+rKn4ZeRVWJi+l1IagHxhEqzCkHFrPUQWojn7ZCfc77YZ2T+eoSVkX5Jd5EIh+jq6R2U= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4efe14ad-1a1f-4f39-9aaf-08d705209aac X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2019 10:23:09.2307 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ye.li@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4816 Cc: "u-boot@lists.denx.de" , dl-uboot-imx Subject: [U-Boot] [PATCH 1/2] i2c-mux-gpio: Fix GPIO request flag issue X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" When requesting GPIO, the GPIOD_IS_OUT is missed in flag, so the GPIO is set the input mode not output and cause mux not work. Signed-off-by: Ye Li --- drivers/i2c/muxes/i2c-mux-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c index 28f6400..e8b124f 100644 --- a/drivers/i2c/muxes/i2c-mux-gpio.c +++ b/drivers/i2c/muxes/i2c-mux-gpio.c @@ -106,7 +106,7 @@ static int i2c_mux_gpio_probe(struct udevice *dev) } ret = gpio_request_list_by_name(dev, "mux-gpios", gpios, mux->n_gpios, - GPIOD_IS_OUT_ACTIVE); + GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE); if (ret <= 0) { dev_err(dev, "Failed to request mux-gpios\n"); return ret;