diff mbox series

[U-Boot,06/16] usb: dwc2: remove unused variable regs_otg

Message ID 1553870544-15734-7-git-send-email-patrick.delaunay@st.com
State Accepted
Commit a812d77617749eeaddfa8b9796b9a2eece1ad2f5
Delegated to: Lukasz Majewski
Headers show
Series usb: convert dwc2 gadget to driver model, used in stm32mp1 | expand

Commit Message

Patrick DELAUNAY March 29, 2019, 2:42 p.m. UTC
Remove the global regs_otg variable.

Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
---

 drivers/usb/gadget/dwc2_udc_otg.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Lukasz Majewski April 8, 2019, 9:54 p.m. UTC | #1
On Fri, 29 Mar 2019 15:42:14 +0100
Patrick Delaunay <patrick.delaunay@st.com> wrote:

> Remove the global regs_otg variable.
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
> 
>  drivers/usb/gadget/dwc2_udc_otg.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/usb/gadget/dwc2_udc_otg.c
> b/drivers/usb/gadget/dwc2_udc_otg.c index 3c7ad03..edca05d 100644
> --- a/drivers/usb/gadget/dwc2_udc_otg.c
> +++ b/drivers/usb/gadget/dwc2_udc_otg.c
> @@ -140,7 +140,6 @@ static struct usb_ep_ops dwc2_ep_ops = {
>  
>  /***********************************************************/
>  
> -void __iomem		*regs_otg;
>  struct dwc2_usbotg_reg *reg;
>  
>  bool dfu_usb_get_reset(void)
> @@ -818,8 +817,6 @@ int dwc2_udc_probe(struct dwc2_plat_otg_data
> *pdata) 
>  	reg = (struct dwc2_usbotg_reg *)pdata->regs_otg;
>  
> -	/* regs_otg = (void *)pdata->regs_otg; */
> -
>  	dev->gadget.is_dualspeed = 1;	/* Hack only*/
>  	dev->gadget.is_otg = 0;
>  	dev->gadget.is_a_peripheral = 0;

Reviewed-by: Lukasz Majewski <lukma@denx.de>


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
diff mbox series

Patch

diff --git a/drivers/usb/gadget/dwc2_udc_otg.c b/drivers/usb/gadget/dwc2_udc_otg.c
index 3c7ad03..edca05d 100644
--- a/drivers/usb/gadget/dwc2_udc_otg.c
+++ b/drivers/usb/gadget/dwc2_udc_otg.c
@@ -140,7 +140,6 @@  static struct usb_ep_ops dwc2_ep_ops = {
 
 /***********************************************************/
 
-void __iomem		*regs_otg;
 struct dwc2_usbotg_reg *reg;
 
 bool dfu_usb_get_reset(void)
@@ -818,8 +817,6 @@  int dwc2_udc_probe(struct dwc2_plat_otg_data *pdata)
 
 	reg = (struct dwc2_usbotg_reg *)pdata->regs_otg;
 
-	/* regs_otg = (void *)pdata->regs_otg; */
-
 	dev->gadget.is_dualspeed = 1;	/* Hack only*/
 	dev->gadget.is_otg = 0;
 	dev->gadget.is_a_peripheral = 0;