| Message ID | 1550217427-3847-1-git-send-email-tien.fong.chee@intel.com |
|---|---|
| State | Accepted |
| Commit | 3003c445b3cb1d1ca7e2304bfa3e2faf2ae02f80 |
| Delegated to: | Michal Simek |
| Headers | show |
| Series | [U-Boot] fpga: Replace char * with const char * for filename | expand |
On 15. 02. 19 8:57, tien.fong.chee@intel.com wrote: > From: Tien Fong Chee <tien.fong.chee@intel.com> > > Ensure the string for filename is always constant, otherwise it can be > corrupted by the writing. Have you reach any issue with it? > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com> > --- > drivers/fpga/zynqpl.c | 3 ++- > include/fpga.h | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/fpga/zynqpl.c b/drivers/fpga/zynqpl.c > index 499310d..683cf14 100644 > --- a/drivers/fpga/zynqpl.c > +++ b/drivers/fpga/zynqpl.c > @@ -421,7 +421,8 @@ static int zynq_loadfs(xilinx_desc *desc, const void *buf, size_t bsize, > loff_t blocksize, actread; > loff_t pos = 0; > int fstype; > - char *interface, *dev_part, *filename; > + char *interface, *dev_part; > + const char *filename; > > blocksize = fsinfo->blocksize; > interface = fsinfo->interface; > diff --git a/include/fpga.h b/include/fpga.h > index 195f0bd..51de5c5 100644 > --- a/include/fpga.h > +++ b/include/fpga.h > @@ -41,7 +41,7 @@ typedef struct { /* typedef fpga_desc */ > unsigned int blocksize; > char *interface; > char *dev_part; > - char *filename; > + const char *filename; > int fstype; > } fpga_fs_info; > > Anyway looks good applied. Thanks, Michal
On Mon, 2019-02-18 at 13:27 +0100, Michal Simek wrote: > On 15. 02. 19 8:57, tien.fong.chee@intel.com wrote: > > > > From: Tien Fong Chee <tien.fong.chee@intel.com> > > > > Ensure the string for filename is always constant, otherwise it can > > be > > corrupted by the writing. > Have you reach any issue with it? Just to resolve the compiler warning about missing of const. > > > > > > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com> > > --- > > drivers/fpga/zynqpl.c | 3 ++- > > include/fpga.h | 2 +- > > 2 files changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/fpga/zynqpl.c b/drivers/fpga/zynqpl.c > > index 499310d..683cf14 100644 > > --- a/drivers/fpga/zynqpl.c > > +++ b/drivers/fpga/zynqpl.c > > @@ -421,7 +421,8 @@ static int zynq_loadfs(xilinx_desc *desc, const > > void *buf, size_t bsize, > > loff_t blocksize, actread; > > loff_t pos = 0; > > int fstype; > > - char *interface, *dev_part, *filename; > > + char *interface, *dev_part; > > + const char *filename; > > > > blocksize = fsinfo->blocksize; > > interface = fsinfo->interface; > > diff --git a/include/fpga.h b/include/fpga.h > > index 195f0bd..51de5c5 100644 > > --- a/include/fpga.h > > +++ b/include/fpga.h > > @@ -41,7 +41,7 @@ typedef struct { /* typedef > > fpga_desc */ > > unsigned int blocksize; > > char *interface; > > char *dev_part; > > - char *filename; > > + const char *filename; > > int fstype; > > } fpga_fs_info; > > > > > Anyway looks good applied. > > Thanks, > Michal
On 20. 02. 19 13:03, Chee, Tien Fong wrote: > On Mon, 2019-02-18 at 13:27 +0100, Michal Simek wrote: >> On 15. 02. 19 8:57, tien.fong.chee@intel.com wrote: >>> >>> From: Tien Fong Chee <tien.fong.chee@intel.com> >>> >>> Ensure the string for filename is always constant, otherwise it can >>> be >>> corrupted by the writing. >> Have you reach any issue with it? > Just to resolve the compiler warning about missing of const. ok. Thanks, Michal
diff --git a/drivers/fpga/zynqpl.c b/drivers/fpga/zynqpl.c index 499310d..683cf14 100644 --- a/drivers/fpga/zynqpl.c +++ b/drivers/fpga/zynqpl.c @@ -421,7 +421,8 @@ static int zynq_loadfs(xilinx_desc *desc, const void *buf, size_t bsize, loff_t blocksize, actread; loff_t pos = 0; int fstype; - char *interface, *dev_part, *filename; + char *interface, *dev_part; + const char *filename; blocksize = fsinfo->blocksize; interface = fsinfo->interface; diff --git a/include/fpga.h b/include/fpga.h index 195f0bd..51de5c5 100644 --- a/include/fpga.h +++ b/include/fpga.h @@ -41,7 +41,7 @@ typedef struct { /* typedef fpga_desc */ unsigned int blocksize; char *interface; char *dev_part; - char *filename; + const char *filename; int fstype; } fpga_fs_info;