diff mbox series

[U-Boot] arm,imx6: add alternative PAD_CTL_DSE constants

Message ID 1530094898-24900-1-git-send-email-mark.jonas@de.bosch.com
State Superseded
Delegated to: Stefano Babic
Headers show
Series [U-Boot] arm,imx6: add alternative PAD_CTL_DSE constants | expand

Commit Message

Jonas Mark (BT-FIR/ENG1-Grb) June 27, 2018, 10:21 a.m. UTC 
Not all i.MX6 pads use the same drive strength table. So far only the
240 Ohm to 34 Ohm table was available. Because the constants used have
speaking names it can be confusing to use e.g. PAD_CTL_DSE_48ohm when
according to the reference manual 52 Ohm is the correct value. This
patch adds the 260 Ohm to 37 Ohm table.

For example, the IOMUXC_SW_PAD_CTL_PAD_SD2_CLK register (SD-card clock)
uses the added table.
---
 arch/arm/include/asm/mach-imx/iomux-v3.h | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Fabio Estevam June 27, 2018, 11:47 p.m. UTC | #1 
Hi Mark,

On Wed, Jun 27, 2018 at 7:21 AM, Mark Jonas <mark.jonas@de.bosch.com> wrote:
> Not all i.MX6 pads use the same drive strength table. So far only the
> 240 Ohm to 34 Ohm table was available. Because the constants used have
> speaking names it can be confusing to use e.g. PAD_CTL_DSE_48ohm when
> according to the reference manual 52 Ohm is the correct value. This
> patch adds the 260 Ohm to 37 Ohm table.
>
> For example, the IOMUXC_SW_PAD_CTL_PAD_SD2_CLK register (SD-card clock)
> uses the added table.

The change looks good, but you missed your Signed-off-by tag.
diff mbox series

Patch

diff --git a/arch/arm/include/asm/mach-imx/iomux-v3.h b/arch/arm/include/asm/mach-imx/iomux-v3.h
index bb93058..63f4b33 100644
--- a/arch/arm/include/asm/mach-imx/iomux-v3.h
+++ b/arch/arm/include/asm/mach-imx/iomux-v3.h
@@ -163,6 +163,14 @@  typedef u64 iomux_v3_cfg_t;
 #define PAD_CTL_DSE_40ohm	(6 << 3)
 #define PAD_CTL_DSE_34ohm	(7 << 3)
 
+#define PAD_CTL_DSE_260ohm	(1 << 3)
+#define PAD_CTL_DSE_130ohm	(2 << 3)
+#define PAD_CTL_DSE_88ohm	(3 << 3)
+#define PAD_CTL_DSE_65ohm	(4 << 3)
+#define PAD_CTL_DSE_52ohm	(5 << 3)
+#define PAD_CTL_DSE_43ohm	(6 << 3)
+#define PAD_CTL_DSE_37ohm	(7 << 3)
+
 /* i.MX6SL/SLL */
 #define PAD_CTL_LVE		(1 << 1)
 #define PAD_CTL_LVE_BIT		(1 << 22)