| Message ID | 1529623261-24672-2-git-send-email-andrew.thomas@oracle.com |
|---|---|
| State | Accepted |
| Commit | f25ddca16c96f13c3f7cf7968566d1ff03917012 |
| Delegated to: | Joe Hershberger |
| Headers | show |
| Series | initialize net_mode.if_type | expand |
On Thu, Jun 21, 2018 at 6:21 PM, Andrew Thomas <andrew.thomas@oracle.com> wrote: > if_type is not correctly initialized > > Failure to initialize if_type means that grub2/efinet sends > a bogus arp request. It therefore gets no response. On Raspberry Pi 3B+ > this leads to a pause at: > > lan78xx_eth Waiting for PHY auto negotiation to complete....... done > lan78xx_eth Waiting for PHY auto negotiation to complete....... done > > Signed-off-by: Andrew Thomas <andrew.thomas@oracle.com> In the future, please Cc me (network maintainer). Acked-by: Joe Hershberger <joe.hershberger@ni.com> > --- > lib/efi_loader/efi_net.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/efi_loader/efi_net.c b/lib/efi_loader/efi_net.c > index e113950..5a3d7be 100644 > --- a/lib/efi_loader/efi_net.c > +++ b/lib/efi_loader/efi_net.c > @@ -361,6 +361,7 @@ efi_status_t efi_net_register(void) > memcpy(netobj->net_mode.current_address.mac_addr, eth_get_ethaddr(), 6); > netobj->net_mode.hwaddr_size = ARP_HLEN; > netobj->net_mode.max_packet_size = PKTSIZE; > + netobj->net_mode.if_type = ARP_ETHER; > > netobj->pxe.mode = &netobj->pxe_mode; > if (dhcp_ack) > -- > 1.8.3.1 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot
Hi andrew, https://patchwork.ozlabs.org/patch/932997/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git Thanks! -Joe
diff --git a/lib/efi_loader/efi_net.c b/lib/efi_loader/efi_net.c index e113950..5a3d7be 100644 --- a/lib/efi_loader/efi_net.c +++ b/lib/efi_loader/efi_net.c @@ -361,6 +361,7 @@ efi_status_t efi_net_register(void) memcpy(netobj->net_mode.current_address.mac_addr, eth_get_ethaddr(), 6); netobj->net_mode.hwaddr_size = ARP_HLEN; netobj->net_mode.max_packet_size = PKTSIZE; + netobj->net_mode.if_type = ARP_ETHER; netobj->pxe.mode = &netobj->pxe_mode; if (dhcp_ack)
if_type is not correctly initialized Failure to initialize if_type means that grub2/efinet sends a bogus arp request. It therefore gets no response. On Raspberry Pi 3B+ this leads to a pause at: lan78xx_eth Waiting for PHY auto negotiation to complete....... done lan78xx_eth Waiting for PHY auto negotiation to complete....... done Signed-off-by: Andrew Thomas <andrew.thomas@oracle.com> --- lib/efi_loader/efi_net.c | 1 + 1 file changed, 1 insertion(+)