From patchwork Mon Apr 30 08:32:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Kiernan X-Patchwork-Id: 906553 X-Patchwork-Delegate: lukma@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kcbU4ZeB"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 40ZHyW5RDVz9s06 for ; Mon, 30 Apr 2018 18:39:15 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 595DCC21F20; Mon, 30 Apr 2018 08:37:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id EBC5BC21F6E; Mon, 30 Apr 2018 08:34:05 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 395D9C21F1C; Mon, 30 Apr 2018 08:34:00 +0000 (UTC) Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by lists.denx.de (Postfix) with ESMTPS id 4F81DC21E1D for ; Mon, 30 Apr 2018 08:33:52 +0000 (UTC) Received: by mail-wm0-f67.google.com with SMTP id t11so11756637wmt.0 for ; Mon, 30 Apr 2018 01:33:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=l+s9+Jk8HrmBBbDyZWsezOC2KHIOu1EFQvBqPXfwSnY=; b=kcbU4ZeBQp7/fiCbYHuHftLjk/Sn2SOgzXWSz2giYrBVXYIuhT6VU/KYES695kEEGi J3U6smxWsUdLrP24GJziCwvkZBZuMU+W8LBQpa6myXRMQaKnnnNIw8No2Wa1pPd3W7JV B5V9PbEFckaZnfrVIErnoOYeJP9rCVKfJJBKTtLL/XjG/weQcPr4tV9saF12D3c4MJPw nEIfArL7YFZEa2IWsskby/DF/VeGzYSI+NsOjbiQgVQ7MHvJIoPlZUoY7BMa+0KVqsow R5cAlsMAKwQdU42VKP5/vXj1EDmGRpebBzCLRCJqw8EZOcdK0HRDG+pkTJsjiNVC4S4l 5djA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=l+s9+Jk8HrmBBbDyZWsezOC2KHIOu1EFQvBqPXfwSnY=; b=EQoe2oYs5Lmrbt/WqWhksP/PWfRlOhD+aUuYqWN3SehAxZqHwGNlJcOeTn6qEX6BuM KC0T8qOFdXL0G1puAmM4K6+5IUKm1u9BSCwUwYYs6NaJw67yUiqgPsd421DBRsmtkna/ Vl4t0LGw7i+4edcVa+mesvLe6WIlE+hYktHsoZYDn2D7aFR3JHkb5I+n6pNnemqy+lnK CtOibhtTBZT4tO/zmXl5L3n0Eb0YySCIfL6cUP+3r3Qsk+Uc0v1Uj5r3iOhUbZf2M9+a BqUy7El+zvb6MRfCs4U1JvMOGO9S8MPP18/ndQb3xUIjRScDbUxpMsX4O81/rEU9U81R JYBw== X-Gm-Message-State: ALQs6tB2wEofUZggm5wRqS3bnNkOg2O2LemWpl0pphY+J5LfldCiFaU4 KBE30CDmn4nB4lzhQ72m8yySnoxmTsQ= X-Google-Smtp-Source: AB8JxZqL8fQjkX5BhI4dGa9I+aTtR+82V139s6QANsBIATguI1I+mhYjkG9cXga9Q/dP/Hju4vLgtA== X-Received: by 10.28.62.79 with SMTP id l76mr6316032wma.145.1525077231821; Mon, 30 Apr 2018 01:33:51 -0700 (PDT) Received: from localhost.localdomain (193.164.125.18.ip.redstone-isp.net. [193.164.125.18]) by smtp.gmail.com with ESMTPSA id v12-v6sm5766947wrm.68.2018.04.30.01.33.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 30 Apr 2018 01:33:51 -0700 (PDT) From: Alex Kiernan To: u-boot@lists.denx.de Date: Mon, 30 Apr 2018 08:32:52 +0000 Message-Id: <1525077174-6211-19-git-send-email-alex.kiernan@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1525077174-6211-1-git-send-email-alex.kiernan@gmail.com> References: <1525077174-6211-1-git-send-email-alex.kiernan@gmail.com> Cc: Jocelyn Bohr Subject: [U-Boot] [RFC PATCH v2 18/20] fastboot: Check if part_name is NULL before using it X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" If we don't have a partition name passed, report it as not found. Signed-off-by: Alex Kiernan Acked-by: Joe Hershberger Reviewed-by: Jocelyn Bohr --- Changes in v2: None drivers/fastboot/fb_getvar.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/fastboot/fb_getvar.c b/drivers/fastboot/fb_getvar.c index 7989a19..cc74bab 100644 --- a/drivers/fastboot/fb_getvar.c +++ b/drivers/fastboot/fb_getvar.c @@ -66,7 +66,8 @@ void fb_getvar(char *cmd_parameter, char *response) dev_desc = blk_get_dev("mmc", 0); if (!dev_desc) { fastboot_fail("block device not found", response); - } else if (part_get_info_by_name(dev_desc, part_name, + } else if (!part_name || + part_get_info_by_name(dev_desc, part_name, &part_info) < 0) { fastboot_fail("partition not found", response); } else if (!strcmp_l1("partition-type", cmd_parameter)) {