diff mbox series

[U-Boot,RFC,v2,18/20] fastboot: Check if part_name is NULL before using it

Message ID 1525077174-6211-19-git-send-email-alex.kiernan@gmail.com
State RFC
Delegated to: Lukasz Majewski
Headers show
Series Add fastboot UDP support | expand

Commit Message

Alex Kiernan April 30, 2018, 8:32 a.m. UTC
If we don't have a partition name passed, report it as not found.

Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
---

Changes in v2: None

 drivers/fastboot/fb_getvar.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Joe Hershberger May 3, 2018, 9:26 p.m. UTC | #1
On Mon, Apr 30, 2018 at 3:32 AM, Alex Kiernan <alex.kiernan@gmail.com> wrote:
> If we don't have a partition name passed, report it as not found.
>
> Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Jocelyn Bohr May 8, 2018, 6:55 a.m. UTC | #2
On Thu, May 3, 2018 at 2:26 PM Joe Hershberger <joe.hershberger@gmail.com>
wrote:

> On Mon, Apr 30, 2018 at 3:32 AM, Alex Kiernan <alex.kiernan@gmail.com>
> wrote:
> > If we don't have a partition name passed, report it as not found.
> >
> > Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
>

Reviewed-by: Jocelyn Bohr <bohr@google.com>
diff mbox series

Patch

diff --git a/drivers/fastboot/fb_getvar.c b/drivers/fastboot/fb_getvar.c
index 7989a19..cc74bab 100644
--- a/drivers/fastboot/fb_getvar.c
+++ b/drivers/fastboot/fb_getvar.c
@@ -66,7 +66,8 @@  void fb_getvar(char *cmd_parameter, char *response)
 		dev_desc = blk_get_dev("mmc", 0);
 		if (!dev_desc) {
 			fastboot_fail("block device not found", response);
-		} else if (part_get_info_by_name(dev_desc, part_name,
+		} else if (!part_name ||
+			   part_get_info_by_name(dev_desc, part_name,
 						 &part_info) < 0) {
 			fastboot_fail("partition not found", response);
 		} else if (!strcmp_l1("partition-type", cmd_parameter)) {