| Message ID | 152354d05f56c57a21a6306745051a0961ea3c66.1657271690.git.michal.simek@amd.com |
|---|---|
| State | Accepted |
| Commit | f36479e302231c68b63ee3a59a45081a3eb2c750 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | ti: keystone: Don't select GPIO_EXTRA_HEADER | expand |
On Fri, Jul 08, 2022 at 11:14:52AM +0200, Michal Simek wrote: > keystone doesn't have custom gpio.h that's why don't select > GPIO_EXTRA_HEADER which points to it. > > Logic in arch/arm/include/asm/gpio.h is very clear > > #ifdef CONFIG_GPIO_EXTRA_HEADER > #include <asm/arch/gpio.h> > #endif > #include <asm-generic/gpio.h> > > Where it is visible that there is no gpio.h in platform headers: > $ ls arch/arm/mach-keystone/include/mach/ > clock_defs.h clock-k2e.h clock-k2hk.h ddr3.h hardware-k2e.h > hardware-k2hk.h i2c_defs.h mon.h mux-k2g.h xhci-keystone.h > clock.h clock-k2g.h clock-k2l.h hardware.h hardware-k2g.h > hardware-k2l.h mmc_host_def.h msmc.h psc_defs.h > > Signed-off-by: Michal Simek <michal.simek@amd.com> Reviewed-by: Tom Rini <trini@konsulko.com>
On 7/8/22 11:14, Michal Simek wrote: > keystone doesn't have custom gpio.h that's why don't select > GPIO_EXTRA_HEADER which points to it. > > Logic in arch/arm/include/asm/gpio.h is very clear > > #ifdef CONFIG_GPIO_EXTRA_HEADER > #include <asm/arch/gpio.h> > #endif > #include <asm-generic/gpio.h> > > Where it is visible that there is no gpio.h in platform headers: > $ ls arch/arm/mach-keystone/include/mach/ > clock_defs.h clock-k2e.h clock-k2hk.h ddr3.h hardware-k2e.h > hardware-k2hk.h i2c_defs.h mon.h mux-k2g.h xhci-keystone.h > clock.h clock-k2g.h clock-k2l.h hardware.h hardware-k2g.h > hardware-k2l.h mmc_host_def.h msmc.h psc_defs.h > > Signed-off-by: Michal Simek <michal.simek@amd.com> > --- > > arch/arm/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index ef79fc3a0a76..ac3c2ab2e593 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -829,7 +829,6 @@ config ARCH_KEYSTONE > select CMD_POWEROFF > select CPU_V7A > select DDR_SPD > - select GPIO_EXTRA_HEADER > select SUPPORT_SPL > select SYS_ARCH_TIMER > select SYS_THUMB_BUILD I will take this via my tree because it looks like this platform is not actively maintained. Thanks, Michal
On Fri, Jul 08, 2022 at 11:14:52AM +0200, Michal Simek wrote: > keystone doesn't have custom gpio.h that's why don't select > GPIO_EXTRA_HEADER which points to it. > > Logic in arch/arm/include/asm/gpio.h is very clear > > #ifdef CONFIG_GPIO_EXTRA_HEADER > #include <asm/arch/gpio.h> > #endif > #include <asm-generic/gpio.h> > > Where it is visible that there is no gpio.h in platform headers: > $ ls arch/arm/mach-keystone/include/mach/ > clock_defs.h clock-k2e.h clock-k2hk.h ddr3.h hardware-k2e.h > hardware-k2hk.h i2c_defs.h mon.h mux-k2g.h xhci-keystone.h > clock.h clock-k2g.h clock-k2l.h hardware.h hardware-k2g.h > hardware-k2l.h mmc_host_def.h msmc.h psc_defs.h > > Signed-off-by: Michal Simek <michal.simek@amd.com> > Reviewed-by: Tom Rini <trini@konsulko.com> Applied to u-boot/master, thanks!
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index ef79fc3a0a76..ac3c2ab2e593 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -829,7 +829,6 @@ config ARCH_KEYSTONE select CMD_POWEROFF select CPU_V7A select DDR_SPD - select GPIO_EXTRA_HEADER select SUPPORT_SPL select SYS_ARCH_TIMER select SYS_THUMB_BUILD
keystone doesn't have custom gpio.h that's why don't select GPIO_EXTRA_HEADER which points to it. Logic in arch/arm/include/asm/gpio.h is very clear #ifdef CONFIG_GPIO_EXTRA_HEADER #include <asm/arch/gpio.h> #endif #include <asm-generic/gpio.h> Where it is visible that there is no gpio.h in platform headers: $ ls arch/arm/mach-keystone/include/mach/ clock_defs.h clock-k2e.h clock-k2hk.h ddr3.h hardware-k2e.h hardware-k2hk.h i2c_defs.h mon.h mux-k2g.h xhci-keystone.h clock.h clock-k2g.h clock-k2l.h hardware.h hardware-k2g.h hardware-k2l.h mmc_host_def.h msmc.h psc_defs.h Signed-off-by: Michal Simek <michal.simek@amd.com> --- arch/arm/Kconfig | 1 - 1 file changed, 1 deletion(-)