diff mbox series

[U-Boot,v2,04/15] dm: gpio: Convert stm32f7 driver to livetree

Message ID 1520847978-24321-5-git-send-email-patrick.delaunay@st.com
State Accepted
Delegated to: Tom Rini
Headers show
Series arm: stm32mp1: add initial support for STM32MP157 | expand

Commit Message

Patrick DELAUNAY March 12, 2018, 9:46 a.m. UTC 
Update the GPIO driver to support a live device tree.

Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
---

Changes in v2: None

 drivers/gpio/stm32f7_gpio.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

Comments

Tom Rini March 19, 2018, 10:35 p.m. UTC | #1 
On Mon, Mar 12, 2018 at 10:46:07AM +0100, Patrick Delaunay wrote:

> Update the GPIO driver to support a live device tree.
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/drivers/gpio/stm32f7_gpio.c b/drivers/gpio/stm32f7_gpio.c
index a7cfb8c..11bc66d 100644
--- a/drivers/gpio/stm32f7_gpio.c
+++ b/drivers/gpio/stm32f7_gpio.c
@@ -16,14 +16,11 @@ 
 #include <linux/errno.h>
 #include <linux/io.h>
 
-#define MAX_SIZE_BANK_NAME		5
 #define STM32_GPIOS_PER_BANK		16
 #define MODE_BITS(gpio_pin)		(gpio_pin * 2)
 #define MODE_BITS_MASK			3
 #define IN_OUT_BIT_INDEX(gpio_pin)	(1UL << (gpio_pin))
 
-DECLARE_GLOBAL_DATA_PTR;
-
 static int stm32_gpio_direction_input(struct udevice *dev, unsigned offset)
 {
 	struct stm32_gpio_priv *priv = dev_get_priv(dev);
@@ -82,17 +79,14 @@  static int gpio_stm32_probe(struct udevice *dev)
 	struct gpio_dev_priv *uc_priv = dev_get_uclass_priv(dev);
 	struct stm32_gpio_priv *priv = dev_get_priv(dev);
 	fdt_addr_t addr;
-	char *name;
+	const char *name;
 
-	addr = devfdt_get_addr(dev);
+	addr = dev_read_addr(dev);
 	if (addr == FDT_ADDR_T_NONE)
 		return -EINVAL;
 
 	priv->regs = (struct stm32_gpio_regs *)addr;
-	name = (char *)fdtdec_locate_byte_array(gd->fdt_blob,
-						dev_of_offset(dev),
-						"st,bank-name",
-						MAX_SIZE_BANK_NAME);
+	name = dev_read_string(dev, "st,bank-name");
 	if (!name)
 		return -EINVAL;
 	uc_priv->bank_name = name;