| Message ID | 1518793646-15375-1-git-send-email-philipp.tomsich@theobroma-systems.com |
|---|---|
| State | Accepted |
| Commit | a9bdd67653c026d3f568375ca8e48fb5014c62c9 |
| Delegated to: | Philipp Tomsich |
| Headers | show |
| Series | [U-Boot,1/2] rockchip: clk: rk3399: handle clk_enable requests for GMAC | expand |
> Since commit ba1f96672522 ("net: designware: add clock support"), the > designware GMAC driver enables all referenced clocks. While this is a > no-op for the RK3399 during boot-up (reset behaviour has all the clock > gates open anyway), we still need to handle the clock-ids passed in > the enable op of the clock-driver and return a success. > > This change extends the enable-op of the rk3399 clk driver to signal > success to the caller when the clocks for the GMAC are enabled. > > References: commit ba1f96672522 ("net: designware: add clock support") > Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > Tested-by: Klaus Goger <klaus.goger@theobroma-systems.com> > --- > > drivers/clk/rockchip/clk_rk3399.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > Applied to u-boot-rockchip, thanks!
diff --git a/drivers/clk/rockchip/clk_rk3399.c b/drivers/clk/rockchip/clk_rk3399.c index 42926ba..8822d3a 100644 --- a/drivers/clk/rockchip/clk_rk3399.c +++ b/drivers/clk/rockchip/clk_rk3399.c @@ -997,6 +997,16 @@ static int rk3399_clk_enable(struct clk *clk) case HCLK_HOST1: case HCLK_HOST1_ARB: return 0; + + case SCLK_MAC: + case SCLK_MAC_RX: + case SCLK_MAC_TX: + case SCLK_MACREF: + case SCLK_MACREF_OUT: + case ACLK_GMAC: + case PCLK_GMAC: + /* Required to successfully probe the Designware GMAC driver */ + return 0; } debug("%s: unsupported clk %ld\n", __func__, clk->id);
Since commit ba1f96672522 ("net: designware: add clock support"), the designware GMAC driver enables all referenced clocks. While this is a no-op for the RK3399 during boot-up (reset behaviour has all the clock gates open anyway), we still need to handle the clock-ids passed in the enable op of the clock-driver and return a success. This change extends the enable-op of the rk3399 clk driver to signal success to the caller when the clocks for the GMAC are enabled. References: commit ba1f96672522 ("net: designware: add clock support") Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> Tested-by: Klaus Goger <klaus.goger@theobroma-systems.com> --- drivers/clk/rockchip/clk_rk3399.c | 10 ++++++++++ 1 file changed, 10 insertions(+)