From patchwork Tue Feb 6 14:25:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 869796 X-Patchwork-Delegate: marek.vasut@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QaDr5oX9"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3zbRs94Vw8z9s82 for ; Wed, 7 Feb 2018 01:38:21 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 2A74CC21E40; Tue, 6 Feb 2018 14:32:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 5E3A5C21E3A; Tue, 6 Feb 2018 14:31:43 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id CA9B8C21E4B; Tue, 6 Feb 2018 14:31:33 +0000 (UTC) Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com [209.85.192.196]) by lists.denx.de (Postfix) with ESMTPS id D9B9AC21E35 for ; Tue, 6 Feb 2018 14:31:28 +0000 (UTC) Received: by mail-pf0-f196.google.com with SMTP id y9so666966pfl.2 for ; Tue, 06 Feb 2018 06:31:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cFZRzjGwDViQcgzSCKKESNS5+ghiQFg1Nfo6Yx5b5+E=; b=QaDr5oX9fxfxV8aS5k52egsuzZXJyVirEh5u5GMr/7xNL9NB1G9Jt9C3j/L4Hw52Bu PNDUe1vIx5eXMbn+hPa1om0tSUyiTSkhUkhsj1l10Lt2RzZVlbjILQj4LbDCNPaGNgU9 TIzQBwLqbyqYJ9hOMZdW1qxohUITWo7ofe1jO++eQmwqLOKy+f9jhNZfdS/Obcw8aesj XcH1VN+yrq/0U90iO30fNSbS8HSsbcTVkKvNja3QOrQIFzzc1aLZFqBNyqXXn4uWkOAy 0UhqAx+13ipaU0+PP2t3Z2AKafE2H6AllJXzNvNycMApsRZnnujEKCnqzow9ZRmFpuET ju5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cFZRzjGwDViQcgzSCKKESNS5+ghiQFg1Nfo6Yx5b5+E=; b=AZvm3Q8Hq7ayh722B+c6HEv6V8Tqqb6vLpJIOlgzC6RvWiHMScD3FiwUE5YLcbZRsL VEeEm+gQ7naEApjfZjKoXV1AigTkbrFrxJCsboWcAls21BplY2ilT8/7XuUZJaQgIrIS FYaXyU9TP0vtIdYXHDbnaNE5daCcayPaVto/azS8GI5FzYrNukfcDKn2Bv1sV1P10XK6 QOs0sGW/g/KFjUD3hmeQBvAvw5yJXqMluze05AyYka7XUvU4v36zmBryqWmDZAUteLBS dlEb3i94RUSyWNLJTetQp5DoRZAgRVmObn+6xVvDLm5EmG/yxRmOSrLhywKp3VU2N4hr pIuA== X-Gm-Message-State: APf1xPDojD7TShPpq8L+OkKDbaCDbEkGGuTmSlZ46FnU8t4O0sRjs8oO iKmyO1JBM+U5KyizNiSDqIFIQ15k X-Google-Smtp-Source: AH8x226GGBTMgfFeZWReMWLZVTRrvrO6ljvgb7Znr4keIUiFShNkjNT1PRytK2x0jjObm5MidUpS5g== X-Received: by 10.99.177.4 with SMTP id r4mr2115699pgf.245.1517927487118; Tue, 06 Feb 2018 06:31:27 -0800 (PST) Received: from localhost.localdomain ([115.97.187.51]) by smtp.gmail.com with ESMTPSA id h2sm17457613pgp.65.2018.02.06.06.31.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 06 Feb 2018 06:31:26 -0800 (PST) From: Jagan Teki X-Google-Original-From: Jagan Teki To: u-boot@lists.denx.de Date: Tue, 6 Feb 2018 19:55:33 +0530 Message-Id: <1517927164-18197-4-git-send-email-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1517927164-18197-1-git-send-email-jagan@amarulasolutions.com> References: <1517927164-18197-1-git-send-email-jagan@amarulasolutions.com> Cc: Marek Vasut , Maxime Ripard Subject: [U-Boot] [PATCH v4 03/34] musb: sunxi: Use simple way to fill musb_hdrc pdata X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Filling musb_hdrc pdata using structure will unnecessary add extra ifdefs, so fill them inside probe call for better code understanding and get rid ifdefs using devicetree compatible. Signed-off-by: Jagan Teki --- drivers/usb/musb-new/sunxi.c | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/drivers/usb/musb-new/sunxi.c b/drivers/usb/musb-new/sunxi.c index 3f3b898..0b7ff9f 100644 --- a/drivers/usb/musb-new/sunxi.c +++ b/drivers/usb/musb-new/sunxi.c @@ -308,22 +308,12 @@ static struct musb_hdrc_config musb_config = { .ram_bits = SUNXI_MUSB_RAM_BITS, }; -static struct musb_hdrc_platform_data musb_plat = { -#if defined(CONFIG_USB_MUSB_HOST) - .mode = MUSB_HOST, -#else - .mode = MUSB_PERIPHERAL, -#endif - .config = &musb_config, - .power = 250, - .platform_ops = &sunxi_musb_ops, -}; - static int musb_usb_probe(struct udevice *dev) { struct sunxi_glue *glue = dev_get_priv(dev); struct musb_host_data *host = &glue->mdata; struct usb_bus_priv *priv = dev_get_uclass_priv(dev); + struct musb_hdrc_platform_data pdata; void *base = dev_read_addr_ptr(dev); int ret; @@ -336,8 +326,13 @@ static int musb_usb_probe(struct udevice *dev) priv->desc_before_addr = true; + pdata.power = 250; + pdata.platform_ops = &sunxi_musb_ops; + pdata.config = &musb_config; + #ifdef CONFIG_USB_MUSB_HOST - host->host = musb_init_controller(&musb_plat, &glue->dev, base); + pdata.mode = MUSB_HOST; + host->host = musb_init_controller(&pdata, &glue->dev, base); if (!host->host) return -EIO; @@ -345,7 +340,8 @@ static int musb_usb_probe(struct udevice *dev) if (!ret) printf("Allwinner mUSB OTG (Host)\n"); #else - ret = musb_register(&musb_plat, &glue->dev, base); + pdata.mode = MUSB_PERIPHERAL; + ret = musb_register(&pdata, &glue->dev, base); if (!ret) printf("Allwinner mUSB OTG (Peripheral)\n"); #endif