| Message ID | 1507653823-16651-2-git-send-email-fabio.estevam@nxp.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [U-Boot,1/2] mx6slevk: Call gpio_request() | expand |
Hi Fabio, > -----Original Message----- > From: Fabio Estevam [mailto:fabio.estevam@nxp.com] > Sent: Wednesday, October 11, 2017 12:44 AM > To: sbabic@denx.de > Cc: Peng Fan <peng.fan@nxp.com>; u-boot@lists.denx.de; Fabio Estevam > <fabio.estevam@nxp.com> > Subject: [PATCH 2/2] mx6slevk: Remove some DM drivers > > While having DM driver is a good thing, currently this defconfig is completely > broken in a way that SD cards can not even be detected. > > Remove some of the DM drivers to avoid the regression for now and allow > booting a kernel stored in the SD card again. > > Re-adding the DM drivers can be revisited later. When adding DM support, I have tested on my board. What issue do you see? Thanks, Peng. > > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> > --- > Applied on top of: > > https://patchwork.ozlabs.org/patch/820477/ > > and > > https://patchwork.ozlabs.org/patch/820298/ > > configs/mx6slevk_defconfig | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/configs/mx6slevk_defconfig b/configs/mx6slevk_defconfig index > c876c6b..51735ec 100644 > --- a/configs/mx6slevk_defconfig > +++ b/configs/mx6slevk_defconfig > @@ -3,7 +3,7 @@ CONFIG_ARCH_MX6=y > CONFIG_TARGET_MX6SLEVK=y > # CONFIG_CMD_BMODE is not set > CONFIG_DEFAULT_DEVICE_TREE="imx6sl-evk" > - > CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/mx6slevk/imx > image.cfg,MX6SL" > +CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/mx6slevk/im > ximage.cfg,MX6SL,SYS_I2C" > CONFIG_BOOTDELAY=3 > CONFIG_BOARD_EARLY_INIT_F=y > CONFIG_HUSH_PARSER=y > @@ -29,21 +29,12 @@ CONFIG_OF_CONTROL=y > CONFIG_ENV_IS_IN_MMC=y > CONFIG_DM=y > # CONFIG_BLK is not set > -CONFIG_DM_GPIO=y > -CONFIG_DM_I2C=y > -CONFIG_DM_MMC=y > CONFIG_CMD_PART=y > CONFIG_SPI_FLASH=y > CONFIG_SPI_FLASH_STMICRO=y > CONFIG_PHYLIB=y > CONFIG_PINCTRL=y > CONFIG_PINCTRL_IMX6=y > -CONFIG_DM_PMIC=y > -CONFIG_DM_PMIC_PFUZE100=y > -CONFIG_DM_REGULATOR=y > -CONFIG_DM_REGULATOR_PFUZE100=y > -CONFIG_DM_REGULATOR_FIXED=y > -CONFIG_DM_REGULATOR_GPIO=y > CONFIG_DM_THERMAL=y > CONFIG_USB=y > CONFIG_USB_STORAGE=y > -- > 2.7.4
Hi Peng,
On Tue, Oct 10, 2017 at 9:50 PM, Peng Fan <peng.fan@nxp.com> wrote:
> When adding DM support, I have tested on my board. What issue do you see?
SD card is not detected, so I cannot load the zImage with mainline U-Boot.
Please test it using the latest U-Boot mainline.
Thanks
diff --git a/configs/mx6slevk_defconfig b/configs/mx6slevk_defconfig index c876c6b..51735ec 100644 --- a/configs/mx6slevk_defconfig +++ b/configs/mx6slevk_defconfig @@ -3,7 +3,7 @@ CONFIG_ARCH_MX6=y CONFIG_TARGET_MX6SLEVK=y # CONFIG_CMD_BMODE is not set CONFIG_DEFAULT_DEVICE_TREE="imx6sl-evk" -CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/mx6slevk/imximage.cfg,MX6SL" +CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/mx6slevk/imximage.cfg,MX6SL,SYS_I2C" CONFIG_BOOTDELAY=3 CONFIG_BOARD_EARLY_INIT_F=y CONFIG_HUSH_PARSER=y @@ -29,21 +29,12 @@ CONFIG_OF_CONTROL=y CONFIG_ENV_IS_IN_MMC=y CONFIG_DM=y # CONFIG_BLK is not set -CONFIG_DM_GPIO=y -CONFIG_DM_I2C=y -CONFIG_DM_MMC=y CONFIG_CMD_PART=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_STMICRO=y CONFIG_PHYLIB=y CONFIG_PINCTRL=y CONFIG_PINCTRL_IMX6=y -CONFIG_DM_PMIC=y -CONFIG_DM_PMIC_PFUZE100=y -CONFIG_DM_REGULATOR=y -CONFIG_DM_REGULATOR_PFUZE100=y -CONFIG_DM_REGULATOR_FIXED=y -CONFIG_DM_REGULATOR_GPIO=y CONFIG_DM_THERMAL=y CONFIG_USB=y CONFIG_USB_STORAGE=y
While having DM driver is a good thing, currently this defconfig is completely broken in a way that SD cards can not even be detected. Remove some of the DM drivers to avoid the regression for now and allow booting a kernel stored in the SD card again. Re-adding the DM drivers can be revisited later. Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> --- Applied on top of: https://patchwork.ozlabs.org/patch/820477/ and https://patchwork.ozlabs.org/patch/820298/ configs/mx6slevk_defconfig | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)