From patchwork Mon Sep 18 13:40:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bin Meng X-Patchwork-Id: 814931 X-Patchwork-Delegate: marek.vasut@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="bD67X/wO"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3xwnJw6S7xz9s4s for ; Mon, 18 Sep 2017 23:43:28 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id AD6CDC21F61; Mon, 18 Sep 2017 13:38:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 34355C21F33; Mon, 18 Sep 2017 13:37:13 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id DAA80C21F28; Mon, 18 Sep 2017 13:36:42 +0000 (UTC) Received: from mail-io0-f194.google.com (mail-io0-f194.google.com [209.85.223.194]) by lists.denx.de (Postfix) with ESMTPS id F0F23C21F37 for ; Mon, 18 Sep 2017 13:36:38 +0000 (UTC) Received: by mail-io0-f194.google.com with SMTP id g32so1096613ioj.1 for ; Mon, 18 Sep 2017 06:36:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NzwY9qWMK77jWueDYF/crK8fOTqwT3TZfjv00T2Z3rI=; b=bD67X/wORN135iPYrMI+/ADbeo8S7YMlvjXfKzI1TuMIwV/ZzpHpT21k3HEJkl2Eoz k0O6+6Jpc86bJ5UPxV3yJY+RPpKVCASJcwiV+8spiPxdCzjpVVHQYRkD0lpzDYUwGQYD PyG2rt6q/a1LwI1A0NxBrdqFQAeoWM0be6AOzft4dxWOKxjCgmNWuCHpxH4XLWzt2I2H GgrcdyOvYmoqgePLG+/w3buzKj9xu7TfTiC462gdR1FfQnehuRzoLDXBskUUn9HqkS4g imJ6MFNbZhF8dflr02dKTTp1450YEmS8+lnZSvs+YKSugBSa4shTV+KIgFQRh5wlbiVl 7xjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NzwY9qWMK77jWueDYF/crK8fOTqwT3TZfjv00T2Z3rI=; b=QycSa/6RdMn57PrmJXrZ7C4FoTbzOFq/EA/XrpKbWoTxqYfXSVpeQyUwvEuadiTa4h XxT0zy6tSfEWELYOXokwfSfe+1Yx/IIsNZmHnDfocoiwLYLWum8EQ9CdHeFYxAbE7lIg JzMoR41o6JHcVUBtI+bufDMd77FnUuxRytzcHnZGwiRlCMoz1fv+XFkj+PKrd7Lg6oIr xflZ4Kibs4n17niWWXqukBKyyD2VyChWXh/+a1o1k9Oc5bod2+8CfBtXqibSNPyGA7FJ XIijMpdDv3A0Q0tClG5UlK2QcD/KkDnOOO2s3oq8LcXdlGbAcPjgk/Deig7zSiGkZYAI jBVA== X-Gm-Message-State: AHPjjUgccg/ryHfJCYc09r9twbBHANdKbEb4sEk4GU3c1N+zx1EZXxij Ih75hVlnb6Bqqw== X-Google-Smtp-Source: AOwi7QB11uP9WeuoyumuhGZLVDZzfa1MrckCEK77OTWQu29hhcYb2nmbeNWQ7PK6Laar4zhLEBJtyQ== X-Received: by 10.107.20.215 with SMTP id 206mr19428954iou.116.1505741797932; Mon, 18 Sep 2017 06:36:37 -0700 (PDT) Received: from ala-d2121-lx1.wrs.com (unknown-156-139.windriver.com. [147.11.156.139]) by smtp.gmail.com with ESMTPSA id 193sm2528740ion.83.2017.09.18.06.36.36 (version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 18 Sep 2017 06:36:36 -0700 (PDT) From: Bin Meng To: Marek Vasut , U-Boot Mailing List Date: Mon, 18 Sep 2017 06:40:43 -0700 Message-Id: <1505742050-5697-8-git-send-email-bmeng.cn@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1505742050-5697-1-git-send-email-bmeng.cn@gmail.com> References: <1505742050-5697-1-git-send-email-bmeng.cn@gmail.com> Cc: Stefan Roese Subject: [U-Boot] [PATCH 07/14] usb: Read device descriptor after device is addressed for xHCI X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" For xHCI it is not possible to read a device descriptor before it has been assigned an address. That's why usb_setup_descriptor() was called with 'do_read' being false. But we really need try to read the device descriptor before starting any real communication with the default control endpoint. Signed-off-by: Bin Meng Reviewed-by: Stefan Roese Tested-by: Stefan Roese --- common/usb.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/common/usb.c b/common/usb.c index 88cee81..8d27bc7 100644 --- a/common/usb.c +++ b/common/usb.c @@ -1052,6 +1052,17 @@ static int usb_prepare_device(struct usb_device *dev, int addr, bool do_read, mdelay(10); /* Let the SET_ADDRESS settle */ + /* + * If we haven't read device descriptor before, read it here + * after device is assigned an address. This is only applicable + * to xHCI so far. + */ + if (!do_read) { + err = usb_setup_descriptor(dev, true); + if (err) + return err; + } + return 0; }