From patchwork Mon Sep 4 04:00:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bin Meng X-Patchwork-Id: 809508 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="nAWrpOe4"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3xlwz76ZRdz9s2G for ; Mon, 4 Sep 2017 13:57:23 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 8B998C21DCE; Mon, 4 Sep 2017 03:56:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 8835EC21DF0; Mon, 4 Sep 2017 03:56:00 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id E7050C21E90; Mon, 4 Sep 2017 03:55:53 +0000 (UTC) Received: from mail-pg0-f65.google.com (mail-pg0-f65.google.com [74.125.83.65]) by lists.denx.de (Postfix) with ESMTPS id DDD69C21DCB for ; Mon, 4 Sep 2017 03:55:49 +0000 (UTC) Received: by mail-pg0-f65.google.com with SMTP id m15so3690981pgc.0 for ; Sun, 03 Sep 2017 20:55:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=jWTW5vu3NgWwp4tLLXHpKXy7gO9CCJEqQDUN/lA9P84=; b=nAWrpOe4K4IR5+EBcggkJzIGeenuvaya1+uh45UyS0sWZ7H8Skw+EDtlh9o5BgKVg9 Q5MO+b4W0/6DXsIEKXbQf4czlsEPG8i2U17KHT0N501qgZKUGsG13PiWaInn7YtlqAwI SMARG0YXhtfbTXic97CxocCsP0ySyNad3+2feG0+kKagOVB7OiY41TZ0aek9q5QZ8lba ldfRWbguw99RnJOmdMmrErEe+SDhTIYFQPY8+EjQbrLvcmZQabRtF6dJ7WkVT8W6NWq3 Re74JwooobMtixa3PZUcRyguj2Jsa2PbkkxQVVJ95VByG76h7jfq/BOzkM8RjSPBMHQY Tg2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=jWTW5vu3NgWwp4tLLXHpKXy7gO9CCJEqQDUN/lA9P84=; b=NWmvp+irjgbIFh6GWraxS4JE9UEtfwJBNHjb6PvyOtdPNi+80/aegEB6AU++KOoN6O Zo/AJdKCmuNTSP2NXM101L8En2uEVCw5lZpVxCXmx7iqMY1BEo6KV5uj31BfqxONU7fv /55GNA4rtA6V1pgy6IKWIMb990GPxYw25i1sMNRrouTiuIBqLN0yhwfzMwr7h5kUHjJA tHLrXjbrvtGOu+KsVD0yxLDdew3e0xXwGqAsxAiq/0cw1iY/IGwHZ2z2oBnWYXfDAPMr kMaNgqVhI/NHyWkrjaLEwcxLUlQmyalcrkszVSp8z1EvZPTUczjRW2F8JC9mT2WzMsD6 s23g== X-Gm-Message-State: AHPjjUho+wu9Qe7bEhjOrkLYzx+MTvbuPubAO7FP+w2f/FtY6DJu7BYW a/6IIP+tAqYfCA== X-Google-Smtp-Source: ADKCNb70oWV8xZ+PsPsGkP3uWDssukYopdyw22wo6akwjXRy6eFRSfRJpld76oCe0oqU4DLVBOe9wQ== X-Received: by 10.98.25.213 with SMTP id 204mr4981359pfz.0.1504497348616; Sun, 03 Sep 2017 20:55:48 -0700 (PDT) Received: from ala-d2121-lx1.wrs.com (unknown-156-139.windriver.com. [147.11.156.139]) by smtp.gmail.com with ESMTPSA id f5sm8458163pga.32.2017.09.03.20.55.47 (version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 03 Sep 2017 20:55:47 -0700 (PDT) From: Bin Meng To: Tom Rini , Simon Glass , Heinrich Schuchardt , U-Boot Mailing List Date: Sun, 3 Sep 2017 21:00:09 -0700 Message-Id: <1504497610-4775-3-git-send-email-bmeng.cn@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1504497610-4775-1-git-send-email-bmeng.cn@gmail.com> References: <1504497610-4775-1-git-send-email-bmeng.cn@gmail.com> Subject: [U-Boot] [PATCH 3/4] block: ide: Don't bother to create BLK device if no CDROM inserted X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" When there is no CDROM inserted, the block size is zero hence there is no need to create a BLK device for it. Signed-off-by: Bin Meng --- drivers/block/ide.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/block/ide.c b/drivers/block/ide.c index 58b295e..8125ff8 100644 --- a/drivers/block/ide.c +++ b/drivers/block/ide.c @@ -1197,6 +1197,13 @@ static int ide_probe(struct udevice *udev) blksz = ide_dev_desc[i].blksz; size = blksz * ide_dev_desc[i].lba; + + /* + * With CDROM, if there is no CD inserted, blksz will + * be zero, don't bother to create IDE block device. + */ + if (!blksz) + continue; ret = blk_create_devicef(udev, "ide_blk", name, IF_TYPE_IDE, i, blksz, size, &blk_dev);