| Message ID | 1504365337-32519-1-git-send-email-bmeng.cn@gmail.com |
|---|---|
| State | Accepted |
| Commit | 37d46870b31724b71f593de3eda274e9ad8026d4 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot,1/3] nvme: Fix wrong ndev->queues memset | expand |
On Sat, Sep 02, 2017 at 08:15:35AM -0700, Bin Meng wrote: > memset() was given a sizeof(NVME_Q_NUM * sizeof(struct nvme_queue *) > to clear, which is wrong. > > Reported-by: Coverity (CID: 166729) > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> Reviewed-by: Tom Rini <trini@konsulko.com>
On Sat, Sep 02, 2017 at 08:15:35AM -0700, Bin Meng wrote: > memset() was given a sizeof(NVME_Q_NUM * sizeof(struct nvme_queue *) > to clear, which is wrong. > > Reported-by: Coverity (CID: 166729) > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > Reviewed-by: Tom Rini <trini@konsulko.com> Applied to u-boot/master, thanks!
diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nvme.c index ec32d0d..4448754 100644 --- a/drivers/nvme/nvme.c +++ b/drivers/nvme/nvme.c @@ -791,8 +791,7 @@ static int nvme_probe(struct udevice *udev) printf("Error: %s: Out of memory!\n", udev->name); goto free_nvme; } - memset(ndev->queues, 0, - sizeof(NVME_Q_NUM * sizeof(struct nvme_queue *))); + memset(ndev->queues, 0, NVME_Q_NUM * sizeof(struct nvme_queue *)); ndev->prp_pool = malloc(MAX_PRP_POOL); if (!ndev->prp_pool) {
memset() was given a sizeof(NVME_Q_NUM * sizeof(struct nvme_queue *) to clear, which is wrong. Reported-by: Coverity (CID: 166729) Signed-off-by: Bin Meng <bmeng.cn@gmail.com> --- drivers/nvme/nvme.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)